Title: [257488] branches/safari-609.1.20.4-branch/Source/WebKit
Revision
257488
Author
[email protected]
Date
2020-02-26 11:19:30 -0800 (Wed, 26 Feb 2020)

Log Message

Cherry-pick r257013. rdar://problem/59789394

    Crash in WebPageProxy::didStartProvisionalLoadForFrameShared
    https://bugs.webkit.org/show_bug.cgi?id=207973

    Reviewed by Chris Dumez.

    Use RefPtr to store Frame*.

    * UIProcess/WebPageProxy.cpp:
    (WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@257013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-609.1.20.4-branch/Source/WebKit/ChangeLog (257487 => 257488)


--- branches/safari-609.1.20.4-branch/Source/WebKit/ChangeLog	2020-02-26 19:19:20 UTC (rev 257487)
+++ branches/safari-609.1.20.4-branch/Source/WebKit/ChangeLog	2020-02-26 19:19:30 UTC (rev 257488)
@@ -1,3 +1,32 @@
+2020-02-26  Russell Epstein  <[email protected]>
+
+        Cherry-pick r257013. rdar://problem/59789394
+
+    Crash in WebPageProxy::didStartProvisionalLoadForFrameShared
+    https://bugs.webkit.org/show_bug.cgi?id=207973
+    
+    Reviewed by Chris Dumez.
+    
+    Use RefPtr to store Frame*.
+    
+    * UIProcess/WebPageProxy.cpp:
+    (WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@257013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-02-19  Ryosuke Niwa  <[email protected]>
+
+            Crash in WebPageProxy::didStartProvisionalLoadForFrameShared
+            https://bugs.webkit.org/show_bug.cgi?id=207973
+
+            Reviewed by Chris Dumez.
+
+            Use RefPtr to store Frame*.
+
+            * UIProcess/WebPageProxy.cpp:
+            (WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
+
 2020-02-24  Kocsen Chung  <[email protected]>
 
         Cherry-pick r257089. rdar://problem/59676917

Modified: branches/safari-609.1.20.4-branch/Source/WebKit/UIProcess/WebPageProxy.cpp (257487 => 257488)


--- branches/safari-609.1.20.4-branch/Source/WebKit/UIProcess/WebPageProxy.cpp	2020-02-26 19:19:20 UTC (rev 257487)
+++ branches/safari-609.1.20.4-branch/Source/WebKit/UIProcess/WebPageProxy.cpp	2020-02-26 19:19:30 UTC (rev 257488)
@@ -4227,7 +4227,7 @@
 {
     PageClientProtector protector(pageClient());
 
-    WebFrameProxy* frame = process->webFrame(frameID);
+    auto frame = makeRefPtr(process->webFrame(frameID));
     MESSAGE_CHECK(process, frame);
     MESSAGE_CHECK_URL(process, url);
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to