Title: [257504] trunk/Source/WebInspectorUI
- Revision
- 257504
- Author
- [email protected]
- Date
- 2020-02-26 13:10:53 -0800 (Wed, 26 Feb 2020)
Log Message
REGRESSION: (257410) [ macOS ] inspector/network/client-blocked-load.html is failing
https://bugs.webkit.org/show_bug.cgi?id=208251
<rdar://problem/59812765>
Reviewed by Timothy Hatcher.
* UserInterface/Models/SourceCode.js:
(WI.SourceCode):
The test failed because it expected `url` to be an empty string (`""`) instead of `null`.
Use the given `url` parameter exactly as provided instead of trying to add a fallback in the
case of a falsy value. Given the prevalence of usage of `WI.SourceCode`, it's better to
match the existing behavior of before r257410 than change it and risk other subtle bugs.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (257503 => 257504)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-02-26 20:57:49 UTC (rev 257503)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-02-26 21:10:53 UTC (rev 257504)
@@ -1,3 +1,18 @@
+2020-02-26 Devin Rousso <[email protected]>
+
+ REGRESSION: (257410) [ macOS ] inspector/network/client-blocked-load.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=208251
+ <rdar://problem/59812765>
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Models/SourceCode.js:
+ (WI.SourceCode):
+ The test failed because it expected `url` to be an empty string (`""`) instead of `null`.
+ Use the given `url` parameter exactly as provided instead of trying to add a fallback in the
+ case of a falsy value. Given the prevalence of usage of `WI.SourceCode`, it's better to
+ match the existing behavior of before r257410 than change it and risk other subtle bugs.
+
2020-02-25 Nikita Vasilyev <[email protected]>
Web Inspector: AXI: buttons should be focusable when navigating by pressing Tab
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/SourceCode.js (257503 => 257504)
--- trunk/Source/WebInspectorUI/UserInterface/Models/SourceCode.js 2020-02-26 20:57:49 UTC (rev 257503)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/SourceCode.js 2020-02-26 21:10:53 UTC (rev 257504)
@@ -29,7 +29,7 @@
{
super();
- this._url = url || null;
+ this._url = url;
this._urlComponents = null;
this._originalRevision = new WI.SourceCodeRevision(this);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
