Title: [257557] trunk/Source/WebInspectorUI
Revision
257557
Author
drou...@apple.com
Date
2020-02-27 00:25:18 -0800 (Thu, 27 Feb 2020)

Log Message

Web Inspector: localize the placeholder "Header" and "value" when editing a local override
https://bugs.webkit.org/show_bug.cgi?id=208276
<rdar://problem/59763619>

Reviewed by Brian Burg.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Views/LocalResourceOverridePopover.js:
(WI.LocalResourceOverridePopover.prototype.show):

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (257556 => 257557)


--- trunk/Source/WebInspectorUI/ChangeLog	2020-02-27 05:22:46 UTC (rev 257556)
+++ trunk/Source/WebInspectorUI/ChangeLog	2020-02-27 08:25:18 UTC (rev 257557)
@@ -1,3 +1,15 @@
+2020-02-27  Devin Rousso  <drou...@apple.com>
+
+        Web Inspector: localize the placeholder "Header" and "value" when editing a local override
+        https://bugs.webkit.org/show_bug.cgi?id=208276
+        <rdar://problem/59763619>
+
+        Reviewed by Brian Burg.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        * UserInterface/Views/LocalResourceOverridePopover.js:
+        (WI.LocalResourceOverridePopover.prototype.show):
+
 2020-02-26  Devin Rousso  <drou...@apple.com>
 
         REGRESSION: (257410) [ macOS ] inspector/network/client-blocked-load.html is failing

Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (257556 => 257557)


--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2020-02-27 05:22:46 UTC (rev 257556)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2020-02-27 08:25:18 UTC (rev 257557)
@@ -607,6 +607,8 @@
 localizedStrings["HAR Import Error: %s"] = "HAR Import Error: %s";
 localizedStrings["HTML"] = "HTML";
 localizedStrings["HTML Attributes"] = "HTML Attributes";
+/* Placeholder text in an editable field for the name of a HTTP header */
+localizedStrings["Header @ Local Override Popover New Headers Data Grid Item"] = "Header";
 localizedStrings["Headers"] = "Headers";
 localizedStrings["Headers:"] = "Headers:";
 localizedStrings["Heading Level"] = "Heading Level";
@@ -1437,3 +1439,5 @@
 localizedStrings["unsupported HAR version"] = "unsupported HAR version";
 localizedStrings["unsupported version"] = "unsupported version";
 localizedStrings["value"] = "value";
+/* Placeholder text in an editable field for the value of a HTTP header */
+localizedStrings["value @ Local Override Popover New Headers Data Grid Item"] = "value";

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LocalResourceOverridePopover.js (257556 => 257557)


--- trunk/Source/WebInspectorUI/UserInterface/Views/LocalResourceOverridePopover.js	2020-02-27 05:22:46 UTC (rev 257556)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LocalResourceOverridePopover.js	2020-02-27 08:25:18 UTC (rev 257557)
@@ -281,7 +281,10 @@
         addHeaderButton.className = "add-header";
         addHeaderButton.textContent = WI.UIString("Add Header");
         addHeaderButton.addEventListener("click", (event) => {
-            let newNode = new WI.DataGridNode({name: "Header", value: "value"});
+            let newNode = new WI.DataGridNode({
+                name: WI.UIString("Header", "Header @ Local Override Popover New Headers Data Grid Item", "Placeholder text in an editable field for the name of a HTTP header"),
+                value: WI.UIString("value", "value @ Local Override Popover New Headers Data Grid Item", "Placeholder text in an editable field for the value of a HTTP header"),
+            });
             this._headersDataGrid.appendChild(newNode);
             this._headersDataGrid.updateLayoutIfNeeded();
             this.update();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to