Title: [257703] releases/WebKitGTK/webkit-2.28/Source/WebCore
Revision
257703
Author
[email protected]
Date
2020-03-02 00:36:52 -0800 (Mon, 02 Mar 2020)

Log Message

Merge r256706 - [GStreamer] Build failure with Clang/libc++ due to missing WallTime→float for std::isnan()
https://bugs.webkit.org/show_bug.cgi?id=207757

Unreviewed build fix.

No new tests needed.

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(CachedResourceStreamingClient::dataReceived): Add std:: namespace to overloaded
std::isnan() function call to ensure that the overloaded version for WTF::WallTime
is used.

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog (257702 => 257703)


--- releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog	2020-03-02 08:36:42 UTC (rev 257702)
+++ releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog	2020-03-02 08:36:52 UTC (rev 257703)
@@ -1,3 +1,17 @@
+2020-02-15  Adrian Perez de Castro  <[email protected]>
+
+        [GStreamer] Build failure with Clang/libc++ due to missing WallTime→float for std::isnan()
+        https://bugs.webkit.org/show_bug.cgi?id=207757
+
+        Unreviewed build fix.
+
+        No new tests needed.
+
+        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+        (CachedResourceStreamingClient::dataReceived): Add std:: namespace to overloaded
+        std::isnan() function call to ensure that the overloaded version for WTF::WallTime
+        is used.
+
 2020-02-26  Jack Lee  <[email protected]>
 
         Nullptr crash in WebCore::canHaveChildrenForEditing via CompositeEditCommand::insertNode

Modified: releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp (257702 => 257703)


--- releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp	2020-03-02 08:36:42 UTC (rev 257702)
+++ releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp	2020-03-02 08:36:52 UTC (rev 257703)
@@ -1152,7 +1152,7 @@
     // Rough bandwidth calculation. We ignore here the first data package because we would have to reset the counters when we issue the request and
     // that first package delivery would include the time of sending out the request and getting the data back. Since we can't distinguish the
     // sending time from the receiving time, it is better to ignore it.
-    if (!isnan(priv->downloadStartTime)) {
+    if (!std::isnan(priv->downloadStartTime)) {
         priv->totalDownloadedBytes += length;
         double timeSinceStart = (WallTime::now() - priv->downloadStartTime).seconds();
         GST_TRACE_OBJECT(src, "downloaded %" G_GUINT64_FORMAT " bytes in %f seconds =~ %1.0f bytes/second", priv->totalDownloadedBytes, timeSinceStart
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to