Title: [257712] trunk/Source/WebCore
- Revision
- 257712
- Author
- [email protected]
- Date
- 2020-03-02 07:57:15 -0800 (Mon, 02 Mar 2020)
Log Message
[GStreamer] Get rid of custom GCD implementation
https://bugs.webkit.org/show_bug.cgi?id=208446
Reviewed by Xabier Rodriguez-Calvar.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::naturalSize const):
(WebCore::greatestCommonDivisor): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (257711 => 257712)
--- trunk/Source/WebCore/ChangeLog 2020-03-02 15:54:29 UTC (rev 257711)
+++ trunk/Source/WebCore/ChangeLog 2020-03-02 15:57:15 UTC (rev 257712)
@@ -1,3 +1,14 @@
+2020-03-02 Philippe Normand <[email protected]>
+
+ [GStreamer] Get rid of custom GCD implementation
+ https://bugs.webkit.org/show_bug.cgi?id=208446
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::naturalSize const):
+ (WebCore::greatestCommonDivisor): Deleted.
+
2020-03-02 Eric Carlson <[email protected]>
[GPUP] Plumb through more MediaPlayer methods
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (257711 => 257712)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2020-03-02 15:54:29 UTC (rev 257711)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2020-03-02 15:57:15 UTC (rev 257712)
@@ -162,17 +162,6 @@
static const FloatSize s_holePunchDefaultFrameSize(1280, 720);
#endif
-static int greatestCommonDivisor(int a, int b)
-{
- while (b) {
- int temp = a;
- a = b;
- b = temp % b;
- }
-
- return ABS(a);
-}
-
static void busMessageCallback(GstBus*, GstMessage* message, MediaPlayerPrivateGStreamer* player)
{
player->handleMessage(message);
@@ -1923,7 +1912,7 @@
int displayHeight = originalSize.height() * pixelAspectRatioDenominator;
// Divide display width and height by their GCD to avoid possible overflows.
- int displayAspectRatioGCD = greatestCommonDivisor(displayWidth, displayHeight);
+ int displayAspectRatioGCD = gst_util_greatest_common_divisor(displayWidth, displayHeight);
displayWidth /= displayAspectRatioGCD;
displayHeight /= displayAspectRatioGCD;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
