Title: [257716] trunk
- Revision
- 257716
- Author
- [email protected]
- Date
- 2020-03-02 09:37:30 -0800 (Mon, 02 Mar 2020)
Log Message
maps.google.com is not loading properly, screen flickers when zooming
https://bugs.webkit.org/show_bug.cgi?id=208331
<rdar://problem/59790757>
Reviewed by Antoine Quint.
Source/WebCore:
When using ANGLE, we don't need the GL_ANGLE_depth_texture extension.
We were mistakenly checking for it and deciding to not allow
combined depth+stencil framebuffer attachments.
Test: webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html
(now passes on iOS)
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::setupFlags):
LayoutTests:
* platform/ios/TestExpectations: remove failing expectation for:
webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (257715 => 257716)
--- trunk/LayoutTests/ChangeLog 2020-03-02 16:47:59 UTC (rev 257715)
+++ trunk/LayoutTests/ChangeLog 2020-03-02 17:37:30 UTC (rev 257716)
@@ -1,3 +1,14 @@
+2020-03-02 Dean Jackson <[email protected]>
+
+ maps.google.com is not loading properly, screen flickers when zooming
+ https://bugs.webkit.org/show_bug.cgi?id=208331
+ <rdar://problem/59790757>
+
+ Reviewed by Antoine Quint.
+
+ * platform/ios/TestExpectations: remove failing expectation for:
+ webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html
+
2020-03-02 Jason Lawrence <[email protected]>
[ Mac wk1 Debug ] mathml/presentation/attributes-accent-accentunder-dynamic.html is flaky failing.
Modified: trunk/LayoutTests/platform/ios/TestExpectations (257715 => 257716)
--- trunk/LayoutTests/platform/ios/TestExpectations 2020-03-02 16:47:59 UTC (rev 257715)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2020-03-02 17:37:30 UTC (rev 257716)
@@ -3525,7 +3525,6 @@
webkit.org/b/207858 webgl/1.0.3/conformance/misc/delayed-drawing.html [ Pass Failure ]
webkit.org/b/207858 webgl/1.0.3/conformance/misc/uninitialized-test.html [ Pass Failure ]
webkit.org/b/207858 webgl/1.0.3/conformance/programs/program-test.html [ Failure ]
-webkit.org/b/207858 webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html [ Pass Failure ]
webkit.org/b/207858 webgl/1.0.3/conformance/state/state-uneffected-after-compositing.html [ Pass Failure ]
webkit.org/b/207858 webgl/1.0.3/conformance/textures/default-texture.html [ Pass Failure ]
webkit.org/b/207858 webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html [ Pass Failure ]
Modified: trunk/Source/WebCore/ChangeLog (257715 => 257716)
--- trunk/Source/WebCore/ChangeLog 2020-03-02 16:47:59 UTC (rev 257715)
+++ trunk/Source/WebCore/ChangeLog 2020-03-02 17:37:30 UTC (rev 257716)
@@ -1,3 +1,21 @@
+2020-03-02 Dean Jackson <[email protected]>
+
+ maps.google.com is not loading properly, screen flickers when zooming
+ https://bugs.webkit.org/show_bug.cgi?id=208331
+ <rdar://problem/59790757>
+
+ Reviewed by Antoine Quint.
+
+ When using ANGLE, we don't need the GL_ANGLE_depth_texture extension.
+ We were mistakenly checking for it and deciding to not allow
+ combined depth+stencil framebuffer attachments.
+
+ Test: webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html
+ (now passes on iOS)
+
+ * html/canvas/WebGLRenderingContextBase.cpp:
+ (WebCore::WebGLRenderingContextBase::setupFlags):
+
2020-03-02 Chris Dumez <[email protected]>
Add quirk to disable to back/forward cache on docs.google.com
Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp (257715 => 257716)
--- trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp 2020-03-02 16:47:59 UTC (rev 257715)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp 2020-03-02 17:37:30 UTC (rev 257716)
@@ -795,13 +795,20 @@
m_synthesizedErrorsToConsole = page->settings().webGLErrorsToConsoleEnabled();
}
+ // FIXME: With ANGLE as a backend this probably isn't needed any more. Unfortunately
+ // turning it off causes problems.
m_isGLES2Compliant = m_context->isGLES2Compliant();
if (m_isGLES2Compliant) {
m_isGLES2NPOTStrict = !m_context->getExtensions().isEnabled("GL_OES_texture_npot");
m_isDepthStencilSupported = m_context->getExtensions().isEnabled("GL_OES_packed_depth_stencil") || m_context->getExtensions().isEnabled("GL_ANGLE_depth_texture");
} else {
+#if USE(ANGLE)
+ m_isGLES2NPOTStrict = true;
+ m_isDepthStencilSupported = true;
+#else
m_isGLES2NPOTStrict = !m_context->getExtensions().isEnabled("GL_ARB_texture_non_power_of_two");
m_isDepthStencilSupported = m_context->getExtensions().isEnabled("GL_EXT_packed_depth_stencil") || m_context->getExtensions().isEnabled("GL_ANGLE_depth_texture");
+#endif
}
m_isRobustnessEXTSupported = m_context->getExtensions().isEnabled("GL_EXT_robustness");
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
