Diff
Modified: trunk/JSTests/ChangeLog (257742 => 257743)
--- trunk/JSTests/ChangeLog 2020-03-02 23:42:22 UTC (rev 257742)
+++ trunk/JSTests/ChangeLog 2020-03-02 23:53:40 UTC (rev 257743)
@@ -1,3 +1,24 @@
+2020-03-02 Saam Barati <[email protected]>
+
+ Don't skip tests unnecessarily on arm64
+ https://bugs.webkit.org/show_bug.cgi?id=208470
+ <rdar://problem/59968869>
+
+ Reviewed by Tadeu Zagallo.
+
+ * microbenchmarks/bit-test-constant.js:
+ * microbenchmarks/bit-test-nonconstant.js:
+ * microbenchmarks/memcpy-typed-loop-large.js:
+ * microbenchmarks/memcpy-typed-loop-small.js:
+ * microbenchmarks/mul-immediate-sub.js:
+ * stress/dont-range-based-iterate-vector-that-is-mutated.js:
+ * stress/dont-reserve-huge-capacity-lexer.js:
+ * stress/new-largeish-contiguous-array-with-size.js:
+ * stress/sampling-profiler-richards.js:
+ * typeProfiler/deltablue-for-of.js:
+ * typeProfiler/getter-richards.js:
+ * wasm/regress/llint-callee-saves-with-fast-memory.js:
+
2020-03-02 Justin Michaud <[email protected]>
Delete by val caching does not keep the subscript alive
Modified: trunk/JSTests/microbenchmarks/bit-test-constant.js (257742 => 257743)
--- trunk/JSTests/microbenchmarks/bit-test-constant.js 2020-03-02 23:42:22 UTC (rev 257742)
+++ trunk/JSTests/microbenchmarks/bit-test-constant.js 2020-03-02 23:53:40 UTC (rev 257743)
@@ -1,4 +1,4 @@
-//@ skip if $model == "Apple Watch Series 3" or $model == "Apple Watch Series 4" or (not $jitTests and $architecture =~ /arm|mips/ and $hostOS == "linux") # added by mark-jsc-stress-test.py
+//@ skip if $model == "Apple Watch Series 3" or $model == "Apple Watch Series 4" or (not $jitTests and $architecture =~ /(^arm$)|mips/ and $hostOS == "linux") # added by mark-jsc-stress-test.py
let glob = 0
function doTest(number) {
Modified: trunk/JSTests/microbenchmarks/bit-test-nonconstant.js (257742 => 257743)
--- trunk/JSTests/microbenchmarks/bit-test-nonconstant.js 2020-03-02 23:42:22 UTC (rev 257742)
+++ trunk/JSTests/microbenchmarks/bit-test-nonconstant.js 2020-03-02 23:53:40 UTC (rev 257743)
@@ -1,4 +1,4 @@
-//@ skip if $model == "Apple Watch Series 3" or (not $jitTests and $architecture =~ /arm|mips/ and $hostOS == "linux") # added by mark-jsc-stress-test.py
+//@ skip if $model == "Apple Watch Series 3" or (not $jitTests and $architecture =~ /(^arm$)|mips/ and $hostOS == "linux") # added by mark-jsc-stress-test.py
let glob = 0
function doTest(number, bit) {
Modified: trunk/JSTests/microbenchmarks/memcpy-typed-loop-large.js (257742 => 257743)
--- trunk/JSTests/microbenchmarks/memcpy-typed-loop-large.js 2020-03-02 23:42:22 UTC (rev 257742)
+++ trunk/JSTests/microbenchmarks/memcpy-typed-loop-large.js 2020-03-02 23:53:40 UTC (rev 257743)
@@ -1,4 +1,4 @@
-//@ skip if $model == "Apple Watch Series 3" or $model == "Apple Watch Series 4" or (not $jitTests and $architecture =~ /arm|mips/ and $hostOS == "linux") # added by mark-jsc-stress-test.py
+//@ skip if $model == "Apple Watch Series 3" or $model == "Apple Watch Series 4" or (not $jitTests and $architecture =~ /(^arm$)|mips/ and $hostOS == "linux") # added by mark-jsc-stress-test.py
function doTest(arr1, arr2) {
if (arr1.length != arr2.length)
return []
Modified: trunk/JSTests/microbenchmarks/memcpy-typed-loop-small.js (257742 => 257743)
--- trunk/JSTests/microbenchmarks/memcpy-typed-loop-small.js 2020-03-02 23:42:22 UTC (rev 257742)
+++ trunk/JSTests/microbenchmarks/memcpy-typed-loop-small.js 2020-03-02 23:53:40 UTC (rev 257743)
@@ -1,4 +1,4 @@
-//@ skip if $model == "Apple Watch Series 3" or $model == "Apple Watch Series 4" or (not $jitTests and $architecture =~ /arm|mips/ and $hostOS == "linux") # added by mark-jsc-stress-test.py
+//@ skip if $model == "Apple Watch Series 3" or $model == "Apple Watch Series 4" or (not $jitTests and $architecture =~ /(^arm$)|mips/ and $hostOS == "linux") # added by mark-jsc-stress-test.py
function doTest(arr1, arr2) {
if (arr1.length != arr2.length)
return []
Modified: trunk/JSTests/microbenchmarks/mul-immediate-sub.js (257742 => 257743)
--- trunk/JSTests/microbenchmarks/mul-immediate-sub.js 2020-03-02 23:42:22 UTC (rev 257742)
+++ trunk/JSTests/microbenchmarks/mul-immediate-sub.js 2020-03-02 23:53:40 UTC (rev 257743)
@@ -1,4 +1,4 @@
-//@ skip if $model == "Apple Watch Series 3" or $model == "Apple Watch Series 4" or (not $jitTests and $architecture =~ /arm|mips/ and $hostOS == "linux") # added by mark-jsc-stress-test.py
+//@ skip if $model == "Apple Watch Series 3" or $model == "Apple Watch Series 4" or (not $jitTests and $architecture =~ /(^arm$)|mips/ and $hostOS == "linux") # added by mark-jsc-stress-test.py
function doTest(max) {
let sum = 0
for (let i=0; i<max; ++i) {
Modified: trunk/JSTests/stress/dont-range-based-iterate-vector-that-is-mutated.js (257742 => 257743)
--- trunk/JSTests/stress/dont-range-based-iterate-vector-that-is-mutated.js 2020-03-02 23:42:22 UTC (rev 257742)
+++ trunk/JSTests/stress/dont-range-based-iterate-vector-that-is-mutated.js 2020-03-02 23:53:40 UTC (rev 257743)
@@ -1,4 +1,4 @@
-//@ skip if not $jitTests and $architecture =~ /arm|mips/ and $hostOS == "linux"
+//@ skip if not $jitTests and $architecture =~ /(^arm$)|mips/ and $hostOS == "linux"
// Should not crash when run with ASAN.
function foo(arr1, arr2) {
Modified: trunk/JSTests/stress/dont-reserve-huge-capacity-lexer.js (257742 => 257743)
--- trunk/JSTests/stress/dont-reserve-huge-capacity-lexer.js 2020-03-02 23:42:22 UTC (rev 257742)
+++ trunk/JSTests/stress/dont-reserve-huge-capacity-lexer.js 2020-03-02 23:53:40 UTC (rev 257743)
@@ -1,4 +1,4 @@
-//@ if ($architecture != "x86-64") or $memoryLimited then skip else runDefault end
+//@ if $memoryLimited then skip else runDefault end
var fe="f";
try
Modified: trunk/JSTests/stress/new-largeish-contiguous-array-with-size.js (257742 => 257743)
--- trunk/JSTests/stress/new-largeish-contiguous-array-with-size.js 2020-03-02 23:42:22 UTC (rev 257742)
+++ trunk/JSTests/stress/new-largeish-contiguous-array-with-size.js 2020-03-02 23:53:40 UTC (rev 257743)
@@ -1,6 +1,6 @@
// We only need one run of this with any GC or JIT strategy. This test is not particularly fast.
// Unfortunately, it needs to run for a while to test the thing it's testing.
-//@ if $architecture =~ /arm|mips/ then skip else runWithRAMSize(10000000) end
+//@ if $architecture =~ /(^arm$)|mips/ then skip else runWithRAMSize(10000000) end
//@ slow!
function foo(x) {
Modified: trunk/JSTests/stress/sampling-profiler-richards.js (257742 => 257743)
--- trunk/JSTests/stress/sampling-profiler-richards.js 2020-03-02 23:42:22 UTC (rev 257742)
+++ trunk/JSTests/stress/sampling-profiler-richards.js 2020-03-02 23:53:40 UTC (rev 257743)
@@ -1,5 +1,5 @@
//@ skip if $architecture == "mips" and $hostOS == "linux"
-//@ skip if not $jitTests and $architecture =~ /arm|mips/ and $hostOS == "linux"
+//@ skip if not $jitTests and $architecture =~ /(^arm$)|mips/ and $hostOS == "linux"
//@ skip if $architecture == "x86"
//@ runDefault("--collectContinuously=1", "--useSamplingProfiler=1", "--collectSamplingProfilerDataForJSCShell=1")
Modified: trunk/JSTests/typeProfiler/deltablue-for-of.js (257742 => 257743)
--- trunk/JSTests/typeProfiler/deltablue-for-of.js 2020-03-02 23:42:22 UTC (rev 257742)
+++ trunk/JSTests/typeProfiler/deltablue-for-of.js 2020-03-02 23:53:40 UTC (rev 257743)
@@ -1,4 +1,4 @@
-//@ if $buildType == "debug" or $architecture =~ /arm|mips/ then skip else runTypeProfiler end
+//@ if $buildType == "debug" or $architecture =~ /(^arm$)|mips/ then skip else runTypeProfiler end
// Copyright 2008 the V8 project authors. All rights reserved.
// Copyright 1996 John Maloney and Mario Wolczko.
Modified: trunk/JSTests/typeProfiler/getter-richards.js (257742 => 257743)
--- trunk/JSTests/typeProfiler/getter-richards.js 2020-03-02 23:42:22 UTC (rev 257742)
+++ trunk/JSTests/typeProfiler/getter-richards.js 2020-03-02 23:53:40 UTC (rev 257743)
@@ -1,4 +1,4 @@
-//@ if $buildType == "debug" or not $jitTests or $architecture =~ /arm|mips/ then skip else runTypeProfiler end
+//@ if $buildType == "debug" or not $jitTests or $architecture =~ /(^arm$)|mips/ then skip else runTypeProfiler end
// Copyright 2006-2008 the V8 project authors. All rights reserved.
// Copyright 2014 Apple Inc.
Modified: trunk/JSTests/wasm/regress/llint-callee-saves-with-fast-memory.js (257742 => 257743)
--- trunk/JSTests/wasm/regress/llint-callee-saves-with-fast-memory.js 2020-03-02 23:42:22 UTC (rev 257742)
+++ trunk/JSTests/wasm/regress/llint-callee-saves-with-fast-memory.js 2020-03-02 23:53:40 UTC (rev 257743)
@@ -1,6 +1,4 @@
-//@ skip if $architecture != "x86-64"
//@ requireOptions("--useWebAssemblyFastMemory=true")
-// FIXME: Stop skipping when we enable fast memory for iOS. https://bugs.webkit.org/show_bug.cgi?id=170774
import { instantiate } from '../wabt-wrapper.js';
Modified: trunk/LayoutTests/ChangeLog (257742 => 257743)
--- trunk/LayoutTests/ChangeLog 2020-03-02 23:42:22 UTC (rev 257742)
+++ trunk/LayoutTests/ChangeLog 2020-03-02 23:53:40 UTC (rev 257743)
@@ -1,3 +1,14 @@
+2020-03-02 Saam Barati <[email protected]>
+
+ Don't skip tests unnecessarily on arm64
+ https://bugs.webkit.org/show_bug.cgi?id=208470
+ <rdar://problem/59968869>
+
+ Reviewed by Tadeu Zagallo.
+
+ * js/script-tests/array-from.js:
+ * js/script-tests/function-apply-many-args.js:
+
2020-03-02 Jason Lawrence <[email protected]>
[ Mac wk2 ] is css3/shapes/shape-outside/shape-image/shape-image-025.html flaky failing.
Modified: trunk/LayoutTests/js/script-tests/array-from.js (257742 => 257743)
--- trunk/LayoutTests/js/script-tests/array-from.js 2020-03-02 23:42:22 UTC (rev 257742)
+++ trunk/LayoutTests/js/script-tests/array-from.js 2020-03-02 23:53:40 UTC (rev 257743)
@@ -1,6 +1,3 @@
-// [ARM] jsc-layout-tests.yaml/js/script-tests/array-from.js fails on Aarch64
-// https://bugs.webkit.org/show_bug.cgi?id=142272
-//@ skip if $architecture == "arm64"
description("Tests for Array.from");
function section(title) {
Modified: trunk/LayoutTests/js/script-tests/function-apply-many-args.js (257742 => 257743)
--- trunk/LayoutTests/js/script-tests/function-apply-many-args.js 2020-03-02 23:42:22 UTC (rev 257742)
+++ trunk/LayoutTests/js/script-tests/function-apply-many-args.js 2020-03-02 23:53:40 UTC (rev 257743)
@@ -1,4 +1,4 @@
-//@ skip if $architecture !~ /x86/i and $hostOS == "darwin"
+//@ skip if $memoryLimited and $hostOS == "darwin"
description("Tests that we throw an error when passing a number of arguments beyond a certain threshold.");
Modified: trunk/Tools/ChangeLog (257742 => 257743)
--- trunk/Tools/ChangeLog 2020-03-02 23:42:22 UTC (rev 257742)
+++ trunk/Tools/ChangeLog 2020-03-02 23:53:40 UTC (rev 257743)
@@ -1,3 +1,13 @@
+2020-03-02 Saam Barati <[email protected]>
+
+ Don't skip tests unnecessarily on arm64
+ https://bugs.webkit.org/show_bug.cgi?id=208470
+ <rdar://problem/59968869>
+
+ Reviewed by Tadeu Zagallo.
+
+ * Scripts/run-jsc-stress-tests:
+
2020-03-02 Andres Gonzalez <[email protected]>
Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (257742 => 257743)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2020-03-02 23:42:22 UTC (rev 257742)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2020-03-02 23:53:40 UTC (rev 257743)
@@ -698,12 +698,6 @@
end
def runBigIntEnabled(*optionalTestSpecificOptions)
- # FIXME: <rdar://problem/40331121>
- if $remote or ($architecture !~ /x86/i and $hostOS == "darwin")
- skip
- return
- end
-
run("big-int-enabled", "--useBigInt=true" , *(FTL_OPTIONS + optionalTestSpecificOptions))
end
@@ -930,7 +924,7 @@
end
def runProfiler
- if $remote or ($architecture !~ /x86/i and $hostOS == "darwin") or ($hostOS == "windows") or ($hostOS == "playstation")
+ if $remote or $memoryLimited or ($hostOS == "windows") or ($hostOS == "playstation")
skip
return
end
