Title: [257921] trunk/Source/WebKit
Revision
257921
Author
[email protected]
Date
2020-03-05 09:41:30 -0800 (Thu, 05 Mar 2020)

Log Message

Assertion failed: shouldBeActive() in BackgroundProcessResponsivenessTimer::responsivenessCheckTimerFired()
https://bugs.webkit.org/show_bug.cgi?id=208596

Reviewed by Chris Dumez.

Update state of BackgroundProcessResponsivenessTimer when ServiceWorker is enabled or disabled in web process.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::disableServiceWorkers):
(WebKit::WebProcessProxy::enableServiceWorkers):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (257920 => 257921)


--- trunk/Source/WebKit/ChangeLog	2020-03-05 17:18:00 UTC (rev 257920)
+++ trunk/Source/WebKit/ChangeLog	2020-03-05 17:41:30 UTC (rev 257921)
@@ -1,3 +1,16 @@
+2020-03-05  Sihui Liu  <[email protected]>
+
+        Assertion failed: shouldBeActive() in BackgroundProcessResponsivenessTimer::responsivenessCheckTimerFired()
+        https://bugs.webkit.org/show_bug.cgi?id=208596
+
+        Reviewed by Chris Dumez.
+
+        Update state of BackgroundProcessResponsivenessTimer when ServiceWorker is enabled or disabled in web process.
+
+        * UIProcess/WebProcessProxy.cpp:
+        (WebKit::WebProcessProxy::disableServiceWorkers):
+        (WebKit::WebProcessProxy::enableServiceWorkers):
+
 2020-03-05  youenn fablet  <[email protected]>
 
         Add logging support for capture sources in GPUProcess

Modified: trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp (257920 => 257921)


--- trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp	2020-03-05 17:18:00 UTC (rev 257920)
+++ trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp	2020-03-05 17:41:30 UTC (rev 257921)
@@ -1711,6 +1711,7 @@
         return;
 
     m_serviceWorkerInformation = { };
+    updateBackgroundResponsivenessTimer();
 
 #if ENABLE(SERVICE_WORKER)
     processPool().removeFromServiceWorkerProcesses(*this);
@@ -1754,6 +1755,7 @@
         nullptr,
         { }
     };
+    updateBackgroundResponsivenessTimer();
 #if ENABLE(SERVICE_WORKER)
     updateServiceWorkerProcessAssertion();
 #endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to