Title: [257990] releases/WebKitGTK/webkit-2.28/Source/_javascript_Core
Revision
257990
Author
[email protected]
Date
2020-03-06 06:28:44 -0800 (Fri, 06 Mar 2020)

Log Message

Merge r257908 - [JSCOnly] 32-bits warning on memset of JSValue
https://bugs.webkit.org/show_bug.cgi?id=204411

Patch by Paulo Matos <[email protected]> on 2020-03-05
Reviewed by Mark Lam.

Fixes warning on 32bit builds. This is required because GCC knows
it is not safe to use memset on non-POD types and warns against its use.

* heap/GCMemoryOperations.h:
(JSC::gcSafeZeroMemory):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.28/Source/_javascript_Core/ChangeLog (257989 => 257990)


--- releases/WebKitGTK/webkit-2.28/Source/_javascript_Core/ChangeLog	2020-03-06 14:28:40 UTC (rev 257989)
+++ releases/WebKitGTK/webkit-2.28/Source/_javascript_Core/ChangeLog	2020-03-06 14:28:44 UTC (rev 257990)
@@ -1,3 +1,16 @@
+2020-03-05  Paulo Matos  <[email protected]>
+
+        [JSCOnly] 32-bits warning on memset of JSValue
+        https://bugs.webkit.org/show_bug.cgi?id=204411
+
+        Reviewed by Mark Lam.
+
+        Fixes warning on 32bit builds. This is required because GCC knows
+        it is not safe to use memset on non-POD types and warns against its use.
+
+        * heap/GCMemoryOperations.h:
+        (JSC::gcSafeZeroMemory):
+
 2020-03-02  Paulo Matos  <[email protected]>
 
         Fix JSC 32bit alignment increase gcc warning

Modified: releases/WebKitGTK/webkit-2.28/Source/_javascript_Core/heap/GCMemoryOperations.h (257989 => 257990)


--- releases/WebKitGTK/webkit-2.28/Source/_javascript_Core/heap/GCMemoryOperations.h	2020-03-06 14:28:40 UTC (rev 257989)
+++ releases/WebKitGTK/webkit-2.28/Source/_javascript_Core/heap/GCMemoryOperations.h	2020-03-06 14:28:44 UTC (rev 257990)
@@ -306,7 +306,7 @@
         bitwise_cast<volatile uint64_t*>(dst)[i] = 0;
 #endif // COMPILER(GCC_COMPATIBLE)
 #else
-    memset(dst, 0, bytes);
+    memset(reinterpret_cast<char*>(dst), 0, bytes);
 #endif // USE(JSVALUE64)
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to