Title: [258168] trunk/Source/WebKit
Revision
258168
Author
[email protected]
Date
2020-03-09 15:35:04 -0700 (Mon, 09 Mar 2020)

Log Message

[iOS] Only map UTI from tags in Safari
https://bugs.webkit.org/show_bug.cgi?id=208829
<rdar://problem/60234672>

Reviewed by Tim Horton.

Since this mapping caused regressions in other apps, only enable it for Safari as a temporary workaround.

* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (258167 => 258168)


--- trunk/Source/WebKit/ChangeLog	2020-03-09 22:27:41 UTC (rev 258167)
+++ trunk/Source/WebKit/ChangeLog	2020-03-09 22:35:04 UTC (rev 258168)
@@ -1,5 +1,20 @@
 2020-03-09  Per Arne Vollan  <[email protected]>
 
+        [iOS] Only map UTI from tags in Safari
+        https://bugs.webkit.org/show_bug.cgi?id=208829
+        <rdar://problem/60234672>
+
+        Reviewed by Tim Horton.
+
+        Since this mapping caused regressions in other apps, only enable it for Safari as a temporary workaround.
+
+        * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+        (WebKit::WebProcessPool::platformInitializeWebProcess):
+        * WebProcess/cocoa/WebProcessCocoa.mm:
+        (WebKit::WebProcess::platformInitializeWebProcess):
+
+2020-03-09  Per Arne Vollan  <[email protected]>
+
         Unreviewed build fix.
 
         * Shared/WebProcessCreationParameters.cpp:

Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (258167 => 258168)


--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2020-03-09 22:27:41 UTC (rev 258167)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2020-03-09 22:35:04 UTC (rev 258168)
@@ -432,7 +432,8 @@
     parameters.focusRingColor = RenderTheme::singleton().focusRingColor(OptionSet<StyleColor::Options>());
     parameters.localizedDeviceModel = localizedDeviceModel();
 #if USE(UTTYPE_SWIZZLER)
-    parameters.vectorOfUTTypeItem = createVectorOfUTTypeItem();
+    if (WebCore::IOSApplication::isMobileSafari())
+        parameters.vectorOfUTTypeItem = createVectorOfUTTypeItem();
 #endif
 #endif
     

Modified: trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm (258167 => 258168)


--- trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	2020-03-09 22:27:41 UTC (rev 258167)
+++ trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	2020-03-09 22:35:04 UTC (rev 258168)
@@ -299,8 +299,10 @@
 #endif
         
 #if USE(UTTYPE_SWIZZLER)
-    swizzleUTTypeRecord();
-    setVectorOfUTTypeItem(WTFMove(parameters.vectorOfUTTypeItem));
+    if (!parameters.vectorOfUTTypeItem.isEmpty()) {
+        swizzleUTTypeRecord();
+        setVectorOfUTTypeItem(WTFMove(parameters.vectorOfUTTypeItem));
+    }
 #endif
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to