Title: [258172] trunk/Source/WebCore
- Revision
- 258172
- Author
- [email protected]
- Date
- 2020-03-09 16:36:22 -0700 (Mon, 09 Mar 2020)
Log Message
REGRESSION (257846) Crash on maps.google.com under Element::isVisibleWithoutResolvingFullStyle
https://bugs.webkit.org/show_bug.cgi?id=208841
<rdar://problem/60238539>
Reviewed by Simon Fraser.
Resolve the computed style for the composed ancestors when not available.
* dom/Element.cpp:
(WebCore::Element::isVisibleWithoutResolvingFullStyle const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (258171 => 258172)
--- trunk/Source/WebCore/ChangeLog 2020-03-09 23:33:08 UTC (rev 258171)
+++ trunk/Source/WebCore/ChangeLog 2020-03-09 23:36:22 UTC (rev 258172)
@@ -1,3 +1,16 @@
+2020-03-09 Zalan Bujtas <[email protected]>
+
+ REGRESSION (257846) Crash on maps.google.com under Element::isVisibleWithoutResolvingFullStyle
+ https://bugs.webkit.org/show_bug.cgi?id=208841
+ <rdar://problem/60238539>
+
+ Reviewed by Simon Fraser.
+
+ Resolve the computed style for the composed ancestors when not available.
+
+ * dom/Element.cpp:
+ (WebCore::Element::isVisibleWithoutResolvingFullStyle const):
+
2020-03-09 Andres Gonzalez <[email protected]>
Remove required setting for libAccessibility.
Modified: trunk/Source/WebCore/dom/Element.cpp (258171 => 258172)
--- trunk/Source/WebCore/dom/Element.cpp 2020-03-09 23:33:08 UTC (rev 258171)
+++ trunk/Source/WebCore/dom/Element.cpp 2020-03-09 23:36:22 UTC (rev 258172)
@@ -3332,7 +3332,10 @@
return false;
for (auto& element : composedTreeAncestors(const_cast<Element&>(*this))) {
- if (element.existingComputedStyle()->display() == DisplayType::None)
+ auto* style = element.existingComputedStyle();
+ if (!style)
+ style = element.resolveComputedStyle(ResolveComputedStyleMode::RenderedOnly);
+ if (!style || style->display() == DisplayType::None)
return false;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
