Title: [258176] branches/safari-610.1.7-branch/Source/WebCore
- Revision
- 258176
- Author
- [email protected]
- Date
- 2020-03-09 16:49:27 -0700 (Mon, 09 Mar 2020)
Log Message
Cherry-pick r258172. rdar://problem/60249737
REGRESSION (257846) Crash on maps.google.com under Element::isVisibleWithoutResolvingFullStyle
https://bugs.webkit.org/show_bug.cgi?id=208841
<rdar://problem/60238539>
Reviewed by Simon Fraser.
Resolve the computed style for the composed ancestors when not available.
* dom/Element.cpp:
(WebCore::Element::isVisibleWithoutResolvingFullStyle const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258172 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-610.1.7-branch/Source/WebCore/ChangeLog (258175 => 258176)
--- branches/safari-610.1.7-branch/Source/WebCore/ChangeLog 2020-03-09 23:48:27 UTC (rev 258175)
+++ branches/safari-610.1.7-branch/Source/WebCore/ChangeLog 2020-03-09 23:49:27 UTC (rev 258176)
@@ -1,5 +1,36 @@
2020-03-09 Russell Epstein <[email protected]>
+ Cherry-pick r258172. rdar://problem/60249737
+
+ REGRESSION (257846) Crash on maps.google.com under Element::isVisibleWithoutResolvingFullStyle
+ https://bugs.webkit.org/show_bug.cgi?id=208841
+ <rdar://problem/60238539>
+
+ Reviewed by Simon Fraser.
+
+ Resolve the computed style for the composed ancestors when not available.
+
+ * dom/Element.cpp:
+ (WebCore::Element::isVisibleWithoutResolvingFullStyle const):
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258172 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2020-03-09 Zalan Bujtas <[email protected]>
+
+ REGRESSION (257846) Crash on maps.google.com under Element::isVisibleWithoutResolvingFullStyle
+ https://bugs.webkit.org/show_bug.cgi?id=208841
+ <rdar://problem/60238539>
+
+ Reviewed by Simon Fraser.
+
+ Resolve the computed style for the composed ancestors when not available.
+
+ * dom/Element.cpp:
+ (WebCore::Element::isVisibleWithoutResolvingFullStyle const):
+
+2020-03-09 Russell Epstein <[email protected]>
+
Cherry-pick r258171. rdar://problem/60249680
Remove required setting for libAccessibility.
Modified: branches/safari-610.1.7-branch/Source/WebCore/dom/Element.cpp (258175 => 258176)
--- branches/safari-610.1.7-branch/Source/WebCore/dom/Element.cpp 2020-03-09 23:48:27 UTC (rev 258175)
+++ branches/safari-610.1.7-branch/Source/WebCore/dom/Element.cpp 2020-03-09 23:49:27 UTC (rev 258176)
@@ -3347,7 +3347,10 @@
return false;
for (auto& element : composedTreeAncestors(const_cast<Element&>(*this))) {
- if (element.existingComputedStyle()->display() == DisplayType::None)
+ auto* style = element.existingComputedStyle();
+ if (!style)
+ style = element.resolveComputedStyle(ResolveComputedStyleMode::RenderedOnly);
+ if (!style || style->display() == DisplayType::None)
return false;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
