Title: [258178] trunk/Tools
- Revision
- 258178
- Author
- [email protected]
- Date
- 2020-03-09 16:59:40 -0700 (Mon, 09 Mar 2020)
Log Message
WebKitTestRunner bundleID should not be cleared before every test
https://bugs.webkit.org/show_bug.cgi?id=208823
<rdar://problem/60204539>
Reviewed by Per Arne Vollan.
This is causing test failures for layout tests which rely on the Info.plist
bundle identifier (not the one set via the override method).
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::ensureViewSupportsOptionsForTest):
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (258177 => 258178)
--- trunk/Tools/ChangeLog 2020-03-09 23:51:43 UTC (rev 258177)
+++ trunk/Tools/ChangeLog 2020-03-09 23:59:40 UTC (rev 258178)
@@ -1,3 +1,19 @@
+2020-03-09 Kate Cheney <[email protected]>
+
+ WebKitTestRunner bundleID should not be cleared before every test
+ https://bugs.webkit.org/show_bug.cgi?id=208823
+ <rdar://problem/60204539>
+
+ Reviewed by Per Arne Vollan.
+
+ This is causing test failures for layout tests which rely on the Info.plist
+ bundle identifier (not the one set via the override method).
+
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::createWebViewWithOptions):
+ (WTR::TestController::ensureViewSupportsOptionsForTest):
+ * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
+
2020-03-09 Per Arne Vollan <[email protected]>
[macOS] Notification observer is not removed
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (258177 => 258178)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2020-03-09 23:51:43 UTC (rev 258177)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2020-03-09 23:59:40 UTC (rev 258178)
@@ -640,6 +640,7 @@
exit(1);
}
if (!options.applicationBundleIdentifier.isEmpty()) {
+ clearApplicationBundleIdentifierTestingOverride();
setApplicationBundleIdentifier(options.applicationBundleIdentifier);
m_hasSetApplicationBundleIdentifier = true;
}
@@ -812,9 +813,6 @@
m_createdOtherPage = false;
}
-#if PLATFORM(COCOA)
- clearApplicationBundleIdentifierTestingOverride();
-#endif
createWebViewWithOptions(options);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
