Title: [258198] trunk/Tools
- Revision
- 258198
- Author
- [email protected]
- Date
- 2020-03-10 05:27:17 -0700 (Tue, 10 Mar 2020)
Log Message
Generate commit-queue status bubble from new EWS
https://bugs.webkit.org/show_bug.cgi?id=208811
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble._build_bubbles_for_patch):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py (258197 => 258198)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2020-03-10 12:08:53 UTC (rev 258197)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2020-03-10 12:27:17 UTC (rev 258198)
@@ -295,17 +295,25 @@
show_retry = False
bubbles = []
- if not (patch and patch.sent_to_buildbot):
+ if not patch:
return (None, show_submit_to_ews, failed_to_apply, show_retry)
- for queue in StatusBubble.ALL_QUEUES:
- bubble = self._build_bubble(patch, queue, hide_icons)
- if bubble:
- show_submit_to_ews = False
- bubbles.append(bubble)
- if bubble['state'] in ('fail', 'error'):
- show_retry = True
+ if patch.sent_to_buildbot:
+ for queue in StatusBubble.ALL_QUEUES:
+ bubble = self._build_bubble(patch, queue, hide_icons)
+ if bubble:
+ show_submit_to_ews = False
+ bubbles.append(bubble)
+ if bubble['state'] in ('fail', 'error'):
+ show_retry = True
+ if patch.sent_to_commit_queue:
+ if not patch.sent_to_buildbot:
+ hide_icons = True
+ cq_bubble = self._build_bubble(patch, 'commit', hide_icons)
+ if cq_bubble:
+ bubbles.insert(0, cq_bubble)
+
return (bubbles, show_submit_to_ews, failed_to_apply, show_retry)
@xframe_options_exempt
Modified: trunk/Tools/ChangeLog (258197 => 258198)
--- trunk/Tools/ChangeLog 2020-03-10 12:08:53 UTC (rev 258197)
+++ trunk/Tools/ChangeLog 2020-03-10 12:27:17 UTC (rev 258198)
@@ -1,3 +1,13 @@
+2020-03-10 Aakash Jain <[email protected]>
+
+ Generate commit-queue status bubble from new EWS
+ https://bugs.webkit.org/show_bug.cgi?id=208811
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+ (StatusBubble._build_bubbles_for_patch):
+
2020-03-09 Don Olmstead <[email protected]>
Remove obsolete feature flags
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
