- Revision
- 258338
- Author
- [email protected]
- Date
- 2020-03-12 10:40:35 -0700 (Thu, 12 Mar 2020)
Log Message
Drop unused LogGlobalDiagnosticMessageWithValue IPC message
https://bugs.webkit.org/show_bug.cgi?id=208974
<rdar://problem/59682189>
Reviewed by Chris Dumez.
I added these messages for ITP, but we later switched to tracking network sessions
individually and no longer need this "global" message.
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::logGlobalDiagnosticMessageWithValue): Deleted.
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/Network/NetworkProcessProxy.messages.in:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (258337 => 258338)
--- trunk/Source/WebKit/ChangeLog 2020-03-12 17:10:45 UTC (rev 258337)
+++ trunk/Source/WebKit/ChangeLog 2020-03-12 17:40:35 UTC (rev 258338)
@@ -1,3 +1,19 @@
+2020-03-12 Brent Fulgham <[email protected]>
+
+ Drop unused LogGlobalDiagnosticMessageWithValue IPC message
+ https://bugs.webkit.org/show_bug.cgi?id=208974
+ <rdar://problem/59682189>
+
+ Reviewed by Chris Dumez.
+
+ I added these messages for ITP, but we later switched to tracking network sessions
+ individually and no longer need this "global" message.
+
+ * UIProcess/Network/NetworkProcessProxy.cpp:
+ (WebKit::NetworkProcessProxy::logGlobalDiagnosticMessageWithValue): Deleted.
+ * UIProcess/Network/NetworkProcessProxy.h:
+ * UIProcess/Network/NetworkProcessProxy.messages.in:
+
2020-03-12 Chris Dumez <[email protected]>
Networking process should kill the WebContent process if an invalid IPC message is received from it
Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp (258337 => 258338)
--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2020-03-12 17:10:45 UTC (rev 258337)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2020-03-12 17:40:35 UTC (rev 258338)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2012-2019 Apple Inc. All rights reserved.
+ * Copyright (C) 2012-2020 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -475,12 +475,6 @@
page->logDiagnosticMessageWithValue(message, description, value, significantFigures, shouldSample);
}
-void NetworkProcessProxy::logGlobalDiagnosticMessageWithValue(const String& message, const String& description, double value, unsigned significantFigures, WebCore::ShouldSample shouldSample)
-{
- if (auto* page = WebPageProxy::nonEphemeralWebPageProxy())
- page->logDiagnosticMessageWithValue(message, description, value, significantFigures, shouldSample);
-}
-
void NetworkProcessProxy::resourceLoadDidSendRequest(WebPageProxyIdentifier pageID, ResourceLoadInfo&& loadInfo, WebCore::ResourceRequest&& request, Optional<IPC::FormDataReference>&& httpBody)
{
auto* page = WebProcessProxy::webPage(pageID);
Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h (258337 => 258338)
--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h 2020-03-12 17:10:45 UTC (rev 258337)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h 2020-03-12 17:40:35 UTC (rev 258338)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2012-2019 Apple Inc. All rights reserved.
+ * Copyright (C) 2012-2020 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -256,7 +256,6 @@
void logDiagnosticMessage(WebPageProxyIdentifier, const String& message, const String& description, WebCore::ShouldSample);
void logDiagnosticMessageWithResult(WebPageProxyIdentifier, const String& message, const String& description, uint32_t result, WebCore::ShouldSample);
void logDiagnosticMessageWithValue(WebPageProxyIdentifier, const String& message, const String& description, double value, unsigned significantFigures, WebCore::ShouldSample);
- void logGlobalDiagnosticMessageWithValue(const String& message, const String& description, double value, unsigned significantFigures, WebCore::ShouldSample);
#if ENABLE(RESOURCE_LOAD_STATISTICS)
void logTestingEvent(PAL::SessionID, const String& event);
void notifyResourceLoadStatisticsProcessed();
Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in (258337 => 258338)
--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in 2020-03-12 17:10:45 UTC (rev 258337)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in 2020-03-12 17:40:35 UTC (rev 258338)
@@ -1,4 +1,4 @@
-# Copyright (C) 2012-2019 Apple Inc. All rights reserved.
+# Copyright (C) 2012-2020 Apple Inc. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
@@ -39,7 +39,6 @@
LogDiagnosticMessage(WebKit::WebPageProxyIdentifier pageID, String message, String description, enum:bool WebCore::ShouldSample shouldSample)
LogDiagnosticMessageWithResult(WebKit::WebPageProxyIdentifier pageID, String message, String description, uint32_t result, enum:bool WebCore::ShouldSample shouldSample)
LogDiagnosticMessageWithValue(WebKit::WebPageProxyIdentifier pageID, String message, String description, double value, unsigned significantFigures, enum:bool WebCore::ShouldSample shouldSample)
- LogGlobalDiagnosticMessageWithValue(String message, String description, double value, unsigned significantFigures, enum:bool WebCore::ShouldSample shouldSample)
#if ENABLE(RESOURCE_LOAD_STATISTICS)
LogTestingEvent(PAL::SessionID sessionID, String event)
