Title: [258367] trunk/LayoutTests
- Revision
- 258367
- Author
- [email protected]
- Date
- 2020-03-12 16:10:43 -0700 (Thu, 12 Mar 2020)
Log Message
[ macOS iOS ] fast/dom/connected-subframe-counter-overflow.html is flaky timing out
https://bugs.webkit.org/show_bug.cgi?id=207152
<rdar://problem/59127411>
Unreviewed, mark the test as slow instead of flaky timeout. The test is slow to run because
it checks for some overflow and adds a lot of iframes to the document.
This patch also speed up the test a bit by marking the iframes as display:none *before* inserting
them into the document. We also now add the frames in a timer to yield and make sure that the
main thread stays responsive while running this test.
* TestExpectations:
* platform/ios/TestExpectations:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (258366 => 258367)
--- trunk/LayoutTests/ChangeLog 2020-03-12 23:06:28 UTC (rev 258366)
+++ trunk/LayoutTests/ChangeLog 2020-03-12 23:10:43 UTC (rev 258367)
@@ -1,5 +1,22 @@
2020-03-12 Chris Dumez <[email protected]>
+ [ macOS iOS ] fast/dom/connected-subframe-counter-overflow.html is flaky timing out
+ https://bugs.webkit.org/show_bug.cgi?id=207152
+ <rdar://problem/59127411>
+
+ Unreviewed, mark the test as slow instead of flaky timeout. The test is slow to run because
+ it checks for some overflow and adds a lot of iframes to the document.
+
+ This patch also speed up the test a bit by marking the iframes as display:none *before* inserting
+ them into the document. We also now add the frames in a timer to yield and make sure that the
+ main thread stays responsive while running this test.
+
+ * TestExpectations:
+ * platform/ios/TestExpectations:
+ * platform/mac/TestExpectations:
+
+2020-03-12 Chris Dumez <[email protected]>
+
[ Mac wk2 Release ] fast/dom/navigator-detached-no-crash.html flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207151
<rdar://problem/59126935>
Modified: trunk/LayoutTests/TestExpectations (258366 => 258367)
--- trunk/LayoutTests/TestExpectations 2020-03-12 23:06:28 UTC (rev 258366)
+++ trunk/LayoutTests/TestExpectations 2020-03-12 23:10:43 UTC (rev 258367)
@@ -481,6 +481,9 @@
[ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/registration-mime-types.https.html [ Slow ]
[ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/redirected-response.https.html [ Slow ]
+# This test adds a lot of iframes and is slow to run.
+fast/dom/connected-subframe-counter-overflow.html [ Slow ]
+
# Reenable it when having a custom gc exposed in service workers.
[ Debug ] http/wpt/service-workers/fetchEvent.https.html [ Skip ]
Modified: trunk/LayoutTests/fast/dom/connected-subframe-counter-overflow.html (258366 => 258367)
--- trunk/LayoutTests/fast/dom/connected-subframe-counter-overflow.html 2020-03-12 23:06:28 UTC (rev 258366)
+++ trunk/LayoutTests/fast/dom/connected-subframe-counter-overflow.html 2020-03-12 23:10:43 UTC (rev 258367)
@@ -1,23 +1,33 @@
-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<!DOCTYPE html>
<html>
<head>
-<script src=""
+<script src=""
</head>
<body>
<script>
description('The connected subframe counter should not overflow and make `disconnectSubframes` leave active subframes in a detached DOM node.');
+jsTestIsAsync = true;
const FRAME_COUNT = 1024;
-let container = document.body.appendChild(document.createElement('div'));
-for (let i = 0; i < FRAME_COUNT; ++i) {
- let frame = container.appendChild(document.createElement('iframe'));
- frame.style.display = 'none';
+_onload_ = () => {
+ container = document.getElementById("testContainer");
+ for (let i = 0; i < FRAME_COUNT; ++i) {
+ setTimeout(() => {
+ let frame = document.createElement('iframe');
+ frame.style.display = 'none';
+ container.appendChild(frame);
+ }, 0);
+ }
+
+ setTimeout(() => {
+ container.remove();
+
+ shouldBeNull('container.firstChild.contentWindow');
+ finishJSTest();
+ }, 0);
}
-container.remove();
-
-shouldBeNull('container.firstChild.contentWindow');
</script>
-<script src=""
+<div id="testContainer"></div>
</body>
</html>
Modified: trunk/LayoutTests/platform/ios/TestExpectations (258366 => 258367)
--- trunk/LayoutTests/platform/ios/TestExpectations 2020-03-12 23:06:28 UTC (rev 258366)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2020-03-12 23:10:43 UTC (rev 258367)
@@ -3420,8 +3420,6 @@
webkit.org/b/207057 imported/w3c/web-platform-tests/IndexedDB/keypath-special-identifiers.htm [ Pass Failure ]
-webkit.org/b/207152 fast/dom/connected-subframe-counter-overflow.html [ Pass Timeout ]
-
webkit.org/b/207225 imported/w3c/web-platform-tests/service-workers/service-worker/extendable-event-waituntil.https.html [ Pass Failure ]
webkit.org/b/207230 imported/w3c/web-platform-tests/fetch/stale-while-revalidate/fetch.html [ Pass Failure ]
@@ -3507,4 +3505,4 @@
webkit.org/b/204312 imported/w3c/web-platform-tests/svg/import/struct-dom-06-b-manual.svg [ Failure Pass ]
-webkit.org/b/208592 svg/custom/object-sizing-explicit-height.xhtml [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/208592 svg/custom/object-sizing-explicit-height.xhtml [ Pass Failure ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (258366 => 258367)
--- trunk/LayoutTests/platform/mac/TestExpectations 2020-03-12 23:06:28 UTC (rev 258366)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2020-03-12 23:10:43 UTC (rev 258367)
@@ -1951,8 +1951,6 @@
webkit.org/b/207142 requestidlecallback/requestidlecallback-is-called.html [ Pass Failure ]
-webkit.org/b/207152 fast/dom/connected-subframe-counter-overflow.html [ Pass Timeout ]
-
webkit.org/b/207225 imported/w3c/web-platform-tests/service-workers/service-worker/extendable-event-waituntil.https.html [ Pass Failure ]
webkit.org/b/207226 http/tests/misc/image-blocked-src-change.html [ Pass Failure ]
@@ -2038,4 +2036,4 @@
webkit.org/b/208592 svg/custom/object-sizing-explicit-height.xhtml [ Pass Failure ]
-webkit.org/b/208930 accessibility/accessibility-node-memory-management.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/208930 accessibility/accessibility-node-memory-management.html [ Pass Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
