Title: [258373] trunk/LayoutTests
Revision
258373
Author
[email protected]
Date
2020-03-12 16:55:06 -0700 (Thu, 12 Mar 2020)

Log Message

http/tests/paymentrequest/page-cache-completed-payment-response.https.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207385
<rdar://problem/59260167>

Unreviewed, address flakiness by only making sure that the promises get rejected, without checking
which error it is actually rejected with, since this is racy.

* http/tests/paymentrequest/page-cache-completed-payment-response.https.html:
* platform/mac-wk2/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (258372 => 258373)


--- trunk/LayoutTests/ChangeLog	2020-03-12 23:49:31 UTC (rev 258372)
+++ trunk/LayoutTests/ChangeLog	2020-03-12 23:55:06 UTC (rev 258373)
@@ -1,5 +1,17 @@
 2020-03-12  Chris Dumez  <[email protected]>
 
+        http/tests/paymentrequest/page-cache-completed-payment-response.https.html is flaky failing.
+        https://bugs.webkit.org/show_bug.cgi?id=207385
+        <rdar://problem/59260167>
+
+        Unreviewed, address flakiness by only making sure that the promises get rejected, without checking
+        which error it is actually rejected with, since this is racy.
+
+        * http/tests/paymentrequest/page-cache-completed-payment-response.https.html:
+        * platform/mac-wk2/TestExpectations:
+
+2020-03-12  Chris Dumez  <[email protected]>
+
         [ Mac ] fast/history/page-cache-webdatabase-pending-transaction.html is timing out
         https://bugs.webkit.org/show_bug.cgi?id=207010
         <rdar://problem/59035295>

Modified: trunk/LayoutTests/http/tests/paymentrequest/page-cache-completed-payment-response.https.html (258372 => 258373)


--- trunk/LayoutTests/http/tests/paymentrequest/page-cache-completed-payment-response.https.html	2020-03-12 23:49:31 UTC (rev 258372)
+++ trunk/LayoutTests/http/tests/paymentrequest/page-cache-completed-payment-response.https.html	2020-03-12 23:55:06 UTC (rev 258373)
@@ -18,8 +18,8 @@
     testPassed('Page did enter and was restored from the back/forward cache');
 
     debug('Testing that PaymentResponse remains in the Completed state.');
-    await shouldRejectWithErrorName('response.complete()', 'InvalidStateError');
-    await shouldRejectWithErrorName('response.retry()', 'InvalidStateError');
+    await shouldReject('response.complete()');
+    await shouldReject('response.retry()');
 
     finishJSTest();
 }, false);

Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (258372 => 258373)


--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-03-12 23:49:31 UTC (rev 258372)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-03-12 23:55:06 UTC (rev 258373)
@@ -987,8 +987,6 @@
 
 webkit.org/b/207303 loader/stateobjects/pushstate-size-iframe.html [ Pass Crash ]
 
-webkit.org/b/207385 http/tests/paymentrequest/page-cache-completed-payment-response.https.html [ Pass Failure ]
-
 webkit.org/b/207460 webgpu/whlsl/separate-shader-modules/separate-shader-modules-7.html [ Pass ImageOnlyFailure ]
 
 webkit.org/b/207465 [ Debug ] storage/indexeddb/intversion-long-queue.html [ Pass Failure ]
@@ -1089,4 +1087,4 @@
 
 webkit.org/b/209018 [ Catalina ] webrtc/video-autoplay1.html [ Pass Failure ]
 
-webkit.org/b/209024 [ Debug ] webgpu/whlsl/vector-compare.html [ Pass Crash ]
\ No newline at end of file
+webkit.org/b/209024 [ Debug ] webgpu/whlsl/vector-compare.html [ Pass Crash ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to