Title: [258426] branches/safari-609.2.1.2-branch/Source/WebCore
- Revision
- 258426
- Author
- [email protected]
- Date
- 2020-03-13 13:31:28 -0700 (Fri, 13 Mar 2020)
Log Message
Cherry-pick r257640. rdar://problem/60260332
updateCSSTransitionsForElementAndProperty should clone RenderStyles
https://bugs.webkit.org/show_bug.cgi?id=208356
rdar://59869560
Reviewed by Antti Koivisto.
Make ownership of the local variable clear by cloning the RenderStyles
used in updateCSSTransitionsForElementAndProperty rather than referencing
different versions.
* animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::updateCSSTransitionsForElementAndProperty):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@257640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-609.2.1.2-branch/Source/WebCore/ChangeLog (258425 => 258426)
--- branches/safari-609.2.1.2-branch/Source/WebCore/ChangeLog 2020-03-13 20:31:24 UTC (rev 258425)
+++ branches/safari-609.2.1.2-branch/Source/WebCore/ChangeLog 2020-03-13 20:31:28 UTC (rev 258426)
@@ -1,5 +1,39 @@
2020-03-13 Alan Coon <[email protected]>
+ Cherry-pick r257640. rdar://problem/60260332
+
+ updateCSSTransitionsForElementAndProperty should clone RenderStyles
+ https://bugs.webkit.org/show_bug.cgi?id=208356
+ rdar://59869560
+
+ Reviewed by Antti Koivisto.
+
+ Make ownership of the local variable clear by cloning the RenderStyles
+ used in updateCSSTransitionsForElementAndProperty rather than referencing
+ different versions.
+
+ * animation/AnimationTimeline.cpp:
+ (WebCore::AnimationTimeline::updateCSSTransitionsForElementAndProperty):
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@257640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2020-02-28 Dean Jackson <[email protected]>
+
+ updateCSSTransitionsForElementAndProperty should clone RenderStyles
+ https://bugs.webkit.org/show_bug.cgi?id=208356
+ rdar://59869560
+
+ Reviewed by Antti Koivisto.
+
+ Make ownership of the local variable clear by cloning the RenderStyles
+ used in updateCSSTransitionsForElementAndProperty rather than referencing
+ different versions.
+
+ * animation/AnimationTimeline.cpp:
+ (WebCore::AnimationTimeline::updateCSSTransitionsForElementAndProperty):
+
+2020-03-13 Alan Coon <[email protected]>
+
Cherry-pick r257746. rdar://problem/60260331
ScriptController::executeIfJavaScriptURL() uses wrong JSGlobalObject.
Modified: branches/safari-609.2.1.2-branch/Source/WebCore/animation/AnimationTimeline.cpp (258425 => 258426)
--- branches/safari-609.2.1.2-branch/Source/WebCore/animation/AnimationTimeline.cpp 2020-03-13 20:31:24 UTC (rev 258425)
+++ branches/safari-609.2.1.2-branch/Source/WebCore/animation/AnimationTimeline.cpp 2020-03-13 20:31:28 UTC (rev 258426)
@@ -463,7 +463,7 @@
if (auto existingAnimation = cssAnimationForElementAndProperty(element, property))
return downcast<CSSAnimation>(existingAnimation.get())->unanimatedStyle();
- return currentStyle;
+ return RenderStyle::clone(currentStyle);
}();
if (!hasRunningTransition
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
