Title: [258460] trunk/Source
- Revision
- 258460
- Author
- [email protected]
- Date
- 2020-03-13 21:11:44 -0700 (Fri, 13 Mar 2020)
Log Message
configSizeToProtect should be 16KB
https://bugs.webkit.org/show_bug.cgi?id=209068
Reviewed by Keith Miller.
Source/bmalloc:
* bmalloc/Gigacage.h:
Source/_javascript_Core:
* runtime/JSCConfig.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (258459 => 258460)
--- trunk/Source/_javascript_Core/ChangeLog 2020-03-14 03:11:34 UTC (rev 258459)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-03-14 04:11:44 UTC (rev 258460)
@@ -1,3 +1,12 @@
+2020-03-13 Saam Barati <[email protected]>
+
+ configSizeToProtect should be 16KB
+ https://bugs.webkit.org/show_bug.cgi?id=209068
+
+ Reviewed by Keith Miller.
+
+ * runtime/JSCConfig.h:
+
2020-03-13 Yusuke Suzuki <[email protected]>
Unreviewed, fix JSC / test262 tests
Modified: trunk/Source/_javascript_Core/runtime/JSCConfig.cpp (258459 => 258460)
--- trunk/Source/_javascript_Core/runtime/JSCConfig.cpp 2020-03-14 03:11:34 UTC (rev 258459)
+++ trunk/Source/_javascript_Core/runtime/JSCConfig.cpp 2020-03-14 04:11:44 UTC (rev 258460)
@@ -37,7 +37,7 @@
namespace JSC {
-alignas(PageSize) JS_EXPORT_PRIVATE Config g_jscConfig;
+alignas(ConfigSizeToProtect) JS_EXPORT_PRIVATE Config g_jscConfig;
void Config::disableFreezingForTesting()
{
Modified: trunk/Source/_javascript_Core/runtime/JSCConfig.h (258459 => 258460)
--- trunk/Source/_javascript_Core/runtime/JSCConfig.h 2020-03-14 03:11:34 UTC (rev 258459)
+++ trunk/Source/_javascript_Core/runtime/JSCConfig.h 2020-03-14 04:11:44 UTC (rev 258460)
@@ -34,14 +34,8 @@
class FixedVMPoolExecutableAllocator;
class VM;
-#if CPU(ARM64) || PLATFORM(WATCHOS)
-constexpr size_t PageSize = 16 * KB;
-#else
-constexpr size_t PageSize = 4 * KB;
-#endif
+constexpr size_t ConfigSizeToProtect = 16 * KB;
-constexpr size_t ConfigSizeToProtect = PageSize;
-
#if ENABLE(SEPARATED_WX_HEAP)
using JITWriteSeparateHeapsFunction = void (*)(off_t, const void*, size_t);
#endif
@@ -90,9 +84,8 @@
};
};
-extern "C" alignas(PageSize) JS_EXPORT_PRIVATE Config g_jscConfig;
+extern "C" alignas(ConfigSizeToProtect) JS_EXPORT_PRIVATE Config g_jscConfig;
static_assert(sizeof(Config) == ConfigSizeToProtect, "");
-static_assert(roundUpToMultipleOf<PageSize>(ConfigSizeToProtect) == ConfigSizeToProtect, "");
} // namespace JSC
Modified: trunk/Source/bmalloc/ChangeLog (258459 => 258460)
--- trunk/Source/bmalloc/ChangeLog 2020-03-14 03:11:34 UTC (rev 258459)
+++ trunk/Source/bmalloc/ChangeLog 2020-03-14 04:11:44 UTC (rev 258460)
@@ -1,3 +1,12 @@
+2020-03-13 Saam Barati <[email protected]>
+
+ configSizeToProtect should be 16KB
+ https://bugs.webkit.org/show_bug.cgi?id=209068
+
+ Reviewed by Keith Miller.
+
+ * bmalloc/Gigacage.h:
+
2020-03-09 Mike Gorse <[email protected]>
Build failure on ppc64le if __unix is undefined
Modified: trunk/Source/bmalloc/bmalloc/Gigacage.h (258459 => 258460)
--- trunk/Source/bmalloc/bmalloc/Gigacage.h 2020-03-14 03:11:34 UTC (rev 258459)
+++ trunk/Source/bmalloc/bmalloc/Gigacage.h 2020-03-14 04:11:44 UTC (rev 258460)
@@ -66,16 +66,16 @@
#if GIGACAGE_ENABLED
+constexpr size_t configSizeToProtect = 16 * bmalloc::Sizes::kB;
+
#if BOS_EFFECTIVE_ADDRESS_WIDTH < 48
constexpr size_t primitiveGigacageSize = 2 * bmalloc::Sizes::GB;
constexpr size_t jsValueGigacageSize = 2 * bmalloc::Sizes::GB;
constexpr size_t maximumCageSizeReductionForSlide = bmalloc::Sizes::GB / 4;
-constexpr size_t configSizeToProtect = 16 * bmalloc::Sizes::kB;
#else
constexpr size_t primitiveGigacageSize = 32 * bmalloc::Sizes::GB;
constexpr size_t jsValueGigacageSize = 16 * bmalloc::Sizes::GB;
constexpr size_t maximumCageSizeReductionForSlide = 4 * bmalloc::Sizes::GB;
-constexpr size_t configSizeToProtect = 4 * bmalloc::Sizes::kB;
#endif
// In Linux, if `vm.overcommit_memory = 2` is specified, mmap with large size can fail if it exceeds the size of RAM.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
