Title: [258502] trunk
- Revision
- 258502
- Author
- [email protected]
- Date
- 2020-03-16 09:34:57 -0700 (Mon, 16 Mar 2020)
Log Message
RTCRtpSender of kind video should have a null dtmf attribute
https://bugs.webkit.org/show_bug.cgi?id=209135
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
* web-platform-tests/webrtc/RTCRtpSender.https-expected.txt: Added.
* web-platform-tests/webrtc/RTCRtpSender.https.html: Added.
Source/WebCore:
Test: imported/w3c/web-platform-tests/webrtc/RTCRtpSender.https.html
* Modules/mediastream/RTCRtpSender.cpp:
(WebCore::RTCRtpSender::dtmf):
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (258501 => 258502)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-03-16 16:22:44 UTC (rev 258501)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-03-16 16:34:57 UTC (rev 258502)
@@ -1,3 +1,13 @@
+2020-03-16 youenn fablet <[email protected]>
+
+ RTCRtpSender of kind video should have a null dtmf attribute
+ https://bugs.webkit.org/show_bug.cgi?id=209135
+
+ Reviewed by Eric Carlson.
+
+ * web-platform-tests/webrtc/RTCRtpSender.https-expected.txt: Added.
+ * web-platform-tests/webrtc/RTCRtpSender.https.html: Added.
+
2020-03-12 Sergio Villar Senin <[email protected]>
[WebXR] Import wpt tests
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpSender.https-expected.txt (0 => 258502)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpSender.https-expected.txt (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpSender.https-expected.txt 2020-03-16 16:34:57 UTC (rev 258502)
@@ -0,0 +1,3 @@
+
+PASS Video sender @dtmf is null
+
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpSender.https.html (0 => 258502)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpSender.https.html (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpSender.https.html 2020-03-16 16:34:57 UTC (rev 258502)
@@ -0,0 +1,20 @@
+<!doctype html>
+<meta charset=utf-8>
+<title>RTCRtpSender</title>
+<script src=""
+<script src=""
+<script>
+ 'use strict';
+
+test((t) => {
+ const pc = new RTCPeerConnection();
+ t.add_cleanup(() => pc.close());
+
+ const t1 = pc.addTransceiver("audio");
+ const t2 = pc.addTransceiver("video");
+
+ assert_not_equals(t1.sender.dtmf, null);
+ assert_equals(t2.sender.dtmf, null);
+}, "Video sender @dtmf is null");
+
+</script>
Modified: trunk/Source/WebCore/ChangeLog (258501 => 258502)
--- trunk/Source/WebCore/ChangeLog 2020-03-16 16:22:44 UTC (rev 258501)
+++ trunk/Source/WebCore/ChangeLog 2020-03-16 16:34:57 UTC (rev 258502)
@@ -1,3 +1,15 @@
+2020-03-16 youenn fablet <[email protected]>
+
+ RTCRtpSender of kind video should have a null dtmf attribute
+ https://bugs.webkit.org/show_bug.cgi?id=209135
+
+ Reviewed by Eric Carlson.
+
+ Test: imported/w3c/web-platform-tests/webrtc/RTCRtpSender.https.html
+
+ * Modules/mediastream/RTCRtpSender.cpp:
+ (WebCore::RTCRtpSender::dtmf):
+
2020-03-13 Sergio Villar Senin <[email protected]>
[WebXR] IDLs, stubs and build configuration for WPE
Modified: trunk/Source/WebCore/Modules/mediastream/RTCRtpSender.cpp (258501 => 258502)
--- trunk/Source/WebCore/Modules/mediastream/RTCRtpSender.cpp 2020-03-16 16:22:44 UTC (rev 258501)
+++ trunk/Source/WebCore/Modules/mediastream/RTCRtpSender.cpp 2020-03-16 16:34:57 UTC (rev 258502)
@@ -142,7 +142,7 @@
RTCDTMFSender* RTCRtpSender::dtmf()
{
- if (!m_dtmfSender && m_connection && m_connection->context() && m_backend)
+ if (!m_dtmfSender && m_connection && m_connection->context() && m_backend && m_trackKind == "audio")
m_dtmfSender = RTCDTMFSender::create(*m_connection->context(), *this, m_backend->createDTMFBackend());
return m_dtmfSender.get();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
