Title: [258511] trunk/Source
- Revision
- 258511
- Author
- [email protected]
- Date
- 2020-03-16 11:49:48 -0700 (Mon, 16 Mar 2020)
Log Message
Remove FrameView::scheduleRenderingUpdate()
https://bugs.webkit.org/show_bug.cgi?id=209109
Reviewed by Antti Koivisto.
FrameView::scheduleRenderingUpdate() called through to compositor(), but that just
turned around to call scheduleRenderingUpdate() via Page. So Remove it and change
callers to call Page::scheduleRenderingUpdate() directly.
Source/WebCore:
* page/FrameView.cpp:
(WebCore::FrameView::setViewExposedRect):
(WebCore::FrameView::scheduleRenderingUpdate): Deleted.
* page/FrameView.h:
* page/Page.cpp:
(WebCore::Page::scheduleRenderingUpdate):
* page/Page.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::scheduleRenderingUpdate):
Source/WebKitLegacy/mac:
* WebView/WebView.mm:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (258510 => 258511)
--- trunk/Source/WebCore/ChangeLog 2020-03-16 18:42:36 UTC (rev 258510)
+++ trunk/Source/WebCore/ChangeLog 2020-03-16 18:49:48 UTC (rev 258511)
@@ -1,5 +1,26 @@
2020-03-16 Simon Fraser <[email protected]>
+ Remove FrameView::scheduleRenderingUpdate()
+ https://bugs.webkit.org/show_bug.cgi?id=209109
+
+ Reviewed by Antti Koivisto.
+
+ FrameView::scheduleRenderingUpdate() called through to compositor(), but that just
+ turned around to call scheduleRenderingUpdate() via Page. So Remove it and change
+ callers to call Page::scheduleRenderingUpdate() directly.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::setViewExposedRect):
+ (WebCore::FrameView::scheduleRenderingUpdate): Deleted.
+ * page/FrameView.h:
+ * page/Page.cpp:
+ (WebCore::Page::scheduleRenderingUpdate):
+ * page/Page.h:
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::scheduleRenderingUpdate):
+
+2020-03-16 Simon Fraser <[email protected]>
+
Commit Xcode-modified xcfilelist.
New WebXR idl files.
Modified: trunk/Source/WebCore/page/FrameView.cpp (258510 => 258511)
--- trunk/Source/WebCore/page/FrameView.cpp 2020-03-16 18:42:36 UTC (rev 258510)
+++ trunk/Source/WebCore/page/FrameView.cpp 2020-03-16 18:49:48 UTC (rev 258511)
@@ -1017,14 +1017,6 @@
return widgetLayer->backing()->parentForSublayers();
}
-void FrameView::scheduleRenderingUpdate()
-{
- RenderView* view = this->renderView();
- if (!view)
- return;
- view->compositor().scheduleRenderingUpdate();
-}
-
LayoutRect FrameView::fixedScrollableAreaBoundsInflatedForScrolling(const LayoutRect& uninflatedBounds) const
{
LayoutPoint scrollPosition;
@@ -5267,11 +5259,10 @@
tiledBacking->setTiledScrollingIndicatorPosition(m_viewExposedRect ? m_viewExposedRect.value().location() : FloatPoint());
}
- if (auto* view = renderView())
- view->compositor().scheduleRenderingUpdate();
-
- if (auto* page = frame().page())
+ if (auto* page = frame().page()) {
+ page->scheduleRenderingUpdate();
page->pageOverlayController().didChangeViewExposedRect();
+ }
}
void FrameView::clearViewportSizeOverrideForCSSViewportUnits()
Modified: trunk/Source/WebCore/page/FrameView.h (258510 => 258511)
--- trunk/Source/WebCore/page/FrameView.h 2020-03-16 18:42:36 UTC (rev 258510)
+++ trunk/Source/WebCore/page/FrameView.h 2020-03-16 18:49:48 UTC (rev 258511)
@@ -151,8 +151,6 @@
WEBCORE_EXPORT GraphicsLayer* graphicsLayerForPlatformWidget(PlatformWidget);
- WEBCORE_EXPORT void scheduleRenderingUpdate();
-
WEBCORE_EXPORT TiledBacking* tiledBacking() const;
ScrollingNodeID scrollingNodeID() const override;
Modified: trunk/Source/WebCore/page/Page.cpp (258510 => 258511)
--- trunk/Source/WebCore/page/Page.cpp 2020-03-16 18:42:36 UTC (rev 258510)
+++ trunk/Source/WebCore/page/Page.cpp 2020-03-16 18:49:48 UTC (rev 258511)
@@ -1304,6 +1304,11 @@
view->updateLayoutAndStyleIfNeededRecursive();
}
+void Page::scheduleRenderingUpdate()
+{
+ renderingUpdateScheduler().scheduleRenderingUpdate();
+}
+
// https://html.spec.whatwg.org/multipage/webappapis.html#update-the-rendering
void Page::updateRendering()
{
Modified: trunk/Source/WebCore/page/Page.h (258510 => 258511)
--- trunk/Source/WebCore/page/Page.h 2020-03-16 18:42:36 UTC (rev 258510)
+++ trunk/Source/WebCore/page/Page.h 2020-03-16 18:49:48 UTC (rev 258511)
@@ -474,6 +474,8 @@
WEBCORE_EXPORT void layoutIfNeeded();
WEBCORE_EXPORT void updateRendering();
+
+ WEBCORE_EXPORT void scheduleRenderingUpdate();
WEBCORE_EXPORT void suspendScriptedAnimations();
WEBCORE_EXPORT void resumeScriptedAnimations();
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (258510 => 258511)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2020-03-16 18:42:36 UTC (rev 258510)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2020-03-16 18:49:48 UTC (rev 258511)
@@ -477,7 +477,7 @@
{
ASSERT(!m_flushingLayers);
- page().renderingUpdateScheduler().scheduleRenderingUpdate();
+ page().scheduleRenderingUpdate();
}
FloatRect RenderLayerCompositor::visibleRectForLayerFlushing() const
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (258510 => 258511)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2020-03-16 18:42:36 UTC (rev 258510)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2020-03-16 18:49:48 UTC (rev 258511)
@@ -1,3 +1,16 @@
+2020-03-16 Simon Fraser <[email protected]>
+
+ Remove FrameView::scheduleRenderingUpdate()
+ https://bugs.webkit.org/show_bug.cgi?id=209109
+
+ Reviewed by Antti Koivisto.
+
+ FrameView::scheduleRenderingUpdate() called through to compositor(), but that just
+ turned around to call scheduleRenderingUpdate() via Page. So Remove it and change
+ callers to call Page::scheduleRenderingUpdate() directly.
+
+ * WebView/WebView.mm:
+
2020-03-13 Sergio Villar Senin <[email protected]>
[WebXR] IDLs, stubs and build configuration for WPE
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebView.mm (258510 => 258511)
--- trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2020-03-16 18:42:36 UTC (rev 258510)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2020-03-16 18:49:48 UTC (rev 258511)
@@ -9312,9 +9312,8 @@
#if PLATFORM(IOS_FAMILY)
- (void)_scheduleRenderingUpdateForPendingTileCacheRepaint
{
- auto* coreFrame = [self _mainCoreFrame];
- if (auto* view = coreFrame->view())
- view->scheduleRenderingUpdate();
+ if (auto* page = _private->page)
+ page->scheduleRenderingUpdate();
}
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
