Title: [258516] trunk
- Revision
- 258516
- Author
- [email protected]
- Date
- 2020-03-16 13:21:03 -0700 (Mon, 16 Mar 2020)
Log Message
Color Picker crashes on touch
https://bugs.webkit.org/show_bug.cgi?id=209086
Reviewed by Darin Adler.
Source/WebCore:
Vector sizing lost in refactor. Not perfomance sensitive code, so just expanding vector as needed.
Test: fast/forms/color/color-input-activate-crash.html
* html/ColorInputType.cpp:
(WebCore::ColorInputType::suggestedColors const):
LayoutTests:
* fast/forms/color/color-input-activate-crash-expected.txt: Added.
* fast/forms/color/color-input-activate-crash.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (258515 => 258516)
--- trunk/LayoutTests/ChangeLog 2020-03-16 20:11:01 UTC (rev 258515)
+++ trunk/LayoutTests/ChangeLog 2020-03-16 20:21:03 UTC (rev 258516)
@@ -1,3 +1,13 @@
+2020-03-16 Megan Gardner <[email protected]>
+
+ Color Picker crashes on touch
+ https://bugs.webkit.org/show_bug.cgi?id=209086
+
+ Reviewed by Darin Adler.
+
+ * fast/forms/color/color-input-activate-crash-expected.txt: Added.
+ * fast/forms/color/color-input-activate-crash.html: Added.
+
2020-03-16 Sihui Liu <[email protected]>
IndexedDB hits assertion with crypto/workers/subtle/aes-indexeddb.html
Added: trunk/LayoutTests/fast/forms/color/color-input-activate-crash-expected.txt (0 => 258516)
--- trunk/LayoutTests/fast/forms/color/color-input-activate-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/color/color-input-activate-crash-expected.txt 2020-03-16 20:21:03 UTC (rev 258516)
@@ -0,0 +1,3 @@
+Touching the color input form should not crash.
+
+PASS: Test did not crash
Added: trunk/LayoutTests/fast/forms/color/color-input-activate-crash.html (0 => 258516)
--- trunk/LayoutTests/fast/forms/color/color-input-activate-crash.html (rev 0)
+++ trunk/LayoutTests/fast/forms/color/color-input-activate-crash.html 2020-03-16 20:21:03 UTC (rev 258516)
@@ -0,0 +1,28 @@
+
+<!DOCTYPE html>
+<html>
+<script src=""
+</head>
+<body>
+<script>
+ if (window.testRunner) {
+ testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+ }
+ async function runTest() {
+ if (!testRunner.runUIScript)
+ return;
+
+ var input = document.getElementById('colorInput');
+ await UIHelper.activateElementAndWaitForInputSession(input);
+ document.getElementById('result').innerHTML = 'PASS: Test did not crash';
+ testRunner.notifyDone();
+ }
+
+ window.addEventListener('load', runTest, false);
+</script>
+<div>Touching the color input form should not crash.</div>
+<input id = 'colorInput' type = "color" value = "#00FF00" style = "font-size:18px">
+<div id = 'result'></div>
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (258515 => 258516)
--- trunk/Source/WebCore/ChangeLog 2020-03-16 20:11:01 UTC (rev 258515)
+++ trunk/Source/WebCore/ChangeLog 2020-03-16 20:21:03 UTC (rev 258516)
@@ -1,3 +1,17 @@
+2020-03-16 Megan Gardner <[email protected]>
+
+ Color Picker crashes on touch
+ https://bugs.webkit.org/show_bug.cgi?id=209086
+
+ Reviewed by Darin Adler.
+
+ Vector sizing lost in refactor. Not perfomance sensitive code, so just expanding vector as needed.
+
+ Test: fast/forms/color/color-input-activate-crash.html
+
+ * html/ColorInputType.cpp:
+ (WebCore::ColorInputType::suggestedColors const):
+
2020-03-16 Simon Fraser <[email protected]>
Remove FrameView::scheduleRenderingUpdate()
Modified: trunk/Source/WebCore/html/ColorInputType.cpp (258515 => 258516)
--- trunk/Source/WebCore/html/ColorInputType.cpp 2020-03-16 20:11:01 UTC (rev 258515)
+++ trunk/Source/WebCore/html/ColorInputType.cpp 2020-03-16 20:21:03 UTC (rev 258516)
@@ -288,7 +288,7 @@
if (auto dataList = element()->dataList()) {
for (auto& option : dataList->suggestions()) {
if (auto color = parseSimpleColorValue(option.value()))
- suggestions.uncheckedAppend(*color);
+ suggestions.append(*color);
}
}
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
