Title: [258562] trunk
- Revision
- 258562
- Author
- [email protected]
- Date
- 2020-03-17 11:17:01 -0700 (Tue, 17 Mar 2020)
Log Message
[WKTR] Crash when trying to open a new window in an ephemeral session test
https://bugs.webkit.org/show_bug.cgi?id=209181
Reviewed by Geoffrey Garen.
Tools:
Make sure that the new WKWebView is using the same data store as its related WKWebView.
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::platformCreateOtherPage):
LayoutTests:
Add layout test coverage.
* fast/dom/window-open-ephemeral-expected.txt: Added.
* fast/dom/window-open-ephemeral.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (258561 => 258562)
--- trunk/LayoutTests/ChangeLog 2020-03-17 18:07:55 UTC (rev 258561)
+++ trunk/LayoutTests/ChangeLog 2020-03-17 18:17:01 UTC (rev 258562)
@@ -1,3 +1,15 @@
+2020-03-17 Chris Dumez <[email protected]>
+
+ [WKTR] Crash when trying to open a new window in an ephemeral session test
+ https://bugs.webkit.org/show_bug.cgi?id=209181
+
+ Reviewed by Geoffrey Garen.
+
+ Add layout test coverage.
+
+ * fast/dom/window-open-ephemeral-expected.txt: Added.
+ * fast/dom/window-open-ephemeral.html: Added.
+
2020-03-16 Simon Fraser <[email protected]>
Clean up some latching tests
Added: trunk/LayoutTests/fast/dom/window-open-ephemeral-expected.txt (0 => 258562)
--- trunk/LayoutTests/fast/dom/window-open-ephemeral-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/window-open-ephemeral-expected.txt 2020-03-17 18:17:01 UTC (rev 258562)
@@ -0,0 +1,10 @@
+Tests that window.open() is working in ephemeral sessions
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS !!w is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/dom/window-open-ephemeral.html (0 => 258562)
--- trunk/LayoutTests/fast/dom/window-open-ephemeral.html (rev 0)
+++ trunk/LayoutTests/fast/dom/window-open-ephemeral.html 2020-03-17 18:17:01 UTC (rev 258562)
@@ -0,0 +1,20 @@
+<!-- webkit-test-runner [ useEphemeralSession=true ] -->
+<!DOCTYPE html>
+<html>
+<body>
+<script src=""
+<script>
+description("Tests that window.open() is working in ephemeral sessions");
+jsTestIsAsync = true;
+
+if (window.testRunner)
+ testRunner.setCanOpenWindows(true);
+
+_onload_ = () => {
+ w = open("about:blank");
+ shouldBeTrue("!!w");
+ finishJSTest();
+}
+</script>
+</body>
+</html>
Modified: trunk/Tools/ChangeLog (258561 => 258562)
--- trunk/Tools/ChangeLog 2020-03-17 18:07:55 UTC (rev 258561)
+++ trunk/Tools/ChangeLog 2020-03-17 18:17:01 UTC (rev 258562)
@@ -1,3 +1,15 @@
+2020-03-17 Chris Dumez <[email protected]>
+
+ [WKTR] Crash when trying to open a new window in an ephemeral session test
+ https://bugs.webkit.org/show_bug.cgi?id=209181
+
+ Reviewed by Geoffrey Garen.
+
+ Make sure that the new WKWebView is using the same data store as its related WKWebView.
+
+ * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
+ (WTR::TestController::platformCreateOtherPage):
+
2020-03-17 Jacob Uphoff <[email protected]>
Unreviewed, reverting r257844.
Modified: trunk/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm (258561 => 258562)
--- trunk/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm 2020-03-17 18:07:55 UTC (rev 258561)
+++ trunk/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm 2020-03-17 18:17:01 UTC (rev 258562)
@@ -184,6 +184,8 @@
{
WKWebViewConfiguration *newConfiguration = [[globalWebViewConfiguration copy] autorelease];
newConfiguration._relatedWebView = static_cast<WKWebView*>(parentView->platformView());
+ if (newConfiguration._relatedWebView)
+ newConfiguration.websiteDataStore = newConfiguration._relatedWebView.configuration.websiteDataStore;
PlatformWebView* view = new PlatformWebView(newConfiguration, options);
finishCreatingPlatformWebView(view, options);
return view;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
