Title: [258606] trunk/Source/WebCore
- Revision
- 258606
- Author
- [email protected]
- Date
- 2020-03-17 15:45:17 -0700 (Tue, 17 Mar 2020)
Log Message
TextTrackBase should validate language before setting m_validBCP47Language
https://bugs.webkit.org/show_bug.cgi?id=209094
<rdar://problem/60439603>
Unreviewed, address post-commit review comments.
* html/track/TrackBase.cpp:
(WebCore::TrackBase::setLanguage): Use makeString instead of StringBuilder.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (258605 => 258606)
--- trunk/Source/WebCore/ChangeLog 2020-03-17 22:44:43 UTC (rev 258605)
+++ trunk/Source/WebCore/ChangeLog 2020-03-17 22:45:17 UTC (rev 258606)
@@ -4,6 +4,17 @@
https://bugs.webkit.org/show_bug.cgi?id=209094
<rdar://problem/60439603>
+ Unreviewed, address post-commit review comments.
+
+ * html/track/TrackBase.cpp:
+ (WebCore::TrackBase::setLanguage): Use makeString instead of StringBuilder.
+
+2020-03-17 Eric Carlson <[email protected]>
+
+ TextTrackBase should validate language before setting m_validBCP47Language
+ https://bugs.webkit.org/show_bug.cgi?id=209094
+ <rdar://problem/60439603>
+
Reviewed by Jer Noble.
Test: media/track/track-bcp-language.html
Modified: trunk/Source/WebCore/html/track/TrackBase.cpp (258605 => 258606)
--- trunk/Source/WebCore/html/track/TrackBase.cpp 2020-03-17 22:44:43 UTC (rev 258605)
+++ trunk/Source/WebCore/html/track/TrackBase.cpp 2020-03-17 22:45:17 UTC (rev 258606)
@@ -148,13 +148,8 @@
String message;
if (language.contains((UChar)'\0'))
message = "The language contains a null character and is not a valid BCP 47 language tag."_s;
- else {
- StringBuilder stringBuilder;
- stringBuilder.appendLiteral("The language '");
- stringBuilder.append(language);
- stringBuilder.appendLiteral("' is not a valid BCP 47 language tag.");
- message = stringBuilder.toString();
- }
+ else
+ message = makeString("The language '", language, "' is not a valid BCP 47 language tag.");
element->document().addConsoleMessage(MessageSource::Rendering, MessageLevel::Warning, message);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
