Title: [258610] trunk/Source/WebKit
Revision
258610
Author
[email protected]
Date
2020-03-17 16:32:57 -0700 (Tue, 17 Mar 2020)

Log Message

Fix API tests after r258574
https://bugs.webkit.org/show_bug.cgi?id=209192

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::printFrame):
I forgot to call the CompletionHandler from the IPC call.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (258609 => 258610)


--- trunk/Source/WebKit/ChangeLog	2020-03-17 23:02:36 UTC (rev 258609)
+++ trunk/Source/WebKit/ChangeLog	2020-03-17 23:32:57 UTC (rev 258610)
@@ -1,3 +1,12 @@
+2020-03-17  Alex Christensen  <[email protected]>
+
+        Fix API tests after r258574
+        https://bugs.webkit.org/show_bug.cgi?id=209192
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::printFrame):
+        I forgot to call the CompletionHandler from the IPC call.
+
 2020-03-17  Jiewen Tan  <[email protected]>
 
         WebKit::LocalAuthenticator::deleteDuplicateCredential() should check buffer size before memcmp

Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (258609 => 258610)


--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2020-03-17 23:02:36 UTC (rev 258609)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2020-03-17 23:32:57 UTC (rev 258610)
@@ -5817,9 +5817,10 @@
     WebFrameProxy* frame = m_process->webFrame(frameID);
     MESSAGE_CHECK(m_process, frame);
 
-    m_uiClient->printFrame(*this, *frame, [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)] {
+    m_uiClient->printFrame(*this, *frame, [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)] () mutable {
         endPrinting(); // Send a message synchronously while m_isPerformingDOMPrintOperation is still true.
         m_isPerformingDOMPrintOperation = false;
+        completionHandler();
     });
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to