Log Message
[ macOS iOS ] animations/play-state-paused.html is flaky failing https://bugs.webkit.org/show_bug.cgi?id=206682 <rdar://problem/58840950>
Patch by Antoine Quint <[email protected]> on 2020-03-18 Reviewed by Antti Koivisto. To make this test robust we animate a non-accelerated property and we use the Web Animations API to set the time at which we want to pause the animation (1s). * animations/play-state-paused-expected.txt: * animations/play-state-paused.html: * platform/ios-wk2/TestExpectations: * platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (258626 => 258627)
--- trunk/LayoutTests/ChangeLog 2020-03-18 09:54:55 UTC (rev 258626)
+++ trunk/LayoutTests/ChangeLog 2020-03-18 13:34:29 UTC (rev 258627)
@@ -1,3 +1,19 @@
+2020-03-18 Antoine Quint <[email protected]>
+
+ [ macOS iOS ] animations/play-state-paused.html is flaky failing
+ https://bugs.webkit.org/show_bug.cgi?id=206682
+ <rdar://problem/58840950>
+
+ Reviewed by Antti Koivisto.
+
+ To make this test robust we animate a non-accelerated property and we use the Web Animations API to set the time
+ at which we want to pause the animation (1s).
+
+ * animations/play-state-paused-expected.txt:
+ * animations/play-state-paused.html:
+ * platform/ios-wk2/TestExpectations:
+ * platform/mac/TestExpectations:
+
2020-03-18 Philippe Normand <[email protected]>
[GTK][WPE] Migrate to Flatpak-based dev SDK
Modified: trunk/LayoutTests/animations/play-state-paused-expected.txt (258626 => 258627)
--- trunk/LayoutTests/animations/play-state-paused-expected.txt 2020-03-18 09:54:55 UTC (rev 258626)
+++ trunk/LayoutTests/animations/play-state-paused-expected.txt 2020-03-18 13:34:29 UTC (rev 258627)
@@ -1,4 +1,4 @@
-PASS - "webkitTransform" property for "box" element at 0.5s saw something close to: 1,0,0,1,75,0
-PASS - "webkitTransform" property for "box" element at 1s saw something close to: 1,0,0,1,150,0
-PASS - "webkitTransform" property for "box" element at 2.5s saw something close to: 1,0,0,1,150,0
+PASS - "margin-left" property for "box" element at 0.5s saw something close to: 75
+PASS - "margin-left" property for "box" element at 1s saw something close to: 150
+PASS - "margin-left" property for "box" element at 2.5s saw something close to: 150
Modified: trunk/LayoutTests/animations/play-state-paused.html (258626 => 258627)
--- trunk/LayoutTests/animations/play-state-paused.html 2020-03-18 09:54:55 UTC (rev 258626)
+++ trunk/LayoutTests/animations/play-state-paused.html 2020-03-18 13:34:29 UTC (rev 258627)
@@ -30,8 +30,8 @@
background-color: green;
}
@-webkit-keyframes "move1" {
- from { -webkit-transform: translateX(0px); }
- to { -webkit-transform: translateX(300px); }
+ from { margin-left: 0px; }
+ to { margin-left: 300px; }
}
#result {
color: white; /* hide from pixel results */
@@ -41,14 +41,16 @@
<script type="text/_javascript_" charset="utf-8">
const expectedValues = [
// [animation-name, time, element-id, property, expected-value, tolerance]
- ["move1", 0.5, "box", "webkitTransform", [1,0,0,1,75,0], 20],
- ["move1", 1.0, "box", "webkitTransform", [1,0,0,1,150,0], 20],
- ["move1", 2.5, "box", "webkitTransform", [1,0,0,1,150,0], 20],
+ ["move1", 0.5, "box", "margin-left", 75, 20],
+ ["move1", 1.0, "box", "margin-left", 150, 20],
+ ["move1", 2.5, "box", "margin-left", 150, 20],
];
function pauseAnimation()
{
- document.getElementById("box").style.webkitAnimationPlayState = "paused";
+ const box = document.getElementById("box");
+ box.style.webkitAnimationPlayState = "paused";
+ box.getAnimations()[0].currentTime = 1000;
}
function setTimers()
Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (258626 => 258627)
--- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-03-18 09:54:55 UTC (rev 258626)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-03-18 13:34:29 UTC (rev 258627)
@@ -1318,8 +1318,6 @@
webkit.org/b/206630 [ Release ] fast/forms/validationMessage.html [ Pass Timeout ]
-webkit.org/b/206682 animations/play-state-paused.html [ Pass Failure ]
-
webkit.org/b/206685 [ Debug ] animations/animation-direction-normal.html [ Pass Failure ]
webkit.org/b/206687 imported/w3c/web-platform-tests/beacon/idlharness.any.html [ Pass Timeout ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (258626 => 258627)
--- trunk/LayoutTests/platform/mac/TestExpectations 2020-03-18 09:54:55 UTC (rev 258626)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2020-03-18 13:34:29 UTC (rev 258627)
@@ -1911,8 +1911,6 @@
webkit.org/b/203222 svg/wicd/rightsizing-grid.xhtml [ Pass Failure ]
-webkit.org/b/206682 [ Debug ] animations/play-state-paused.html [ Pass Failure ]
-
webkit.org/b/206685 animations/animation-direction-normal.html [ Pass Failure ]
webkit.org/b/206671 animations/animation-direction-reverse.html [ Pass Failure ]
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
