Title: [258636] trunk/Websites/bugs.webkit.org
- Revision
- 258636
- Author
- [email protected]
- Date
- 2020-03-18 08:31:18 -0700 (Wed, 18 Mar 2020)
Log Message
Remove status-bubble iframe from old EWS
https://bugs.webkit.org/show_bug.cgi?id=209215
Reviewed by Jonathan Bedard.
* code-review.js:
* js/status-bubble.js:
(handleStatusBubbleLoadNewEWS): Deleted.
* template/en/default/attachment/edit.html.tmpl: Removed old EWS iframe.
* template/en/default/attachment/list.html.tmpl: Ditto.
* template/en/default/attachment/reviewform.html.tmpl: Ditto.
Modified Paths
Diff
Modified: trunk/Websites/bugs.webkit.org/ChangeLog (258635 => 258636)
--- trunk/Websites/bugs.webkit.org/ChangeLog 2020-03-18 15:30:09 UTC (rev 258635)
+++ trunk/Websites/bugs.webkit.org/ChangeLog 2020-03-18 15:31:18 UTC (rev 258636)
@@ -1,3 +1,17 @@
+2020-03-17 Aakash Jain <[email protected]>
+
+ Remove status-bubble iframe from old EWS
+ https://bugs.webkit.org/show_bug.cgi?id=209215
+
+ Reviewed by Jonathan Bedard.
+
+ * code-review.js:
+ * js/status-bubble.js:
+ (handleStatusBubbleLoadNewEWS): Deleted.
+ * template/en/default/attachment/edit.html.tmpl: Removed old EWS iframe.
+ * template/en/default/attachment/list.html.tmpl: Ditto.
+ * template/en/default/attachment/reviewform.html.tmpl: Ditto.
+
2019-11-06 James Savage <[email protected]>
Support CSS Dark Mode for PrettyDiff.rb.
Modified: trunk/Websites/bugs.webkit.org/code-review.js (258635 => 258636)
--- trunk/Websites/bugs.webkit.org/code-review.js 2020-03-18 15:30:09 UTC (rev 258635)
+++ trunk/Websites/bugs.webkit.org/code-review.js 2020-03-18 15:31:18 UTC (rev 258636)
@@ -568,19 +568,12 @@
addFlagsForAttachment(details);
var statusBubble = document.createElement('iframe');
- statusBubble.src = '' + attachment_id;
+ statusBubble.src = '' + attachment_id + '?hide_icons=True';
statusBubble.scrolling = 'no';
// Can't append the HTML because we need to set the onload handler before appending the iframe to the DOM.
statusBubble._onload_ = function () { handleStatusBubbleLoad(this); };
$('.statusBubble').append(statusBubble);
- var statusBubbleNewEWS = document.createElement('iframe');
- statusBubbleNewEWS.src = '' + attachment_id + '?hide_icons=True';
- // Can't append the HTML because we need to set the onload handler before appending the iframe to the DOM.
- statusBubbleNewEWS.scrolling = "no";
- statusBubbleNewEWS._onload_ = function () { handleStatusBubbleLoadNewEWS(this); };
- $('.statusBubble').append(statusBubbleNewEWS);
-
$('#toolbar .bugLink').html('<a href="" + bug_id + '" target="_blank">Bug ' + bug_id + '</a>');
});
}
Modified: trunk/Websites/bugs.webkit.org/js/status-bubble.js (258635 => 258636)
--- trunk/Websites/bugs.webkit.org/js/status-bubble.js 2020-03-18 15:30:09 UTC (rev 258635)
+++ trunk/Websites/bugs.webkit.org/js/status-bubble.js 2020-03-18 15:31:18 UTC (rev 258636)
@@ -25,7 +25,7 @@
*/
function handleStatusBubbleMessage(event) {
- if ((event.origin !== 'https://webkit-queues.webkit.org' && event.origin !== 'https://ews.webkit.org') || !event.data.height)
+ if (event.origin !== 'https://ews.webkit.org' || !event.data.height)
return;
for (const iframe of document.querySelectorAll('.statusBubble > iframe')) {
@@ -38,9 +38,5 @@
}
function handleStatusBubbleLoad(iframe) {
- iframe.contentWindow.postMessage('containerMetrics', 'https://webkit-queues.webkit.org');
-}
-
-function handleStatusBubbleLoadNewEWS(iframe) {
iframe.contentWindow.postMessage('containerMetrics', 'https://ews.webkit.org');
}
Modified: trunk/Websites/bugs.webkit.org/template/en/default/attachment/edit.html.tmpl (258635 => 258636)
--- trunk/Websites/bugs.webkit.org/template/en/default/attachment/edit.html.tmpl 2020-03-18 15:30:09 UTC (rev 258635)
+++ trunk/Websites/bugs.webkit.org/template/en/default/attachment/edit.html.tmpl 2020-03-18 15:31:18 UTC (rev 258636)
@@ -264,12 +264,9 @@
Bot Status:
<div class="statusBubble">
- <iframe src="" attachment.id %]"
+ <iframe src="" attachment.id %]?hide_icons=True"
style="width: 0px; height: 20px; border: none;" scrolling="no" _onload_="handleStatusBubbleLoad(this)">
</iframe>
- <iframe src="" attachment.id %]?hide_icons=True"
- style="width: 0px; height: 20px; border: none;" scrolling="no" _onload_="handleStatusBubbleLoadNewEWS(this)">
- </iframe>
</div>
<br>
[% END %]
Modified: trunk/Websites/bugs.webkit.org/template/en/default/attachment/list.html.tmpl (258635 => 258636)
--- trunk/Websites/bugs.webkit.org/template/en/default/attachment/list.html.tmpl 2020-03-18 15:30:09 UTC (rev 258635)
+++ trunk/Websites/bugs.webkit.org/template/en/default/attachment/list.html.tmpl 2020-03-18 15:31:18 UTC (rev 258636)
@@ -155,12 +155,9 @@
[%# if WEBKIT_CHANGES %]
[% IF attachment.ispatch %]
<div class="statusBubble">
- <iframe src="" attachment.id %]"
+ <iframe src="" attachment.id %]/"
style="width: 0px; height: 20px; border: none;" scrolling="no" _onload_="handleStatusBubbleLoad(this)">
</iframe>
- <iframe src="" attachment.id %]/"
- style="width: 0px; height: 20px; border: none;" scrolling="no" _onload_="handleStatusBubbleLoadNewEWS(this)">
- </iframe>
</div>
[% END %]
[%# endif // WEBKIT_CHANGES %]
Modified: trunk/Websites/bugs.webkit.org/template/en/default/attachment/reviewform.html.tmpl (258635 => 258636)
--- trunk/Websites/bugs.webkit.org/template/en/default/attachment/reviewform.html.tmpl 2020-03-18 15:30:09 UTC (rev 258635)
+++ trunk/Websites/bugs.webkit.org/template/en/default/attachment/reviewform.html.tmpl 2020-03-18 15:31:18 UTC (rev 258636)
@@ -103,9 +103,6 @@
<tr>
<td>
<div class="statusBubble" style="margin-left: 30px;">
- <iframe src="" attachment.id %]"
- style="width: 400px; height: 20px; border: none;" scrolling="no">
- </iframe>
<iframe src="" attachment.id %]?hide_icons=True"
style="width: 700px; height: 20px; border: none;" scrolling="no">
</iframe>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
