Title: [258642] trunk/Tools
- Revision
- 258642
- Author
- [email protected]
- Date
- 2020-03-18 10:02:27 -0700 (Wed, 18 Mar 2020)
Log Message
commit-queue should allow patches which are reviewed by patch author
https://bugs.webkit.org/show_bug.cgi?id=209231
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps.py:
(BugzillaMixin._does_patch_have_acceptable_review_flag):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (258641 => 258642)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-03-18 16:18:57 UTC (rev 258641)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-03-18 17:02:27 UTC (rev 258642)
@@ -450,9 +450,6 @@
self.setProperty('patch_reviewer', patch_reviewer)
if self.addURLs:
self.addURL('Reviewed by: {}'.format(patch_reviewer), '')
- if patch_reviewer == patch_json.get('creator'):
- self._addToLog('stdio', 'Patch {} is r+ by the patch author {} itself. This seems like a mistake.\n'.format(patch_id, patch_reviewer))
- return 0
return 1
if review_status in ['-', '?']:
self._addToLog('stdio', 'Patch {} is marked r{}.\n'.format(patch_id, review_status))
Modified: trunk/Tools/ChangeLog (258641 => 258642)
--- trunk/Tools/ChangeLog 2020-03-18 16:18:57 UTC (rev 258641)
+++ trunk/Tools/ChangeLog 2020-03-18 17:02:27 UTC (rev 258642)
@@ -1,3 +1,13 @@
+2020-03-18 Aakash Jain <[email protected]>
+
+ commit-queue should allow patches which are reviewed by patch author
+ https://bugs.webkit.org/show_bug.cgi?id=209231
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+ (BugzillaMixin._does_patch_have_acceptable_review_flag):
+
2020-03-18 Philippe Normand <[email protected]>
[JHBuild] Flatpak used for run-minibrowser even when forcing jhbuild
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
