Title: [258674] trunk/LayoutTests
- Revision
- 258674
- Author
- [email protected]
- Date
- 2020-03-18 19:27:56 -0700 (Wed, 18 Mar 2020)
Log Message
svg/custom/animate-initial-pause-unpause.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=127116
<rdar://problem/59430898>
Patch by Said Abou-Hallawa <[email protected]> on 2020-03-18
Reviewed by Ryosuke Niwa.
Use the 'onend' event to perform post-animation actions instead of relying
on setTimeout() which can be flaky if the bots are really slow.
* platform/gtk/TestExpectations:
* platform/ios-wk2/TestExpectations:
* platform/mac/TestExpectations:
* svg/custom/animate-initial-pause-unpause.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (258673 => 258674)
--- trunk/LayoutTests/ChangeLog 2020-03-19 02:09:44 UTC (rev 258673)
+++ trunk/LayoutTests/ChangeLog 2020-03-19 02:27:56 UTC (rev 258674)
@@ -1,3 +1,19 @@
+2020-03-18 Said Abou-Hallawa <[email protected]>
+
+ svg/custom/animate-initial-pause-unpause.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=127116
+ <rdar://problem/59430898>
+
+ Reviewed by Ryosuke Niwa.
+
+ Use the 'onend' event to perform post-animation actions instead of relying
+ on setTimeout() which can be flaky if the bots are really slow.
+
+ * platform/gtk/TestExpectations:
+ * platform/ios-wk2/TestExpectations:
+ * platform/mac/TestExpectations:
+ * svg/custom/animate-initial-pause-unpause.html:
+
2020-03-18 John Wilander <[email protected]>
WebResourceLoadStatisticsStore::requestStorageAccessUnderOpener() should call its ephemeral counterpart when appropriate
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (258673 => 258674)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2020-03-19 02:09:44 UTC (rev 258673)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2020-03-19 02:27:56 UTC (rev 258674)
@@ -1737,8 +1737,6 @@
webkit.org/b/134760 plugins/layout-in-beforeload-listener-affects-plugin-loading.html [ Failure Pass ]
-webkit.org/b/134761 svg/custom/animate-initial-pause-unpause.html [ Failure Pass ]
-
webkit.org/b/134994 fast/forms/select/listbox-click-on-scrollbar.html [ Failure Pass ]
webkit.org/b/134981 fast/parser/document-write-during-load.html [ Timeout Pass Crash ]
Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (258673 => 258674)
--- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-03-19 02:09:44 UTC (rev 258673)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-03-19 02:27:56 UTC (rev 258674)
@@ -1114,8 +1114,6 @@
webkit.org/b/162524 [ Release ] http/tests/cache/disk-cache/disk-cache-redirect.html [ Pass Timeout ]
-webkit.org/b/127116 [ Debug ] svg/custom/animate-initial-pause-unpause.html [ Pass Failure ]
-
webkit.org/b/163362 platform/ios/ios/plugin/youtube-flash-plugin-iframe.html [ Pass Failure ]
webkit.org/b/164960 http/tests/security/module-correct-mime-types.html [ Slow ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (258673 => 258674)
--- trunk/LayoutTests/platform/mac/TestExpectations 2020-03-19 02:09:44 UTC (rev 258673)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2020-03-19 02:27:56 UTC (rev 258674)
@@ -1208,8 +1208,6 @@
webkit.org/b/162830 [ Debug ] fast/events/tabindex-focus-blur-all.html [ Pass Timeout ]
-webkit.org/b/127116 [ Debug ] svg/custom/animate-initial-pause-unpause.html [ Pass Failure ]
-
# Variation fonts are not implemented earlier than High Sierra.
[ Sierra ] fast/text/variations [ Pass Failure ImageOnlyFailure ]
[ Sierra ] animations/font-variations [ Pass Failure ImageOnlyFailure Timeout ]
@@ -1973,8 +1971,6 @@
webkit.org/b/194162 storage/websql/read-transactions-running-concurrently.html [ Pass Failure ]
-webkit.org/b/207710 svg/custom/animate-initial-pause-unpause.html [ Pass Failure ]
-
webkit.org/b/207046 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/seeking/seek-to-currentTime.html [ Pass Failure ]
webkit.org/b/207723 http/tests/contentextensions/hide-on-ping-with-ping-that-redirects.html [ Pass Failure ]
Modified: trunk/LayoutTests/svg/custom/animate-initial-pause-unpause.html (258673 => 258674)
--- trunk/LayoutTests/svg/custom/animate-initial-pause-unpause.html 2020-03-19 02:09:44 UTC (rev 258673)
+++ trunk/LayoutTests/svg/custom/animate-initial-pause-unpause.html 2020-03-19 02:27:56 UTC (rev 258674)
@@ -7,7 +7,7 @@
<svg id="svg" width="400" height="400">
<rect x="0" y="0" width="100" height="100" fill="red"/>
<rect id="rect" x="100" y="0" width="100" height="100" fill="green">
- <set attributeName="x" to="0" begin="0.01s" fill="freeze"/>
+ <set attributeName="x" to="0" begin="10ms" end="30ms" fill="freeze" _onend_="handleEndEvent()"/>
</rect>
</svg>
<script>
@@ -22,7 +22,7 @@
svg.pauseAnimations();
svg.unpauseAnimations();
- setTimeout(function() {
+ function handleEndEvent() {
if (rect.x.animVal.value == 0)
document.body.innerHTML = "PASS";
else
@@ -30,7 +30,7 @@
if (window.testRunner)
testRunner.notifyDone();
- }, 50);
+ }
</script>
</body>
</html>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
