Title: [258694] trunk/Tools
- Revision
- 258694
- Author
- [email protected]
- Date
- 2020-03-19 06:27:18 -0700 (Thu, 19 Mar 2020)
Log Message
[CMake] cache not cleared when build-webkit options change
https://bugs.webkit.org/show_bug.cgi?id=209277
Patch by Philippe Normand <[email protected]> on 2020-03-19
Reviewed by Adrian Perez de Castro.
* Scripts/webkitdirs.pm:
(shouldRemoveCMakeCache): The expected function signature never
included the cache file path. Remove it.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (258693 => 258694)
--- trunk/Tools/ChangeLog 2020-03-19 12:06:49 UTC (rev 258693)
+++ trunk/Tools/ChangeLog 2020-03-19 13:27:18 UTC (rev 258694)
@@ -1,3 +1,14 @@
+2020-03-19 Philippe Normand <[email protected]>
+
+ [CMake] cache not cleared when build-webkit options change
+ https://bugs.webkit.org/show_bug.cgi?id=209277
+
+ Reviewed by Adrian Perez de Castro.
+
+ * Scripts/webkitdirs.pm:
+ (shouldRemoveCMakeCache): The expected function signature never
+ included the cache file path. Remove it.
+
2020-03-18 Philippe Normand <[email protected]>
REGRESSION(r258626): webkit-dirs warning
Modified: trunk/Tools/Scripts/webkitdirs.pm (258693 => 258694)
--- trunk/Tools/Scripts/webkitdirs.pm 2020-03-19 12:06:49 UTC (rev 258693)
+++ trunk/Tools/Scripts/webkitdirs.pm 2020-03-19 13:27:18 UTC (rev 258694)
@@ -2189,7 +2189,7 @@
sub shouldRemoveCMakeCache(@)
{
- my ($cacheFilePath, @buildArgs) = @_;
+ my (@buildArgs) = @_;
# We check this first, because we always want to create this file for a fresh build.
my $productDir = File::Spec->catdir(baseProductDir(), configuration());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
