Title: [258774] trunk
- Revision
- 258774
- Author
- [email protected]
- Date
- 2020-03-20 11:39:35 -0700 (Fri, 20 Mar 2020)
Log Message
Fix JSCOnly build without unified sources
https://bugs.webkit.org/show_bug.cgi?id=209343
Patch by Justin Michaud <[email protected]> on 2020-03-20
Reviewed by Keith Miller.
.:
* .gitignore:
Source/_javascript_Core:
I managed to get clangd to work for code completion using the following command:
./Tools/Scripts/build-webkit --jsc-only --cmakeargs="-DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DENABLE_UNIFIED_BUILDS=OFF" && compdb -p WebKitBuild/Release/ list > compile_commands.json
This patch fixes the build for non-unified sources, and adds some extra clangd files to .gitignore.
* API/MarkedJSValueRefArray.h:
* jit/JITPropertyAccess.cpp:
Modified Paths
Diff
Modified: trunk/.gitignore (258773 => 258774)
--- trunk/.gitignore 2020-03-20 18:37:12 UTC (rev 258773)
+++ trunk/.gitignore 2020-03-20 18:39:35 UTC (rev 258774)
@@ -26,6 +26,8 @@
tags
*~
.*.sw[a-p]
+.clangd
+compile_commands.json
# Ignore CMake caches outside of the build directory.
__cmake_systeminformation/
Modified: trunk/ChangeLog (258773 => 258774)
--- trunk/ChangeLog 2020-03-20 18:37:12 UTC (rev 258773)
+++ trunk/ChangeLog 2020-03-20 18:39:35 UTC (rev 258774)
@@ -1,3 +1,12 @@
+2020-03-20 Justin Michaud <[email protected]>
+
+ Fix JSCOnly build without unified sources
+ https://bugs.webkit.org/show_bug.cgi?id=209343
+
+ Reviewed by Keith Miller.
+
+ * .gitignore:
+
2020-03-17 Philippe Normand <[email protected]>
RELEASE_LOG should not be Cocoa specific
Modified: trunk/Source/_javascript_Core/API/MarkedJSValueRefArray.h (258773 => 258774)
--- trunk/Source/_javascript_Core/API/MarkedJSValueRefArray.h 2020-03-20 18:37:12 UTC (rev 258773)
+++ trunk/Source/_javascript_Core/API/MarkedJSValueRefArray.h 2020-03-20 18:39:35 UTC (rev 258774)
@@ -25,7 +25,9 @@
#pragma once
+#include "APICast.h"
#include "ArgList.h"
+#include <wtf/CagedUniquePtr.h>
#include <wtf/ForbidHeapAllocation.h>
#include <wtf/Noncopyable.h>
#include <wtf/Nonmovable.h>
Modified: trunk/Source/_javascript_Core/ChangeLog (258773 => 258774)
--- trunk/Source/_javascript_Core/ChangeLog 2020-03-20 18:37:12 UTC (rev 258773)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-03-20 18:39:35 UTC (rev 258774)
@@ -1,3 +1,19 @@
+2020-03-20 Justin Michaud <[email protected]>
+
+ Fix JSCOnly build without unified sources
+ https://bugs.webkit.org/show_bug.cgi?id=209343
+
+ Reviewed by Keith Miller.
+
+ I managed to get clangd to work for code completion using the following command:
+
+ ./Tools/Scripts/build-webkit --jsc-only --cmakeargs="-DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DENABLE_UNIFIED_BUILDS=OFF" && compdb -p WebKitBuild/Release/ list > compile_commands.json
+
+ This patch fixes the build for non-unified sources, and adds some extra clangd files to .gitignore.
+
+ * API/MarkedJSValueRefArray.h:
+ * jit/JITPropertyAccess.cpp:
+
2020-03-20 Tim Horton <[email protected]>
Upstream a variety of Cocoa-platform HAVE and ENABLE macros
Modified: trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp (258773 => 258774)
--- trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp 2020-03-20 18:37:12 UTC (rev 258773)
+++ trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp 2020-03-20 18:39:35 UTC (rev 258774)
@@ -28,6 +28,7 @@
#if ENABLE(JIT)
#include "JIT.h"
+#include "CacheableIdentifierInlines.h"
#include "CodeBlock.h"
#include "DirectArguments.h"
#include "GCAwareJITStubRoutine.h"
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
