Title: [258808] trunk
- Revision
- 258808
- Author
- [email protected]
- Date
- 2020-03-21 08:22:05 -0700 (Sat, 21 Mar 2020)
Log Message
[GTK] Use ${PYTHON_EXECUTABLE} to run generate-gtkdoc
https://bugs.webkit.org/show_bug.cgi?id=208970
Patch by Michael Catanzaro <[email protected]> on 2020-03-21
Reviewed by Konstantin Tokarev.
.:
There's no need to rely on shebangs when executing python scripts from CMake. This should
ensure the script always works even if the shebang does not.
* Source/cmake/GtkDoc.cmake:
Tools:
We are allowed to use /usr/bin/env in this script because it's not installed (so not
packaged). Therefore we can make the shebang compatible with FreeBSD in this particularl
case.
* gtkdoc/generate-gtkdoc:
Modified Paths
Diff
Modified: trunk/ChangeLog (258807 => 258808)
--- trunk/ChangeLog 2020-03-21 14:25:09 UTC (rev 258807)
+++ trunk/ChangeLog 2020-03-21 15:22:05 UTC (rev 258808)
@@ -1,3 +1,15 @@
+2020-03-21 Michael Catanzaro <[email protected]>
+
+ [GTK] Use ${PYTHON_EXECUTABLE} to run generate-gtkdoc
+ https://bugs.webkit.org/show_bug.cgi?id=208970
+
+ Reviewed by Konstantin Tokarev.
+
+ There's no need to rely on shebangs when executing python scripts from CMake. This should
+ ensure the script always works even if the shebang does not.
+
+ * Source/cmake/GtkDoc.cmake:
+
2020-03-20 Justin Michaud <[email protected]>
Fix JSCOnly build without unified sources
Modified: trunk/Source/cmake/GtkDoc.cmake (258807 => 258808)
--- trunk/Source/cmake/GtkDoc.cmake 2020-03-21 14:25:09 UTC (rev 258807)
+++ trunk/Source/cmake/GtkDoc.cmake 2020-03-21 15:22:05 UTC (rev 258808)
@@ -4,7 +4,7 @@
add_custom_command(
OUTPUT "${CMAKE_BINARY_DIR}/${_stamp_name}"
DEPENDS ${DocumentationDependencies}
- COMMAND ${CMAKE_COMMAND} -E env "CC=${CMAKE_C_COMPILER}" "CFLAGS=${CMAKE_C_FLAGS} -Wno-unused-parameter" "LDFLAGS=${CMAKE_EXE_LINKER_FLAGS}" ${CMAKE_SOURCE_DIR}/Tools/gtkdoc/generate-gtkdoc ${_extra_args}
+ COMMAND ${CMAKE_COMMAND} -E env "CC=${CMAKE_C_COMPILER}" "CFLAGS=${CMAKE_C_FLAGS} -Wno-unused-parameter" "LDFLAGS=${CMAKE_EXE_LINKER_FLAGS}" ${PYTHON_EXECUTABLE} ${CMAKE_SOURCE_DIR}/Tools/gtkdoc/generate-gtkdoc ${_extra_args}
COMMAND touch ${_stamp_name}
WORKING_DIRECTORY "${CMAKE_BINARY_DIR}"
VERBATIM
Modified: trunk/Tools/ChangeLog (258807 => 258808)
--- trunk/Tools/ChangeLog 2020-03-21 14:25:09 UTC (rev 258807)
+++ trunk/Tools/ChangeLog 2020-03-21 15:22:05 UTC (rev 258808)
@@ -1,3 +1,16 @@
+2020-03-21 Michael Catanzaro <[email protected]>
+
+ [GTK] Use ${PYTHON_EXECUTABLE} to run generate-gtkdoc
+ https://bugs.webkit.org/show_bug.cgi?id=208970
+
+ Reviewed by Konstantin Tokarev.
+
+ We are allowed to use /usr/bin/env in this script because it's not installed (so not
+ packaged). Therefore we can make the shebang compatible with FreeBSD in this particularl
+ case.
+
+ * gtkdoc/generate-gtkdoc:
+
2020-03-20 Jonathan Bedard <[email protected]>
run-webkit-tests: Report MacCatalyst as a unique platform
Modified: trunk/Tools/gtkdoc/generate-gtkdoc (258807 => 258808)
--- trunk/Tools/gtkdoc/generate-gtkdoc 2020-03-21 14:25:09 UTC (rev 258807)
+++ trunk/Tools/gtkdoc/generate-gtkdoc 2020-03-21 15:22:05 UTC (rev 258808)
@@ -1,4 +1,4 @@
-#!/usr/bin/python3
+#!/usr/bin/env python3
# Copyright (C) 2011 Igalia S.L.
#
# This library is free software; you can redistribute it and/or
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
