Title: [258815] trunk/Source/ThirdParty/ANGLE
- Revision
- 258815
- Author
- [email protected]
- Date
- 2020-03-21 19:57:36 -0700 (Sat, 21 Mar 2020)
Log Message
Set INSTALLHDRS_SCRIPT_PHASE in ANGLE builds
https://bugs.webkit.org/show_bug.cgi?id=209384
<rdar://problem/59513380>
Reviewed by Dan Bernstein.
Production ANGLE builds are technically non-compliant. During the
installhdrs build action, ANGLE headers are exported but are not
post-processed. This differs from the install build action, where the
exported headers *are* post-processed. The headers need to be treated
identically under both actions. The post-processing is enabled by
setting the INSTALLHDRS_SCRIPT_PHASE build setting to YES. Most other
WebKit projects already set this setting (see, for example,
https://trac.webkit.org/changeset/155787,
https://trac.webkit.org/changeset/110327, and
https://trac.webkit.org/changeset/41417).
* Configurations/ANGLE.xcconfig:
Modified Paths
Diff
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (258814 => 258815)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2020-03-22 01:31:25 UTC (rev 258814)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2020-03-22 02:57:36 UTC (rev 258815)
@@ -1,3 +1,24 @@
+2020-03-21 Keith Rollin <[email protected]>
+
+ Set INSTALLHDRS_SCRIPT_PHASE in ANGLE builds
+ https://bugs.webkit.org/show_bug.cgi?id=209384
+ <rdar://problem/59513380>
+
+ Reviewed by Dan Bernstein.
+
+ Production ANGLE builds are technically non-compliant. During the
+ installhdrs build action, ANGLE headers are exported but are not
+ post-processed. This differs from the install build action, where the
+ exported headers *are* post-processed. The headers need to be treated
+ identically under both actions. The post-processing is enabled by
+ setting the INSTALLHDRS_SCRIPT_PHASE build setting to YES. Most other
+ WebKit projects already set this setting (see, for example,
+ https://trac.webkit.org/changeset/155787,
+ https://trac.webkit.org/changeset/110327, and
+ https://trac.webkit.org/changeset/41417).
+
+ * Configurations/ANGLE.xcconfig:
+
2020-03-15 Michael Catanzaro <[email protected]>
[ANGLE] Source/ThirdParty/ANGLE/src/common/utilities.cpp:10: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
Modified: trunk/Source/ThirdParty/ANGLE/Configurations/ANGLE.xcconfig (258814 => 258815)
--- trunk/Source/ThirdParty/ANGLE/Configurations/ANGLE.xcconfig 2020-03-22 01:31:25 UTC (rev 258814)
+++ trunk/Source/ThirdParty/ANGLE/Configurations/ANGLE.xcconfig 2020-03-22 02:57:36 UTC (rev 258815)
@@ -3,6 +3,7 @@
PRODUCT_NAME = ANGLE;
+INSTALLHDRS_SCRIPT_PHASE = YES;
APPLY_RULES_IN_COPY_HEADERS = $(USE_NEW_BUILD_SYSTEM);
CLANG_WARN_BOOL_CONVERSION = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
