Title: [258858] trunk/Source
- Revision
- 258858
- Author
- [email protected]
- Date
- 2020-03-23 10:50:08 -0700 (Mon, 23 Mar 2020)
Log Message
DocumentTimeline / CSSTransition objects are leaking on CNN.com
https://bugs.webkit.org/show_bug.cgi?id=208069
<rdar://problem/59680143>
Reviewed by Darin Adler.
Integrating post-commit review feedback from Darin.
Source/WebCore:
* testing/Internals.cpp:
(WebCore::Internals::animationWithIdExists const):
Source/WTF:
* wtf/ListHashSet.h:
(WTF::=):
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (258857 => 258858)
--- trunk/Source/WTF/ChangeLog 2020-03-23 17:34:43 UTC (rev 258857)
+++ trunk/Source/WTF/ChangeLog 2020-03-23 17:50:08 UTC (rev 258858)
@@ -1,3 +1,16 @@
+2020-03-23 Antoine Quint <[email protected]>
+
+ DocumentTimeline / CSSTransition objects are leaking on CNN.com
+ https://bugs.webkit.org/show_bug.cgi?id=208069
+ <rdar://problem/59680143>
+
+ Reviewed by Darin Adler.
+
+ Integrating post-commit review feedback from Darin.
+
+ * wtf/ListHashSet.h:
+ (WTF::=):
+
2020-03-23 Michael Catanzaro <[email protected]>
REGRESSION(r249808): [GTK] Crash in JSC Config::permanentlyFreeze() on architecture ppc64el
Modified: trunk/Source/WTF/wtf/ListHashSet.h (258857 => 258858)
--- trunk/Source/WTF/wtf/ListHashSet.h 2020-03-23 17:34:43 UTC (rev 258857)
+++ trunk/Source/WTF/wtf/ListHashSet.h 2020-03-23 17:50:08 UTC (rev 258858)
@@ -351,8 +351,8 @@
template<typename T, typename U>
inline ListHashSet<T, U>& ListHashSet<T, U>::operator=(ListHashSet&& other)
{
- ListHashSet tmp(WTFMove(other));
- swap(tmp);
+ ListHashSet movedSet(WTFMove(other));
+ swap(movedSet);
return *this;
}
Modified: trunk/Source/WebCore/ChangeLog (258857 => 258858)
--- trunk/Source/WebCore/ChangeLog 2020-03-23 17:34:43 UTC (rev 258857)
+++ trunk/Source/WebCore/ChangeLog 2020-03-23 17:50:08 UTC (rev 258858)
@@ -1,3 +1,16 @@
+2020-03-23 Antoine Quint <[email protected]>
+
+ DocumentTimeline / CSSTransition objects are leaking on CNN.com
+ https://bugs.webkit.org/show_bug.cgi?id=208069
+ <rdar://problem/59680143>
+
+ Reviewed by Darin Adler.
+
+ Integrating post-commit review feedback from Darin.
+
+ * testing/Internals.cpp:
+ (WebCore::Internals::animationWithIdExists const):
+
2020-03-23 Chris Dumez <[email protected]>
Port window.postMessage to the HTML event loop
Modified: trunk/Source/WebCore/testing/Internals.cpp (258857 => 258858)
--- trunk/Source/WebCore/testing/Internals.cpp 2020-03-23 17:34:43 UTC (rev 258857)
+++ trunk/Source/WebCore/testing/Internals.cpp 2020-03-23 17:50:08 UTC (rev 258858)
@@ -1039,7 +1039,7 @@
bool Internals::animationWithIdExists(const String& id) const
{
for (auto* animation : WebAnimation::instances()) {
- if (animation && animation->id() == id)
+ if (animation->id() == id)
return true;
}
return false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
