Title: [258913] trunk
- Revision
- 258913
- Author
- [email protected]
- Date
- 2020-03-24 09:47:07 -0700 (Tue, 24 Mar 2020)
Log Message
[iOS+macOS Debug] ASSERTION FAILED: m_effects.isEmpty() in WebCore::KeyframeEffectStack::~KeyframeEffectStack()
https://bugs.webkit.org/show_bug.cgi?id=208718
<rdar://problem/59956433>
Patch by Antoine Quint <[email protected]> on 2020-03-24
Reviewed by Darin Adler.
Source/WebCore:
This assertion is only valid in the case where elements with relevant animations are still alive when the document is
torn down. However, it's fine to have an Element be destroyed with a relevant animation while its document is still alive.
* animation/KeyframeEffectStack.cpp:
(WebCore::KeyframeEffectStack::~KeyframeEffectStack):
LayoutTests:
* platform/ios-wk2/TestExpectations:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (258912 => 258913)
--- trunk/LayoutTests/ChangeLog 2020-03-24 16:40:21 UTC (rev 258912)
+++ trunk/LayoutTests/ChangeLog 2020-03-24 16:47:07 UTC (rev 258913)
@@ -1,3 +1,14 @@
+2020-03-24 Antoine Quint <[email protected]>
+
+ [iOS+macOS Debug] ASSERTION FAILED: m_effects.isEmpty() in WebCore::KeyframeEffectStack::~KeyframeEffectStack()
+ https://bugs.webkit.org/show_bug.cgi?id=208718
+ <rdar://problem/59956433>
+
+ Reviewed by Darin Adler.
+
+ * platform/ios-wk2/TestExpectations:
+ * platform/mac/TestExpectations:
+
2020-03-24 Jacob Uphoff <[email protected]>
[ macOS wk1 ] webgl/2.0.0/conformance/attribs/gl-vertexattribpointer.html is flaky timing out
Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (258912 => 258913)
--- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-03-24 16:40:21 UTC (rev 258912)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-03-24 16:47:07 UTC (rev 258913)
@@ -1425,8 +1425,6 @@
webkit.org/b/208662 http/tests/security/contentSecurityPolicy/_javascript_-url-blocked-by-default-src-star.html [ Pass Failure ]
-webkit.org/b/208718 [ Debug ] imported/w3c/web-platform-tests/web-animations/interfaces/Animation/commitStyles.html [ Pass Crash ]
-
webkit.org/b/208601 fast/backgrounds/hidpi-bitmap-background-on-subpixel-position.html [ Pass ImageOnlyFailure ]
webkit.org/b/208739 http/tests/resourceLoadStatistics/third-party-cookie-blocking-ephemeral.html [ Pass Timeout ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (258912 => 258913)
--- trunk/LayoutTests/platform/mac/TestExpectations 2020-03-24 16:40:21 UTC (rev 258912)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2020-03-24 16:47:07 UTC (rev 258913)
@@ -2005,8 +2005,6 @@
webkit.org/b/208574 mathml/scripts-removeChild.html [ Pass ImageOnlyFailure ]
-webkit.org/b/208718 [ Debug ] imported/w3c/web-platform-tests/web-animations/interfaces/Animation/commitStyles.html [ Pass Crash ]
-
webkit.org/b/208722 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/seeking/seek-to-max-value.htm [ Pass Failure ]
webkit.org/b/208817 fast/canvas/webgl/simulated-vertexAttrib0-invalid-indicies.html [ Skip ]
Modified: trunk/Source/WebCore/ChangeLog (258912 => 258913)
--- trunk/Source/WebCore/ChangeLog 2020-03-24 16:40:21 UTC (rev 258912)
+++ trunk/Source/WebCore/ChangeLog 2020-03-24 16:47:07 UTC (rev 258913)
@@ -1,3 +1,17 @@
+2020-03-24 Antoine Quint <[email protected]>
+
+ [iOS+macOS Debug] ASSERTION FAILED: m_effects.isEmpty() in WebCore::KeyframeEffectStack::~KeyframeEffectStack()
+ https://bugs.webkit.org/show_bug.cgi?id=208718
+ <rdar://problem/59956433>
+
+ Reviewed by Darin Adler.
+
+ This assertion is only valid in the case where elements with relevant animations are still alive when the document is
+ torn down. However, it's fine to have an Element be destroyed with a relevant animation while its document is still alive.
+
+ * animation/KeyframeEffectStack.cpp:
+ (WebCore::KeyframeEffectStack::~KeyframeEffectStack):
+
2020-03-23 Simon Fraser <[email protected]>
Safari jetsams with repeated drawImage/getImageData
Modified: trunk/Source/WebCore/animation/KeyframeEffectStack.cpp (258912 => 258913)
--- trunk/Source/WebCore/animation/KeyframeEffectStack.cpp 2020-03-24 16:40:21 UTC (rev 258912)
+++ trunk/Source/WebCore/animation/KeyframeEffectStack.cpp 2020-03-24 16:47:07 UTC (rev 258913)
@@ -40,7 +40,6 @@
KeyframeEffectStack::~KeyframeEffectStack()
{
- ASSERT(m_effects.isEmpty());
}
bool KeyframeEffectStack::addEffect(KeyframeEffect& effect)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
