Title: [258916] trunk/Source/WebCore
- Revision
- 258916
- Author
- [email protected]
- Date
- 2020-03-24 10:20:33 -0700 (Tue, 24 Mar 2020)
Log Message
[Web Animations] Clean timeline headers up
https://bugs.webkit.org/show_bug.cgi?id=209482
Patch by Antoine Quint <[email protected]> on 2020-03-24
Reviewed by Antti Koivisto.
The AnimationTimeline::removeAnimationsForElement() method isn't used and DocumentTimeline::applyPendingAcceleratedAnimations()
is only used internally in DocumentTimeline so it can be made private.
* animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::removeAnimationsForElement): Deleted.
* animation/AnimationTimeline.h:
* animation/DocumentTimeline.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (258915 => 258916)
--- trunk/Source/WebCore/ChangeLog 2020-03-24 17:14:43 UTC (rev 258915)
+++ trunk/Source/WebCore/ChangeLog 2020-03-24 17:20:33 UTC (rev 258916)
@@ -1,5 +1,20 @@
2020-03-24 Antoine Quint <[email protected]>
+ [Web Animations] Clean timeline headers up
+ https://bugs.webkit.org/show_bug.cgi?id=209482
+
+ Reviewed by Antti Koivisto.
+
+ The AnimationTimeline::removeAnimationsForElement() method isn't used and DocumentTimeline::applyPendingAcceleratedAnimations()
+ is only used internally in DocumentTimeline so it can be made private.
+
+ * animation/AnimationTimeline.cpp:
+ (WebCore::AnimationTimeline::removeAnimationsForElement): Deleted.
+ * animation/AnimationTimeline.h:
+ * animation/DocumentTimeline.h:
+
+2020-03-24 Antoine Quint <[email protected]>
+
[iOS+macOS Debug] ASSERTION FAILED: m_effects.isEmpty() in WebCore::KeyframeEffectStack::~KeyframeEffectStack()
https://bugs.webkit.org/show_bug.cgi?id=208718
<rdar://problem/59956433>
Modified: trunk/Source/WebCore/animation/AnimationTimeline.cpp (258915 => 258916)
--- trunk/Source/WebCore/animation/AnimationTimeline.cpp 2020-03-24 17:14:43 UTC (rev 258915)
+++ trunk/Source/WebCore/animation/AnimationTimeline.cpp 2020-03-24 17:20:33 UTC (rev 258916)
@@ -193,12 +193,6 @@
cancelDeclarativeAnimationsForElement(element, WebAnimation::Silently::Yes);
}
-void AnimationTimeline::removeAnimationsForElement(Element& element)
-{
- for (auto& animation : animationsForElement(element))
- animation->remove();
-}
-
void AnimationTimeline::willChangeRendererForElement(Element& element)
{
for (auto& animation : animationsForElement(element))
Modified: trunk/Source/WebCore/animation/AnimationTimeline.h (258915 => 258916)
--- trunk/Source/WebCore/animation/AnimationTimeline.h 2020-03-24 17:14:43 UTC (rev 258915)
+++ trunk/Source/WebCore/animation/AnimationTimeline.h 2020-03-24 17:20:33 UTC (rev 258916)
@@ -61,7 +61,6 @@
Vector<RefPtr<WebAnimation>> animationsForElement(Element&, Ordering ordering = Ordering::Unsorted) const;
void elementWasRemoved(Element&);
- void removeAnimationsForElement(Element&);
void willChangeRendererForElement(Element&);
void cancelDeclarativeAnimationsForElement(Element&, WebAnimation::Silently);
Modified: trunk/Source/WebCore/animation/DocumentTimeline.h (258915 => 258916)
--- trunk/Source/WebCore/animation/DocumentTimeline.h 2020-03-24 17:14:43 UTC (rev 258915)
+++ trunk/Source/WebCore/animation/DocumentTimeline.h 2020-03-24 17:20:33 UTC (rev 258916)
@@ -66,7 +66,6 @@
bool isRunningAnimationOnRenderer(RenderElement&, CSSPropertyID) const;
bool isRunningAcceleratedAnimationOnRenderer(RenderElement&, CSSPropertyID) const;
void animationAcceleratedRunningStateDidChange(WebAnimation&);
- void applyPendingAcceleratedAnimations();
bool runningAnimationsForElementAreAllAccelerated(Element&) const;
void detachFromDocument();
@@ -89,6 +88,7 @@
DocumentTimeline(Document&, Seconds);
DOMHighResTimeStamp liveCurrentTime() const;
+ void applyPendingAcceleratedAnimations();
void cacheCurrentTime(DOMHighResTimeStamp);
void maybeClearCachedCurrentTime();
void scheduleInvalidationTaskIfNeeded();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
