Title: [258927] trunk/LayoutTests
Revision
258927
Author
[email protected]
Date
2020-03-24 12:19:30 -0700 (Tue, 24 Mar 2020)

Log Message

[ macOS iOS ] fast/parser/parser-yield-timing.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=207559

Reviewed by Geoffrey Garen.

Delete the test which was added in r120108 to test the yielding time of the parser.

This test has been flaky everywhere, and there isn't a way to test these kinds of timing
reliably in our layout test infrastructure.

* fast/parser/parser-yield-timing-expected.txt: Removed.
* fast/parser/parser-yield-timing.html: Removed.
* platform/gtk/TestExpectations:
* platform/ios-wk2/TestExpectations:
* platform/mac-wk1/TestExpectations:

Modified Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (258926 => 258927)


--- trunk/LayoutTests/ChangeLog	2020-03-24 19:03:11 UTC (rev 258926)
+++ trunk/LayoutTests/ChangeLog	2020-03-24 19:19:30 UTC (rev 258927)
@@ -1,3 +1,21 @@
+2020-03-23  Ryosuke Niwa  <[email protected]>
+
+        [ macOS iOS ] fast/parser/parser-yield-timing.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=207559
+
+        Reviewed by Geoffrey Garen.
+
+        Delete the test which was added in r120108 to test the yielding time of the parser.
+
+        This test has been flaky everywhere, and there isn't a way to test these kinds of timing
+        reliably in our layout test infrastructure.
+
+        * fast/parser/parser-yield-timing-expected.txt: Removed.
+        * fast/parser/parser-yield-timing.html: Removed.
+        * platform/gtk/TestExpectations:
+        * platform/ios-wk2/TestExpectations:
+        * platform/mac-wk1/TestExpectations:
+
 2020-03-24  Jason Lawrence  <[email protected]>
 
         [ iOS and Mac Debug ] fast/canvas/webgl/simulated-vertexAttrib0-invalid-indicies.html is flaky timing out and crashing.

Deleted: trunk/LayoutTests/fast/parser/parser-yield-timing-expected.txt (258926 => 258927)


--- trunk/LayoutTests/fast/parser/parser-yield-timing-expected.txt	2020-03-24 19:03:11 UTC (rev 258926)
+++ trunk/LayoutTests/fast/parser/parser-yield-timing-expected.txt	2020-03-24 19:19:30 UTC (rev 258927)
@@ -1,12 +0,0 @@
-Runs 3 separate 1 second <script> blocks with a setTimeout schedule before each. The execution time of the setTimeout is when the HTML yielded to the event loop. The yields also represent painting opportunities. We want the parser to yield every 0.5 seconds once it has seen a script.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS new Date().getTime() - startTime is within 400 of 1000
-PASS new Date().getTime() - startTime is within 400 of 2000
-PASS new Date().getTime() - startTime is within 400 of 3000
-PASS successfullyParsed is true
-
-TEST COMPLETE
-

Deleted: trunk/LayoutTests/fast/parser/parser-yield-timing.html (258926 => 258927)


--- trunk/LayoutTests/fast/parser/parser-yield-timing.html	2020-03-24 19:03:11 UTC (rev 258926)
+++ trunk/LayoutTests/fast/parser/parser-yield-timing.html	2020-03-24 19:19:30 UTC (rev 258927)
@@ -1,52 +0,0 @@
-<html>
-
-  <head>
-    <script type="text/_javascript_" src=""
-    <script>
-      window.jsTestIsAsync = true;
-
-      description("Runs 3 separate 1 second &lt;script&gt; blocks with a setTimeout schedule before each. The execution time of the setTimeout is when the HTML yielded to the event loop. The yields also represent painting opportunities. We want the parser to yield every 0.5 seconds once it has seen a script.");
-
-      var startTime = new Date().getTime();
-      var tolerance = 400; // 400 ms
-
-      function expectElapsedTime(expectedTime) {
-        shouldBeCloseTo("new Date().getTime() - startTime", expectedTime, tolerance);
-      }
-
-      function sleep(ms) {
-        var endTime = (new Date().getTime()) + ms;
-        while ((new Date().getTime()) < endTime);
-      }
-    </script>
-  </head>
-
-  <body>
-    <p></p>
-
-    <script>
-      setTimeout(function() { expectElapsedTime(1000) }, 0);
-    </script>
-    <script> 
-      sleep(1000);
-    </script>
-    <script>
-      setTimeout(function() { expectElapsedTime(2000) }, 0);
-    </script>
-    <script> 
-      sleep(1000);
-    </script>
-    <script> 
-      setTimeout(function() { 
-        expectElapsedTime(3000);
-
-        finishJSTest();
-      }, 0);
-    </script>
-    <script> 
-      sleep(1000);
-    </script>
-    <script type="text/_javascript_" src=""
-  </body>
-</html>
-

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (258926 => 258927)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2020-03-24 19:03:11 UTC (rev 258926)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2020-03-24 19:19:30 UTC (rev 258927)
@@ -1606,8 +1606,6 @@
 
 webkit.org/b/116976 media/video-played-collapse.html [ Failure Pass Crash ]
 
-webkit.org/b/103443 fast/parser/parser-yield-timing.html [ Failure Pass ]
-
 webkit.org/b/119009 http/tests/cache/subresource-failover-to-network.html [ Failure Pass ]
 
 webkit.org/b/119040 perf/nested-combined-selectors.html [ Failure Pass ]

Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (258926 => 258927)


--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-03-24 19:03:11 UTC (rev 258926)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-03-24 19:19:30 UTC (rev 258927)
@@ -744,7 +744,6 @@
 
 # Flaky tests:
 fast/dom/inline-event-attributes-release.html [ Failure Pass ]
-fast/parser/parser-yield-timing.html [ Failure Pass ]
 fast/text/align-center-rtl-spill.html [ Failure Pass ]
 fast/text/atsui-kerning-and-ligatures.html [ Failure Pass ]
 fast/text/atsui-multiple-renderers.html [ Failure Pass ]
@@ -1353,8 +1352,6 @@
 
 webkit.org/b/190852 imported/w3c/web-platform-tests/service-workers/service-worker/redirected-response.https.html [ Pass Failure ]
 
-webkit.org/b/207559 fast/parser/parser-yield-timing.html [ Pass Failure ]
-
 webkit.org/b/207583 http/wpt/beacon/cors/crossorigin-arraybufferview-no-preflight.html [ Pass Failure ]
 
 webkit.org/b/207596 fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall.html [ Pass Failure ]

Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (258926 => 258927)


--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-03-24 19:03:11 UTC (rev 258926)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-03-24 19:19:30 UTC (rev 258927)
@@ -908,8 +908,6 @@
 
 webkit.org/b/207470 [ Debug ] imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_colno.htm [ Pass Failure ]
 
-webkit.org/b/207559 fast/parser/parser-yield-timing.html [ Pass Failure ]
-
 # This seems to be indicative of a CFNetwork bug.
 webkit.org/b/207895 http/tests/cookies/document-cookie-during-iframe-parsing.html [ Pass Failure ]
 webkit.org/b/208165 http/tests/cookies/document-cookie-after-showModalDialog.html [ Pass Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to