Title: [258941] trunk/Source/WebKit
- Revision
- 258941
- Author
- dba...@webkit.org
- Date
- 2020-03-24 14:56:27 -0700 (Tue, 24 Mar 2020)
Log Message
Use SimpleRange in characterRectsForRange()
https://bugs.webkit.org/show_bug.cgi?id=209495
Reviewed by Darin Adler.
The function characterRectsForRange() is capable of working correctly with a SimpleRange
instead of a Range. Callers currently pass a Range. So, there is still a conversion, but
maybe someday they can pass a SimpleRange. This change is towards that future.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::requestDocumentEditingContext):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (258940 => 258941)
--- trunk/Source/WebKit/ChangeLog 2020-03-24 21:40:50 UTC (rev 258940)
+++ trunk/Source/WebKit/ChangeLog 2020-03-24 21:56:27 UTC (rev 258941)
@@ -1,3 +1,17 @@
+2020-03-24 Daniel Bates <daba...@apple.com>
+
+ Use SimpleRange in characterRectsForRange()
+ https://bugs.webkit.org/show_bug.cgi?id=209495
+
+ Reviewed by Darin Adler.
+
+ The function characterRectsForRange() is capable of working correctly with a SimpleRange
+ instead of a Range. Callers currently pass a Range. So, there is still a conversion, but
+ maybe someday they can pass a SimpleRange. This change is towards that future.
+
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::WebPage::requestDocumentEditingContext):
+
2020-03-24 Chris Dumez <cdu...@apple.com>
Unreviewed, reverting r258928.
Modified: trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (258940 => 258941)
--- trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2020-03-24 21:40:50 UTC (rev 258940)
+++ trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2020-03-24 21:56:27 UTC (rev 258941)
@@ -4236,7 +4236,7 @@
context.selectedRangeInMarkedText.length = [context.selectedText.string length];
}
- auto characterRectsForRange = [](const Range& range, unsigned startOffset) {
+ auto characterRectsForRange = [](const SimpleRange& range, unsigned startOffset) {
Vector<DocumentEditingContext::TextRectAndRange> rects;
CharacterIterator iterator { range };
unsigned offsetSoFar = startOffset;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
