Title: [258957] trunk/Source/WebCore
- Revision
- 258957
- Author
- commit-qu...@webkit.org
- Date
- 2020-03-24 16:33:58 -0700 (Tue, 24 Mar 2020)
Log Message
Add console message when legacy TLS is used
https://bugs.webkit.org/show_bug.cgi?id=209444
Patch by Alex Christensen <achristen...@webkit.org> on 2020-03-24
Reviewed by Darin Adler.
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didReceiveResponse):
Indent less, add host to inspector, add release logging without host.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (258956 => 258957)
--- trunk/Source/WebCore/ChangeLog 2020-03-24 23:27:48 UTC (rev 258956)
+++ trunk/Source/WebCore/ChangeLog 2020-03-24 23:33:58 UTC (rev 258957)
@@ -1,3 +1,14 @@
+2020-03-24 Alex Christensen <achristen...@webkit.org>
+
+ Add console message when legacy TLS is used
+ https://bugs.webkit.org/show_bug.cgi?id=209444
+
+ Reviewed by Darin Adler.
+
+ * loader/ResourceLoader.cpp:
+ (WebCore::ResourceLoader::didReceiveResponse):
+ Indent less, add host to inspector, add release logging without host.
+
2020-03-24 Antoine Quint <grao...@apple.com>
[Web Animations] Clean timeline headers up
Modified: trunk/Source/WebCore/loader/ResourceLoader.cpp (258956 => 258957)
--- trunk/Source/WebCore/loader/ResourceLoader.cpp 2020-03-24 23:27:48 UTC (rev 258956)
+++ trunk/Source/WebCore/loader/ResourceLoader.cpp 2020-03-24 23:33:58 UTC (rev 258957)
@@ -501,14 +501,14 @@
// anything including possibly derefing this; one example of this is Radar 3266216.
Ref<ResourceLoader> protectedThis(*this);
- if (r.usedLegacyTLS()) {
- if (m_frame) {
- if (auto* document = m_frame->document()) {
- if (!document->usedLegacyTLS()) {
- if (auto* page = document->page())
- page->console().addMessage(MessageSource::Network, MessageLevel::Warning, "Loaded resource using TLS 1.0 or 1.1, which are deprecated protocols that will be removed. Please use TLS 1.2 or newer instead."_s, 0, document);
- document->setUsedLegacyTLS(true);
+ if (r.usedLegacyTLS() && m_frame) {
+ if (auto* document = m_frame->document()) {
+ if (!document->usedLegacyTLS()) {
+ if (auto* page = document->page()) {
+ RELEASE_LOG_IF_ALLOWED("usedLegacyTLS:");
+ page->console().addMessage(MessageSource::Network, MessageLevel::Warning, makeString("Loaded resource from ", r.url().host(), " using TLS 1.0 or 1.1, which are deprecated protocols that will be removed. Please use TLS 1.2 or newer instead."), 0, document);
}
+ document->setUsedLegacyTLS(true);
}
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
