Title: [258962] trunk/Source/WebCore
- Revision
- 258962
- Author
- [email protected]
- Date
- 2020-03-24 17:18:10 -0700 (Tue, 24 Mar 2020)
Log Message
REGRESSION(r258314): Leak in MediaPlayerPrivateMediaSourceAVFObjC::updateLastPixelBuffer()
https://bugs.webkit.org/show_bug.cgi?id=209519
Reviewed by Eric Carlson.
Obey the "copy" rule and adopt the results of -copyPixelBufferForSourceTime:sourceTimeForDisplay:.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::updateLastPixelBuffer):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (258961 => 258962)
--- trunk/Source/WebCore/ChangeLog 2020-03-25 00:03:19 UTC (rev 258961)
+++ trunk/Source/WebCore/ChangeLog 2020-03-25 00:18:10 UTC (rev 258962)
@@ -1,3 +1,15 @@
+2020-03-24 Jer Noble <[email protected]>
+
+ REGRESSION(r258314): Leak in MediaPlayerPrivateMediaSourceAVFObjC::updateLastPixelBuffer()
+ https://bugs.webkit.org/show_bug.cgi?id=209519
+
+ Reviewed by Eric Carlson.
+
+ Obey the "copy" rule and adopt the results of -copyPixelBufferForSourceTime:sourceTimeForDisplay:.
+
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
+ (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::updateLastPixelBuffer):
+
2020-03-24 Jiewen Tan <[email protected]>
[WebAuthn] Customize a bit more on the macOS LocalAuthentication prompt
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm (258961 => 258962)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm 2020-03-25 00:03:19 UTC (rev 258961)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm 2020-03-25 00:18:10 UTC (rev 258962)
@@ -588,7 +588,7 @@
#if HAVE(AVSAMPLEBUFFERVIDEOOUTPUT)
if (m_videoOutput) {
CMTime outputTime;
- if (auto pixelBuffer = [m_videoOutput copyPixelBufferForSourceTime:toCMTime(currentMediaTime()) sourceTimeForDisplay:&outputTime]) {
+ if (auto pixelBuffer = adoptCF([m_videoOutput copyPixelBufferForSourceTime:toCMTime(currentMediaTime()) sourceTimeForDisplay:&outputTime])) {
INFO_LOG(LOGIDENTIFIER, "new pixelbuffer found for time ", toMediaTime(outputTime));
m_lastPixelBuffer = WTFMove(pixelBuffer);
return true;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
