Title: [104014] trunk
Revision
104014
Author
[email protected]
Date
2012-01-03 23:03:47 -0800 (Tue, 03 Jan 2012)

Log Message

Fix assert when foster parenting self-closing elements
https://bugs.webkit.org/show_bug.cgi?id=75527

Unreviewed.

Source/WebCore:


* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::fosterParent):
    - We can't execute this task immediately because the code for
      self-closing elements wants to set the self-closing flag.
      Instead, we queue the task.

LayoutTests:

Add a test case that used to case an assert.


* html5lib/resources/webkit02.dat:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (104013 => 104014)


--- trunk/LayoutTests/ChangeLog	2012-01-04 06:43:32 UTC (rev 104013)
+++ trunk/LayoutTests/ChangeLog	2012-01-04 07:03:47 UTC (rev 104014)
@@ -1,3 +1,14 @@
+2012-01-03  Adam Barth  <[email protected]>
+
+        Fix assert when foster parenting self-closing elements
+        https://bugs.webkit.org/show_bug.cgi?id=75527
+
+        Unreviewed.
+
+        Add a test case that used to case an assert.
+
+        * html5lib/resources/webkit02.dat:
+
 2012-01-03  Jochen Eisinger  <[email protected]>
 
         Replace clearLocalStorage.js with localStorage.clear() now that it's implemented

Modified: trunk/LayoutTests/html5lib/resources/webkit02.dat (104013 => 104014)


--- trunk/LayoutTests/html5lib/resources/webkit02.dat	2012-01-04 06:43:32 UTC (rev 104013)
+++ trunk/LayoutTests/html5lib/resources/webkit02.dat	2012-01-04 07:03:47 UTC (rev 104014)
@@ -104,6 +104,16 @@
 |       "test"
 
 #data
+<table><input>
+#errors
+#document
+| <html>
+|   <head>
+|   <body>
+|     <input>
+|     <table>
+
+#data
 <b><em><dcell><postfield><postfield><postfield><postfield><missing_glyph><missing_glyph><missing_glyph><missing_glyph><hkern><aside></b></em>
 #errors
 #document-fragment

Modified: trunk/Source/WebCore/ChangeLog (104013 => 104014)


--- trunk/Source/WebCore/ChangeLog	2012-01-04 06:43:32 UTC (rev 104013)
+++ trunk/Source/WebCore/ChangeLog	2012-01-04 07:03:47 UTC (rev 104014)
@@ -1,3 +1,16 @@
+2012-01-03  Adam Barth  <[email protected]>
+
+        Fix assert when foster parenting self-closing elements
+        https://bugs.webkit.org/show_bug.cgi?id=75527
+
+        Unreviewed.
+
+        * html/parser/HTMLConstructionSite.cpp:
+        (WebCore::HTMLConstructionSite::fosterParent):
+            - We can't execute this task immediately because the code for
+              self-closing elements wants to set the self-closing flag.
+              Instead, we queue the task.
+
 2012-01-03  Charles Wei  <[email protected]>
 
         [BlackBerry] Need to support credentials in the URL

Modified: trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp (104013 => 104014)


--- trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp	2012-01-04 06:43:32 UTC (rev 104013)
+++ trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp	2012-01-04 07:03:47 UTC (rev 104014)
@@ -526,7 +526,7 @@
     task.nextChild = 0;
     findFosterSite(task);
     task.child = node;
-    executeTask(task);
+    m_attachmentQueue.append(task);
 }
 
 }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to