Title: [104020] trunk
Revision
104020
Author
[email protected]
Date
2012-01-04 01:17:45 -0800 (Wed, 04 Jan 2012)

Log Message

Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting
https://bugs.webkit.org/show_bug.cgi?id=75238

Patch by Mary Wu <[email protected]> on 2012-01-04
Reviewed by Antonio Gomes.

.:

* Source/cmakeconfig.h.cmake: Modified to add a new cmakedefine ENABLE_DOWNLOAD_ATTRIBUTE.

Tools:

Add ENABLE_DOWNLOAD_ATTRIBUTE webkit feature into the build script so that
it could initiate download directly if it has the download attribute in the link
and doesn't need to open new blank page for the target="_blank". Enabling this
feature in the BlackBerry porting also prepares for later blob feature implementation.

* Scripts/build-webkit: Modified to handle ENABLE_DOWNLOAD_ATTRIBUTE. Make it default on
for the BlackBerry porting.

Modified Paths

Diff

Modified: trunk/ChangeLog (104019 => 104020)


--- trunk/ChangeLog	2012-01-04 08:48:41 UTC (rev 104019)
+++ trunk/ChangeLog	2012-01-04 09:17:45 UTC (rev 104020)
@@ -1,3 +1,12 @@
+2012-01-04  Mary Wu  <[email protected]>
+
+        Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting
+        https://bugs.webkit.org/show_bug.cgi?id=75238
+
+        Reviewed by Antonio Gomes.
+
+        * Source/cmakeconfig.h.cmake: Modified to add a new cmakedefine ENABLE_DOWNLOAD_ATTRIBUTE.
+
 2012-01-03  Tor Arne Vestbø  <[email protected]>
 
         [Qt] Clean up detection of fontconfig

Modified: trunk/Source/cmakeconfig.h.cmake (104019 => 104020)


--- trunk/Source/cmakeconfig.h.cmake	2012-01-04 08:48:41 UTC (rev 104019)
+++ trunk/Source/cmakeconfig.h.cmake	2012-01-04 09:17:45 UTC (rev 104020)
@@ -12,6 +12,7 @@
 #cmakedefine01 ENABLE_DATALIST
 #cmakedefine01 ENABLE_DATA_TRANSFER_ITEMS
 #cmakedefine01 ENABLE_DEVICE_ORIENTATION
+#cmakedefine01 ENABLE_DOWNLOAD_ATTRIBUTE
 #cmakedefine01 ENABLE_FAST_MOBILE_SCROLLING
 #cmakedefine01 ENABLE_FILTERS
 #cmakedefine01 ENABLE_FTPDIR

Modified: trunk/Tools/ChangeLog (104019 => 104020)


--- trunk/Tools/ChangeLog	2012-01-04 08:48:41 UTC (rev 104019)
+++ trunk/Tools/ChangeLog	2012-01-04 09:17:45 UTC (rev 104020)
@@ -1,3 +1,18 @@
+2012-01-04  Mary Wu  <[email protected]>
+
+        Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting
+        https://bugs.webkit.org/show_bug.cgi?id=75238
+
+        Reviewed by Antonio Gomes.
+
+        Add ENABLE_DOWNLOAD_ATTRIBUTE webkit feature into the build script so that 
+        it could initiate download directly if it has the download attribute in the link 
+        and doesn't need to open new blank page for the target="_blank". Enabling this 
+        feature in the BlackBerry porting also prepares for later blob feature implementation.
+
+        * Scripts/build-webkit: Modified to handle ENABLE_DOWNLOAD_ATTRIBUTE. Make it default on
+        for the BlackBerry porting.
+
 2012-01-03  Carlos Garcia Campos  <[email protected]>
 
         [GTK] Fix a runtime warning when hovering hyperlink auditing setting in MiniBroweser settings dialog

Modified: trunk/Tools/Scripts/build-webkit (104019 => 104020)


--- trunk/Tools/Scripts/build-webkit	2012-01-04 08:48:41 UTC (rev 104019)
+++ trunk/Tools/Scripts/build-webkit	2012-01-04 09:17:45 UTC (rev 104020)
@@ -83,6 +83,7 @@
     $detailsSupport,
     $deviceOrientationSupport,
     $directoryUploadSupport,
+    $downloadAttributeSupport,
     $fileSystemSupport,
     $filtersSupport,
     $fullscreenAPISupport,
@@ -138,6 +139,9 @@
     { option => "request-animation-frame", desc => "Toggle requestAnimationFrame support",
       define => "ENABLE_REQUEST_ANIMATION_FRAME", default => (isAppleMacWebKit()), value => \$requestAnimationFrameSupport },
 
+    { option => "download-attribute", desc => "Toggle download attribute support",
+      define => "ENABLE_DOWNLOAD_ATTRIBUTE", default => isBlackBerry(), value =>\$downloadAttributeSupport },
+
     { option => "3d-canvas", desc => "Toggle 3D canvas (WebGL) support",
       define => "ENABLE_WEBGL", default => (isAppleMacWebKit() && !isLeopard()), value => \$threeDCanvasSupport },
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to