Title: [259134] trunk/Source/WTF
- Revision
- 259134
- Author
- [email protected]
- Date
- 2020-03-27 12:48:03 -0700 (Fri, 27 Mar 2020)
Log Message
REGRESSION(r258857): Broke aarch64 JSCOnly CI
https://bugs.webkit.org/show_bug.cgi?id=209670
Patch by Michael Catanzaro <[email protected]> on 2020-03-27
Reviewed by Carlos Alberto Lopez Perez.
Change aarch64 to use 4 KB rather than 64 KB as the ceiling on page size.
This change is definitely incorrect, because it will break our internal aarch64 CI that uses
64 KB pages. But maybe it will fix the public aarch64 CI bot that is using 4 KB pages?
Further investigation is required, because 64 KB should have been a safe value for all
platforms, but first step is to commit this and see what happens.
* wtf/PageBlock.h:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (259133 => 259134)
--- trunk/Source/WTF/ChangeLog 2020-03-27 19:43:36 UTC (rev 259133)
+++ trunk/Source/WTF/ChangeLog 2020-03-27 19:48:03 UTC (rev 259134)
@@ -1,3 +1,19 @@
+2020-03-27 Michael Catanzaro <[email protected]>
+
+ REGRESSION(r258857): Broke aarch64 JSCOnly CI
+ https://bugs.webkit.org/show_bug.cgi?id=209670
+
+ Reviewed by Carlos Alberto Lopez Perez.
+
+ Change aarch64 to use 4 KB rather than 64 KB as the ceiling on page size.
+
+ This change is definitely incorrect, because it will break our internal aarch64 CI that uses
+ 64 KB pages. But maybe it will fix the public aarch64 CI bot that is using 4 KB pages?
+ Further investigation is required, because 64 KB should have been a safe value for all
+ platforms, but first step is to commit this and see what happens.
+
+ * wtf/PageBlock.h:
+
2020-03-26 Michael Catanzaro <[email protected]>
Fix various compiler warnings
Modified: trunk/Source/WTF/wtf/PageBlock.h (259133 => 259134)
--- trunk/Source/WTF/wtf/PageBlock.h 2020-03-27 19:43:36 UTC (rev 259133)
+++ trunk/Source/WTF/wtf/PageBlock.h 2020-03-27 19:48:03 UTC (rev 259134)
@@ -49,9 +49,9 @@
// Use 64 KiB for any unknown CPUs to be conservative.
#if OS(DARWIN) || PLATFORM(PLAYSTATION)
constexpr size_t CeilingOnPageSize = 16 * KB;
-#elif OS(WINDOWS) || CPU(MIPS) || CPU(X86) || CPU(X86_64) || CPU(ARM)
+#elif OS(WINDOWS) || CPU(MIPS) || CPU(X86) || CPU(X86_64) || CPU(ARM) || CPU(ARM64)
constexpr size_t CeilingOnPageSize = 4 * KB;
-#elif CPU(UNKNOWN) || CPU(PPC) || CPU(PPC64) || CPU(PPC64LE) || CPU(ARM64)
+#elif CPU(UNKNOWN) || CPU(PPC) || CPU(PPC64) || CPU(PPC64LE)
constexpr size_t CeilingOnPageSize = 64 * KB;
#else
#error Must set CeilingOnPageSize in PageBlock.h when adding a new CPU architecture!
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
