Title: [259166] trunk/Source/WebKit
Revision
259166
Author
[email protected]
Date
2020-03-28 19:05:40 -0700 (Sat, 28 Mar 2020)

Log Message

[iOS] Delay process suspension for a while after loading an app link
https://bugs.webkit.org/show_bug.cgi?id=209686
<rdar://problem/60888891>

Reviewed by Darin Adler.

Client apps that rely on WebKit to open app links cannot call the [WKWebView _willOpenAppLink] SPI
that was added in r259146. Instead, we need to call WebPageProxy::willOpenAppLink() in
tryInterceptNavigation() when WebKit opens the AppLink itself.

* UIProcess/Cocoa/NavigationState.mm:
(WebKit::tryInterceptNavigation):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (259165 => 259166)


--- trunk/Source/WebKit/ChangeLog	2020-03-29 00:59:22 UTC (rev 259165)
+++ trunk/Source/WebKit/ChangeLog	2020-03-29 02:05:40 UTC (rev 259166)
@@ -1,3 +1,18 @@
+2020-03-28  Chris Dumez  <[email protected]>
+
+        [iOS] Delay process suspension for a while after loading an app link
+        https://bugs.webkit.org/show_bug.cgi?id=209686
+        <rdar://problem/60888891>
+
+        Reviewed by Darin Adler.
+
+        Client apps that rely on WebKit to open app links cannot call the [WKWebView _willOpenAppLink] SPI
+        that was added in r259146. Instead, we need to call WebPageProxy::willOpenAppLink() in
+        tryInterceptNavigation() when WebKit opens the AppLink itself.
+
+        * UIProcess/Cocoa/NavigationState.mm:
+        (WebKit::tryInterceptNavigation):
+
 2020-03-28  Alex Christensen  <[email protected]>
 
         Deprecate injected bundle page group SPI

Modified: trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm (259165 => 259166)


--- trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm	2020-03-29 00:59:22 UTC (rev 259165)
+++ trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm	2020-03-29 02:05:40 UTC (rev 259166)
@@ -507,6 +507,8 @@
                 trySOAuthorization(WTFMove(navigationAction), *weakPage, WTFMove(completionHandler));
                 return;
             }
+            if (success && weakPage)
+                weakPage->willOpenAppLink();
             completionHandler(success);
         });
         [LSAppLink openWithURL:url completionHandler:[localCompletionHandler](BOOL success, NSError *) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to