Title: [259169] trunk/Source/WebInspectorUI
- Revision
- 259169
- Author
- [email protected]
- Date
- 2020-03-28 19:54:09 -0700 (Sat, 28 Mar 2020)
Log Message
Web Inspector: REGRESSION(r257759): Network: graph in Timing pane of selected resource is missing bars
https://bugs.webkit.org/show_bug.cgi?id=209525
Reviewed by Timothy Hatcher.
`WI.ResourceTimingBreakdownView` uses the same CSS classes and DOM structure as the parent
`WI.NetworkTableContentView`, relying on the styles defined there for it's own styles.
* UserInterface/Views/NetworkTableContentView.css:
(.network-table > .table li:not(.filler, .selected) .cell:not(.current-session)): Added.
(.network-table .error): Added.
(.network-table .waterfall .block): Added.
(body[dir=ltr] .network-table .waterfall .block): Added.
(body[dir=rtl] .network-table .waterfall .block): Added.
(.network-table .waterfall .block.request,): Added.
(.network-table .waterfall .block.mouse-tracking): Added.
(.network-table .waterfall .block.filler): Added.
(.network-table .waterfall .block.redirect): Added.
(.network-table .waterfall .block.queue): Added.
(.network-table .waterfall .block.dns): Added.
(.network-table .waterfall .block.connect): Added.
(.network-table .waterfall .block.secure): Added.
(.network-table .waterfall .block.request): Added.
(.network-table .waterfall .block.response): Added.
(.network-table > .table li:not(.selected) .cell:not(.current-session)): Deleted.
(.network-table > .table .error): Deleted.
(.network-table > .table .waterfall .block): Deleted.
(body[dir=ltr] .network-table > .table .waterfall .block): Deleted.
(body[dir=rtl] .network-table > .table .waterfall .block): Deleted.
(.network-table > .table .waterfall .block.request,): Deleted.
(.network-table > .table .waterfall .block.mouse-tracking): Deleted.
(.network-table > .table .waterfall .block.filler): Deleted.
(.network-table > .table .waterfall .block.redirect): Deleted.
(.network-table > .table .waterfall .block.queue): Deleted.
(.network-table > .table .waterfall .block.dns): Deleted.
(.network-table > .table .waterfall .block.connect): Deleted.
(.network-table > .table .waterfall .block.secure): Deleted.
(.network-table > .table .waterfall .block.request): Deleted.
(.network-table > .table .waterfall .block.response): Deleted.
Drive-by: the `WI.Table` filler row should not be dimmed.
* UserInterface/Views/ResourceTimingBreakdownView.css:
(.resource-timing-breakdown .waterfall .block):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (259168 => 259169)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-03-29 02:52:35 UTC (rev 259168)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-03-29 02:54:09 UTC (rev 259169)
@@ -1,3 +1,49 @@
+2020-03-28 Devin Rousso <[email protected]>
+
+ Web Inspector: REGRESSION(r257759): Network: graph in Timing pane of selected resource is missing bars
+ https://bugs.webkit.org/show_bug.cgi?id=209525
+
+ Reviewed by Timothy Hatcher.
+
+ `WI.ResourceTimingBreakdownView` uses the same CSS classes and DOM structure as the parent
+ `WI.NetworkTableContentView`, relying on the styles defined there for it's own styles.
+
+ * UserInterface/Views/NetworkTableContentView.css:
+ (.network-table > .table li:not(.filler, .selected) .cell:not(.current-session)): Added.
+ (.network-table .error): Added.
+ (.network-table .waterfall .block): Added.
+ (body[dir=ltr] .network-table .waterfall .block): Added.
+ (body[dir=rtl] .network-table .waterfall .block): Added.
+ (.network-table .waterfall .block.request,): Added.
+ (.network-table .waterfall .block.mouse-tracking): Added.
+ (.network-table .waterfall .block.filler): Added.
+ (.network-table .waterfall .block.redirect): Added.
+ (.network-table .waterfall .block.queue): Added.
+ (.network-table .waterfall .block.dns): Added.
+ (.network-table .waterfall .block.connect): Added.
+ (.network-table .waterfall .block.secure): Added.
+ (.network-table .waterfall .block.request): Added.
+ (.network-table .waterfall .block.response): Added.
+ (.network-table > .table li:not(.selected) .cell:not(.current-session)): Deleted.
+ (.network-table > .table .error): Deleted.
+ (.network-table > .table .waterfall .block): Deleted.
+ (body[dir=ltr] .network-table > .table .waterfall .block): Deleted.
+ (body[dir=rtl] .network-table > .table .waterfall .block): Deleted.
+ (.network-table > .table .waterfall .block.request,): Deleted.
+ (.network-table > .table .waterfall .block.mouse-tracking): Deleted.
+ (.network-table > .table .waterfall .block.filler): Deleted.
+ (.network-table > .table .waterfall .block.redirect): Deleted.
+ (.network-table > .table .waterfall .block.queue): Deleted.
+ (.network-table > .table .waterfall .block.dns): Deleted.
+ (.network-table > .table .waterfall .block.connect): Deleted.
+ (.network-table > .table .waterfall .block.secure): Deleted.
+ (.network-table > .table .waterfall .block.request): Deleted.
+ (.network-table > .table .waterfall .block.response): Deleted.
+ Drive-by: the `WI.Table` filler row should not be dimmed.
+
+ * UserInterface/Views/ResourceTimingBreakdownView.css:
+ (.resource-timing-breakdown .waterfall .block):
+
2020-03-28 Nikita Vasilyev <[email protected]>
Web Inspector: Network: pressing RightArrow or LeftArrow unexpectedly changes panels
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css (259168 => 259169)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css 2020-03-29 02:52:35 UTC (rev 259168)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css 2020-03-29 02:54:09 UTC (rev 259169)
@@ -50,7 +50,7 @@
-webkit-margin-end: 4px;
}
-.network-table > .table li:not(.selected) .cell:not(.current-session) {
+.network-table > .table li:not(.filler, .selected) .cell:not(.current-session) {
opacity: 0.5;
}
@@ -116,10 +116,6 @@
color: var(--text-color-gray-medium);
}
-.network-table > .table .error {
- color: var(--error-text-color);
-}
-
.network-table > .table .cell.domain > .lock {
width: 8px;
height: 10px;
@@ -236,7 +232,13 @@
font-weight: normal;
}
-.network-table > .table .waterfall .block {
+/* Styles also used by `WI.ResourceTimingBreakdownView`. */
+
+.network-table .error {
+ color: var(--error-text-color);
+}
+
+.network-table .waterfall .block {
position: absolute;
top: 8px;
min-width: 2px;
@@ -246,7 +248,7 @@
--end-radius: 2px;
}
-body[dir=ltr] .network-table > .table .waterfall .block {
+body[dir=ltr] .network-table .waterfall .block {
border-top-left-radius: var(--start-radius);
border-top-right-radius: var(--end-radius);
border-bottom-left-radius: var(--start-radius);
@@ -253,7 +255,7 @@
border-bottom-right-radius: var(--end-radius);
}
-body[dir=rtl] .network-table > .table .waterfall .block {
+body[dir=rtl] .network-table .waterfall .block {
border-top-left-radius: var(--end-radius);
border-top-right-radius: var(--start-radius);
border-bottom-left-radius: var(--end-radius);
@@ -274,49 +276,49 @@
--end-radius: 2px;
}
-.network-table > .table .waterfall .block.request,
-.network-table > .table .waterfall .block.response {
+.network-table .waterfall .block.request,
+.network-table .waterfall .block.response {
top: 3px;
height: 14px;
}
-.network-table > .table .waterfall .block.mouse-tracking {
+.network-table .waterfall .block.mouse-tracking {
top: 1px;
z-index: 2;
height: 18px;
}
-.network-table > .table .waterfall .block.filler {
+.network-table .waterfall .block.filler {
top: 9px;
height: 2px;
background-color: lightgrey;
}
-.network-table > .table .waterfall .block.redirect {
+.network-table .waterfall .block.redirect {
background-color: var(--network-redirect-color);
}
-.network-table > .table .waterfall .block.queue {
+.network-table .waterfall .block.queue {
background-color: var(--network-queue-color);
}
-.network-table > .table .waterfall .block.dns {
+.network-table .waterfall .block.dns {
background-color: var(--network-dns-color);
}
-.network-table > .table .waterfall .block.connect {
+.network-table .waterfall .block.connect {
background-color: var(--network-connect-color);
}
-.network-table > .table .waterfall .block.secure {
+.network-table .waterfall .block.secure {
background-color: var(--network-secure-color);
}
-.network-table > .table .waterfall .block.request {
+.network-table .waterfall .block.request {
background-color: var(--network-request-color);
}
-.network-table > .table .waterfall .block.response {
+.network-table .waterfall .block.response {
background-color: var(--network-response-color);
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimingBreakdownView.css (259168 => 259169)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimingBreakdownView.css 2020-03-29 02:52:35 UTC (rev 259168)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimingBreakdownView.css 2020-03-29 02:54:09 UTC (rev 259169)
@@ -64,10 +64,12 @@
}
.resource-timing-breakdown .waterfall .block {
- top: 1px;
- height: 14px;
+ top: 1px !important;
+ height: 14px !important;
}
+/* Additional styles used from `WI.NetworkTableContentView`. */
+
@media (prefers-color-scheme: dark) {
.resource-timing-breakdown > table > tr.header:not(.total-row) > td {
color: var(--text-color);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
