Title: [259197] trunk/Tools
- Revision
- 259197
- Author
- [email protected]
- Date
- 2020-03-30 06:49:44 -0700 (Mon, 30 Mar 2020)
Log Message
[macOS] REGRESSION(r258949) API test failures
https://bugs.webkit.org/show_bug.cgi?id=209702
Reviewed by Darin Adler.
After r258949, the preference observer is started when the app is activated, but since the app running
API tests is not being activated, the preference observer needs to be manually instantiated in each test.
* TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
(-[WKTestPreferenceObserver preferenceDidChange:key:encodedValue:]):
(TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (259196 => 259197)
--- trunk/Tools/ChangeLog 2020-03-30 13:13:40 UTC (rev 259196)
+++ trunk/Tools/ChangeLog 2020-03-30 13:49:44 UTC (rev 259197)
@@ -1,3 +1,17 @@
+2020-03-30 Per Arne Vollan <[email protected]>
+
+ [macOS] REGRESSION(r258949) API test failures
+ https://bugs.webkit.org/show_bug.cgi?id=209702
+
+ Reviewed by Darin Adler.
+
+ After r258949, the preference observer is started when the app is activated, but since the app running
+ API tests is not being activated, the preference observer needs to be manually instantiated in each test.
+
+ * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
+ (-[WKTestPreferenceObserver preferenceDidChange:key:encodedValue:]):
+ (TEST):
+
2020-03-28 Alex Christensen <[email protected]>
REGRESSION(r257963) UI process crashes when setting navigation delegate inside navigation delegate callbacks
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm (259196 => 259197)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm 2020-03-30 13:13:40 UTC (rev 259196)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm 2020-03-30 13:49:44 UTC (rev 259197)
@@ -43,6 +43,7 @@
- (void)preferenceDidChange:(NSString *)domain key:(NSString *)key encodedValue:(NSString *)encodedValue
{
done = true;
+ [super preferenceDidChange:domain key:key encodedValue:encodedValue];
}
@end
@@ -81,6 +82,8 @@
TEST(WebKit, PreferenceChanges)
{
+ auto observer = adoptNS([[WKTestPreferenceObserver alloc] init]);
+
CFPreferencesSetAppValue(testKey, CFSTR("1"), testDomain);
EXPECT_EQ(1, CFPreferencesGetAppIntegerValue(testKey, testDomain, nullptr));
@@ -104,6 +107,8 @@
TEST(WebKit, PreferenceChangesArray)
{
+ auto observer = adoptNS([[WKTestPreferenceObserver alloc] init]);
+
NSArray *array = @[@1, @2, @3];
auto userDefaults = adoptNS([[NSUserDefaults alloc] initWithSuiteName:(NSString *)testDomain]);
@@ -136,6 +141,8 @@
TEST(WebKit, PreferenceChangesDictionary)
{
+ auto observer = adoptNS([[WKTestPreferenceObserver alloc] init]);
+
NSDictionary *dict = @{
@"a" : @1,
@"b" : @2,
@@ -175,6 +182,8 @@
TEST(WebKit, PreferenceChangesData)
{
+ auto observer = adoptNS([[WKTestPreferenceObserver alloc] init]);
+
NSData *data = "" dataWithBytes:"abc" length:3];
auto userDefaults = adoptNS([[NSUserDefaults alloc] initWithSuiteName:(NSString *)testDomain]);
@@ -207,6 +216,8 @@
TEST(WebKit, PreferenceChangesDate)
{
+ auto observer = adoptNS([[WKTestPreferenceObserver alloc] init]);
+
NSDate *date = [NSDate dateWithTimeIntervalSinceNow:0];
auto userDefaults = adoptNS([[NSUserDefaults alloc] initWithSuiteName:(NSString *)testDomain]);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
