Modified: branches/safari-610.1.7-branch/Source/WebKit/ChangeLog (259225 => 259226)
--- branches/safari-610.1.7-branch/Source/WebKit/ChangeLog 2020-03-30 20:56:46 UTC (rev 259225)
+++ branches/safari-610.1.7-branch/Source/WebKit/ChangeLog 2020-03-30 20:56:49 UTC (rev 259226)
@@ -1,78 +1,5 @@
-b'2020-03-30 Alan Coon <[email protected]>\n\n Cherry-pick r258521. rdar://problem/60453086\n\n Crash under WebCookieCache::clearForHost()\n https://bugs.webkit.org/show_bug.cgi?id=209149\n <rdar://problem/60453086>\n \n Reviewed by Alex Christensen.\n \n Source/WebKit:\n \n Make sure WebCookieCache::pruneCacheIfNecessary() keeps alive the host String it is passing\n to WebCookieCache::clearForHost(). Previously, it was merely deferencing a HashSet iterator\n and passing that to clearForHost(). However, clearForHost() would then drop the String from\n the HashSet and the host would no longer be valid.\n \n Change covered by new API test.\n \n * WebProcess/WebPage/WebCookieCache.cpp:\n (WebKit::WebCookieCache::pruneCacheIfNecessary):\n \n Tools:\n \n Add API test coverage.\n \n * TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:\n (TEST):\n \n \n git-svn-id: http
s://svn.webkit.org/repository/webkit/trunk@258521 268f45cc-cd09-0410-ab3c-d52691b4dbfc\n\n 2020-03-16 Chris Dumez <[email protected]>\n\n Crash under WebCookieCache::clearForHost()\n https://bugs.webkit.org/show_bug.cgi?id=209149\n <rdar://problem/60453086>\n\n Reviewed by Alex Christensen.\n\n Make sure WebCookieCache::pruneCacheIfNecessary() keeps alive the host String it is passing\n to WebCookieCache::clearForHost(). Previously, it was merely deferencing a HashSet iterator\n and passing that to clearForHost(). However, clearForHost() would then drop the String from\n the HashSet and the host would no longer be valid.\n\n Change covered by new API test.\n\n * WebProcess/WebPage/WebCookieCache.cpp:\n (WebKit::WebCookieCache::pruneCacheIfNecessary):\n\n b\'2020-03-30 Alan Coon <[email protected]>\\n\\n Cherry-pick r258456. rdar:
//problem/59931477\\n\\n Clean up sandbox violations found during testing\\n https://bugs.webkit.org/show_bug.cgi?id=209096\\n <rdar://problem/59931477>\\n \\n Reviewed by Geoffrey Garen.\\n \\n Remove telemetry from some items, and allow access to some IOKit properties\\n needed for media playback on macOS and iOS.\\n \\n * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:\\n * WebProcess/com.apple.WebProcess.sb.in:\\n \\n \\n git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258456 268f45cc-cd09-0410-ab3c-d52691b4dbfc\\n\\n 2020-03-13 Brent Fulgham <[email protected]>\\n\\n Clean up sandbox violations found during testing\\n https://bugs.webkit.org/show_bug.cgi?id=209096\\n <rdar://problem/59931477>\\n\\n Reviewed by Geoffrey Garen.\\n\\n Remove telemetry from some items, and allow access to some IOKit properties\\n needed for med
ia playback on macOS and iOS.\\n\\n * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:\\n * WebProcess/com.apple.WebProcess.sb.in:\\n\\n b"2020-03-24 Alan Coon <[email protected]>\\\\n\\\\n Cherry-pick r258476. rdar://problem/60839077\\\\n\\\\n Add missing checks needed for AppBound Quirk\\\\n https://bugs.webkit.org/show_bug.cgi?id=209117\\\\n <rdar://problem/60460097>\\\\n \\\\n Reviewed by John Wilander.\\\\n \\\\n The checks for the \\\'NeedsInAppBrowserPrivacyQuirks\\\' flag added in r258101 was incomplete.\\\\n Source/WebCore:\\\\n \\\\n Two additional call sites need to check the state of the flag.\\\\n \\\\n * bindings/js/ScriptController.cpp:\\\\n (WebCore::ScriptController::executeScriptInWorld): Add missing check for the quirk.\\\\n * loader/FrameLoaderClient.h: Add new API for the \\\'NeedsInAppBrowserPrivacyQuirks\\\'\\\\n debug flag.\\\\n * page/Frame.cpp:\\
\\n (WebCore::Frame::injectUserScriptImmediately): Ditto.\\\\n \\\\n Source/WebKit:\\\\n \\\\n These changes let the WebFrameLoaderClient report the quirk state to WebCore code.\\\\n \\\\n * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:\\\\n (WebKit::WebFrameLoaderClient::needsInAppBrowserPrivacyQuirks): Added.\\\\n * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:\\\\n * WebProcess/WebPage/WebPage.h:\\\\n (WebKit::WebPage::needsInAppBrowserPrivacyQuirks const): Added.\\\\n \\\\n \\\\n git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258476 268f45cc-cd09-0410-ab3c-d52691b4dbfc\\\\n\\\\n 2020-03-14 Brent Fulgham <[email protected]>\\\\n\\\\n Add missing checks needed for AppBound Quirk\\\\n https://bugs.webkit.org/show_bug.cgi?id=209117\\\\n <rdar://problem/60460097>\\\\n\\\\n Reviewed by John Wilander.\\\\n\\\\n The checks for the \\\'NeedsInAppBrowser
PrivacyQuirks\\\' flag added in r258101 was incomplete.\\\\n These changes let the WebFrameLoaderClient report the quirk state to WebCore code.\\\\n\\\\n * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:\\\\n (WebKit::WebFrameLoaderClient::needsInAppBrowserPrivacyQuirks): Added.\\\\n * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:\\\\n * WebProcess/WebPage/WebPage.h:\\\\n (WebKit::WebPage::needsInAppBrowserPrivacyQuirks const): Added.\\\\n\\\\n"2020-03-17 Alan Coon <[email protected]>\\n\\n Cherry-pick r258515. rdar://problem/60551856\\n\\n [Cocoa] Crash under -[WKPreferenceObserver init]\\n https://bugs.webkit.org/show_bug.cgi?id=209145\\n\\n Reviewed by Darin Adler.\\n\\n Handle the case when calling [NSUserDefaults initWithSuiteName:] did not succeed.\\n\\n No new tests, since I have not been able to reproduce.\\n\\n * UIProcess/Cocoa/Prefer
enceObserver.mm:\\n (-[WKPreferenceObserver init]):\\n\\n\\n\\n git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258515 268f45cc-cd09-0410-ab3c-d52691b4dbfc\\n\\n 2020-03-16 Per Arne Vollan <[email protected]>\\n\\n [Cocoa] Crash under -[WKPreferenceObserver init]\\n https://bugs.webkit.org/show_bug.cgi?id=209145\\n\\n Reviewed by Darin Adler.\\n\\n Handle the case when calling [NSUserDefaults initWithSuiteName:] did not succeed.\\n\\n No new tests, since I have not been able to reproduce.\\n\\n * UIProcess/Cocoa/PreferenceObserver.mm:\\n (-[WKPreferenceObserver init]):\\n\\n\'2020-03-17 Alan Coon <[email protected]>\n\n Cherry-pick r258518. rdar://problem/60517387\n\n [macOS] Accessibility sandbox regressions\n https://bugs.webkit.org/show_bug.cgi?id=209065\n Source/WebCore/PAL:\n\n\n Reviewed
by Brent Fulgham.\n\n Add Accessibility notification name.\n\n * pal/spi/cocoa/NSAccessibilitySPI.h:\n\n Source/WebKit:\n\n <rdar://problem/60202450>\n\n Reviewed by Brent Fulgham.\n\n When Accessibility is enabled, the WebContent process needs access to the preference service, since Accessibility\n is relying on some advanced features of the service. Also, when CF prefs direct mode is enabled, the WebContent\n sandbox needs to explicitly allow reading of the various plist files.\n\n * UIProcess/Cocoa/WebProcessPoolCocoa.mm:\n (WebKit::WebProcessPool::registerNotificationObservers):\n * WebProcess/com.apple.WebProcess.sb.in:\n\n Tools:\n\n\n Reviewed by Brent Fulgham.\n\n * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:\n (TEST):\n * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm:\n (TEST):\n\n\n\n git-svn-id: https://svn.webkit.org/
repository/webkit/trunk@258518 268f45cc-cd09-0410-ab3c-d52691b4dbfc\n\n 2020-03-16 Per Arne Vollan <[email protected]>\n\n [macOS] Accessibility sandbox regressions\n https://bugs.webkit.org/show_bug.cgi?id=209065\n <rdar://problem/60202450>\n\n Reviewed by Brent Fulgham.\n\n When Accessibility is enabled, the WebContent process needs access to the preference service, since Accessibility\n is relying on some advanced features of the service. Also, when CF prefs direct mode is enabled, the WebContent\n sandbox needs to explicitly allow reading of the various plist files.\n\n * UIProcess/Cocoa/WebProcessPoolCocoa.mm:\n (WebKit::WebProcessPool::registerNotificationObservers):\n * WebProcess/com.apple.WebProcess.sb.in:\n\n'2020-03-17 Alan Coon <[email protected]>
+b'2020-03-30 Alan Coon <[email protected]>\n\n Cherry-pick r258530. rdar://problem/60453086\n\n Crash under WebCookieCache::clearForHost()\n https://bugs.webkit.org/show_bug.cgi?id=209149\n <rdar://problem/60453086>\n \n Reviewed by Darin Adler.\n \n Alternative fix for Bug 209149 based on comments from Darin.\n \n * WebProcess/WebPage/WebCookieCache.cpp:\n (WebKit::WebCookieCache::clearForHost):\n (WebKit::WebCookieCache::pruneCacheIfNecessary):\n \n \n git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258530 268f45cc-cd09-0410-ab3c-d52691b4dbfc\n\n 2020-03-16 Chris Dumez <[email protected]>\n\n Crash under WebCookieCache::clearForHost()\n https://bugs.webkit.org/show_bug.cgi?id=209149\n <rdar://problem/60453086>\n\n Reviewed by Darin Adler.\n\n Alternative fix for Bug 209149 based on comments from Darin.\n\n * WebProc
ess/WebPage/WebCookieCache.cpp:\n (WebKit::WebCookieCache::clearForHost):\n (WebKit::WebCookieCache::pruneCacheIfNecessary):\n\n b\'2020-03-30 Alan Coon <[email protected]>\\n\\n Cherry-pick r258521. rdar://problem/60453086\\n\\n Crash under WebCookieCache::clearForHost()\\n https://bugs.webkit.org/show_bug.cgi?id=209149\\n <rdar://problem/60453086>\\n \\n Reviewed by Alex Christensen.\\n \\n Source/WebKit:\\n \\n Make sure WebCookieCache::pruneCacheIfNecessary() keeps alive the host String it is passing\\n to WebCookieCache::clearForHost(). Previously, it was merely deferencing a HashSet iterator\\n and passing that to clearForHost(). However, clearForHost() would then drop the String from\\n the HashSet and the host would no longer be valid.\\n \\n Change covered by new API test.\\n \\n * WebProcess/WebPage/WebCookieCache.cpp:\\n (WebKit::WebCookieCache::pruneCacheIfNecessary):\\n
\\n Tools:\\n \\n Add API test coverage.\\n \\n * TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:\\n (TEST):\\n \\n \\n git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258521 268f45cc-cd09-0410-ab3c-d52691b4dbfc\\n\\n 2020-03-16 Chris Dumez <[email protected]>\\n\\n Crash under WebCookieCache::clearForHost()\\n https://bugs.webkit.org/show_bug.cgi?id=209149\\n <rdar://problem/60453086>\\n\\n Reviewed by Alex Christensen.\\n\\n Make sure WebCookieCache::pruneCacheIfNecessary() keeps alive the host String it is passing\\n to WebCookieCache::clearForHost(). Previously, it was merely deferencing a HashSet iterator\\n and passing that to clearForHost(). However, clearForHost() would then drop the String from\\n the HashSet and the host would no longer be valid.\\n\\n Change covered by new API test.\\n\\n * WebProcess
/WebPage/WebCookieCache.cpp:\\n (WebKit::WebCookieCache::pruneCacheIfNecessary):\\n\\n b\\\'2020-03-30 Alan Coon <[email protected]>\\\\n\\\\n Cherry-pick r258456. rdar://problem/59931477\\\\n\\\\n Clean up sandbox violations found during testing\\\\n https://bugs.webkit.org/show_bug.cgi?id=209096\\\\n <rdar://problem/59931477>\\\\n \\\\n Reviewed by Geoffrey Garen.\\\\n \\\\n Remove telemetry from some items, and allow access to some IOKit properties\\\\n needed for media playback on macOS and iOS.\\\\n \\\\n * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:\\\\n * WebProcess/com.apple.WebProcess.sb.in:\\\\n \\\\n \\\\n git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258456 268f45cc-cd09-0410-ab3c-d52691b4dbfc\\\\n\\\\n 2020-03-13 Brent Fulgham <[email protected]>\\\\n\\\\n Clean up sandbox violations found during testing\\\\n https://bugs.webkit.
org/show_bug.cgi?id=209096\\\\n <rdar://problem/59931477>\\\\n\\\\n Reviewed by Geoffrey Garen.\\\\n\\\\n Remove telemetry from some items, and allow access to some IOKit properties\\\\n needed for media playback on macOS and iOS.\\\\n\\\\n * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:\\\\n * WebProcess/com.apple.WebProcess.sb.in:\\\\n\\\\n b"2020-03-24 Alan Coon <[email protected]>\\\\\\\\n\\\\\\\\n Cherry-pick r258476. rdar://problem/60839077\\\\\\\\n\\\\\\\\n Add missing checks needed for AppBound Quirk\\\\\\\\n https://bugs.webkit.org/show_bug.cgi?id=209117\\\\\\\\n <rdar://problem/60460097>\\\\\\\\n \\\\\\\\n Reviewed by John Wilander.\\\\\\\\n \\\\\\\\n The checks for the \\\\\\\'NeedsInAppBrowserPrivacyQuirks\\\\\\\' flag added in r258101 was incomplete.\\\\\\\\n Source/WebCore:\\\\\\\\n \\\\\\\\n Two additional call sites need
to check the state of the flag.\\\\\\\\n \\\\\\\\n * bindings/js/ScriptController.cpp:\\\\\\\\n (WebCore::ScriptController::executeScriptInWorld): Add missing check for the quirk.\\\\\\\\n * loader/FrameLoaderClient.h: Add new API for the \\\\\\\'NeedsInAppBrowserPrivacyQuirks\\\\\\\'\\\\\\\\n debug flag.\\\\\\\\n * page/Frame.cpp:\\\\\\\\n (WebCore::Frame::injectUserScriptImmediately): Ditto.\\\\\\\\n \\\\\\\\n Source/WebKit:\\\\\\\\n \\\\\\\\n These changes let the WebFrameLoaderClient report the quirk state to WebCore code.\\\\\\\\n \\\\\\\\n * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:\\\\\\\\n (WebKit::WebFrameLoaderClient::needsInAppBrowserPrivacyQuirks): Added.\\\\\\\\n * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:\\\\\\\\n * WebProcess/WebPage/WebPage.h:\\\\\\\\n (WebKit::WebPage::needsInAppBrowserPrivacyQuirks const): Added.\\\\\\\\n \\\\\\\\n \\\\\\\\n git-svn-id: https://svn.webkit.org/repository/w
ebkit/trunk@258476 268f45cc-cd09-0410-ab3c-d52691b4dbfc\\\\\\\\n\\\\\\\\n 2020-03-14 Brent Fulgham <[email protected]>\\\\\\\\n\\\\\\\\n Add missing checks needed for AppBound Quirk\\\\\\\\n https://bugs.webkit.org/show_bug.cgi?id=209117\\\\\\\\n <rdar://problem/60460097>\\\\\\\\n\\\\\\\\n Reviewed by John Wilander.\\\\\\\\n\\\\\\\\n The checks for the \\\\\\\'NeedsInAppBrowserPrivacyQuirks\\\\\\\' flag added in r258101 was incomplete.\\\\\\\\n These changes let the WebFrameLoaderClient report the quirk state to WebCore code.\\\\\\\\n\\\\\\\\n * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:\\\\\\\\n (WebKit::WebFrameLoaderClient::needsInAppBrowserPrivacyQuirks): Added.\\\\\\\\n * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:\\\\\\\\n * WebProcess/WebPage/WebPage.h:\\\\\\\\n (WebKit::WebPage::needsInAppBrowserPrivacyQuirks const): Added.
\\\\\\\\n\\\\\\\\n"2020-03-17 Alan Coon <[email protected]>\\\\n\\\\n Cherry-pick r258515. rdar://problem/60551856\\\\n\\\\n [Cocoa] Crash under -[WKPreferenceObserver init]\\\\n https://bugs.webkit.org/show_bug.cgi?id=209145\\\\n\\\\n Reviewed by Darin Adler.\\\\n\\\\n Handle the case when calling [NSUserDefaults initWithSuiteName:] did not succeed.\\\\n\\\\n No new tests, since I have not been able to reproduce.\\\\n\\\\n * UIProcess/Cocoa/PreferenceObserver.mm:\\\\n (-[WKPreferenceObserver init]):\\\\n\\\\n\\\\n\\\\n git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258515 268f45cc-cd09-0410-ab3c-d52691b4dbfc\\\\n\\\\n 2020-03-16 Per Arne Vollan <[email protected]>\\\\n\\\\n [Cocoa] Crash under -[WKPreferenceObserver init]\\\\n https://bugs.webkit.org/show_bug.cgi?id=209145\\\\n\\\\n Reviewed by Darin Adler.\\\\n\\\\n
Handle the case when calling [NSUserDefaults initWithSuiteName:] did not succeed.\\\\n\\\\n No new tests, since I have not been able to reproduce.\\\\n\\\\n * UIProcess/Cocoa/PreferenceObserver.mm:\\\\n (-[WKPreferenceObserver init]):\\\\n\\\\n\\\'2020-03-17 Alan Coon <[email protected]>\\n\\n Cherry-pick r258518. rdar://problem/60517387\\n\\n [macOS] Accessibility sandbox regressions\\n https://bugs.webkit.org/show_bug.cgi?id=209065\\n Source/WebCore/PAL:\\n\\n\\n Reviewed by Brent Fulgham.\\n\\n Add Accessibility notification name.\\n\\n * pal/spi/cocoa/NSAccessibilitySPI.h:\\n\\n Source/WebKit:\\n\\n <rdar://problem/60202450>\\n\\n Reviewed by Brent Fulgham.\\n\\n When Accessibility is enabled, the WebContent process needs access to the preference service, since Accessibility\\n is relying on some advanced features of the service. Al
so, when CF prefs direct mode is enabled, the WebContent\\n sandbox needs to explicitly allow reading of the various plist files.\\n\\n * UIProcess/Cocoa/WebProcessPoolCocoa.mm:\\n (WebKit::WebProcessPool::registerNotificationObservers):\\n * WebProcess/com.apple.WebProcess.sb.in:\\n\\n Tools:\\n\\n\\n Reviewed by Brent Fulgham.\\n\\n * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:\\n (TEST):\\n * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm:\\n (TEST):\\n\\n\\n\\n git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258518 268f45cc-cd09-0410-ab3c-d52691b4dbfc\\n\\n 2020-03-16 Per Arne Vollan <[email protected]>\\n\\n [macOS] Accessibility sandbox regressions\\n https://bugs.webkit.org/show_bug.cgi?id=209065\\n <rdar://problem/60202450>\\n\\n Reviewed by Brent Fulgham.\\n\\n When Acces
sibility is enabled, the WebContent process needs access to the preference service, since Accessibility\\n is relying on some advanced features of the service. Also, when CF prefs direct mode is enabled, the WebContent\\n sandbox needs to explicitly allow reading of the various plist files.\\n\\n * UIProcess/Cocoa/WebProcessPoolCocoa.mm:\\n (WebKit::WebProcessPool::registerNotificationObservers):\\n * WebProcess/com.apple.WebProcess.sb.in:\\n\\n\'2020-03-17 Alan Coon <[email protected]>\n\n Cherry-pick r258359. rdar://problem/60517387\n\n [macOS] _AXSApplicationAccessibilityEnabled should not be called\n https://bugs.webkit.org/show_bug.cgi?id=208953\n\n Reviewed by Brent Fulgham.\n\n Source/WebCore:\n\n The function _AXSApplicationAccessibilityEnabled and the notification kAXSApplicationAccessibilityEnabledNotification\n exist on macOS, but they d
o not have the same behavior as on iOS, and should not be used in the same way. Using this\n function and notification on macOS was introduced in <https://bugs.webkit.org/show_bug.cgi?id=208690>, and this patch\n partially reverts this behavior.\n\n API test: WebKit.IsRemoteUIAppForAccessibility\n\n * testing/Internals.cpp:\n (WebCore::Internals::isRemoteUIAppForAccessibility):\n * testing/Internals.h:\n * testing/Internals.idl:\n * testing/Internals.mm:\n (WebCore::Internals::isRemoteUIAppForAccessibility):\n\n Source/WebCore/PAL:\n\n Declare method to check if the process is a remote UI app for accessibility.\n\n * pal/spi/cocoa/NSAccessibilitySPI.h:\n\n Source/WebKit:\n\n On macOS, stop using the function _AXSApplicationAccessibilityEnabled and listening to the notification\n kAXSApplicationAccessibilityEnabledNotification, since they do not have the same behavior as on
iOS.\n\n * UIProcess/Cocoa/WebProcessPoolCocoa.mm:\n (WebKit::WebProcessPool::platformInitializeWebProcess):\n (WebKit::WebProcessPool::registerNotificationObservers):\n (WebKit::WebProcessPool::unregisterNotificationObservers):\n * UIProcess/Cocoa/WebProcessProxyCocoa.mm:\n (WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded):\n * WebProcess/cocoa/WebProcessCocoa.mm:\n (WebKit::WebProcess::platformInitializeProcess):\n (WebKit::WebProcess::unblockAccessibilityServer):\n\n Tools:\n\n * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:\n\n\n git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258359 268f45cc-cd09-0410-ab3c-d52691b4dbfc\n\n 2020-03-12 Per Arne Vollan <[email protected]>\n\n [macOS] _AXSApplicationAccessibilityEnabled should not be called\n https://bugs.webkit.org/show_bug.cgi?id=208953\n\n Reviewed by Bren
t Fulgham.\n\n On macOS, stop using the function _AXSApplicationAccessibilityEnabled and listening to the notification\n kAXSApplicationAccessibilityEnabledNotification, since they do not have the same behavior as on iOS.\n\n * UIProcess/Cocoa/WebProcessPoolCocoa.mm:\n (WebKit::WebProcessPool::platformInitializeWebProcess):\n (WebKit::WebProcessPool::registerNotificationObservers):\n (WebKit::WebProcessPool::unregisterNotificationObservers):\n * UIProcess/Cocoa/WebProcessProxyCocoa.mm:\n (WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded):\n * WebProcess/cocoa/WebProcessCocoa.mm:\n (WebKit::WebProcess::platformInitializeProcess):\n (WebKit::WebProcess::unblockAccessibilityServer):\n\n'2020-03-17 Alan Coon <[email protected]>
- Cherry-pick r258359. rdar://problem/60517387
-
- [macOS] _AXSApplicationAccessibilityEnabled should not be called
- https://bugs.webkit.org/show_bug.cgi?id=208953
-
- Reviewed by Brent Fulgham.
-
- Source/WebCore:
-
- The function _AXSApplicationAccessibilityEnabled and the notification kAXSApplicationAccessibilityEnabledNotification
- exist on macOS, but they do not have the same behavior as on iOS, and should not be used in the same way. Using this
- function and notification on macOS was introduced in <https://bugs.webkit.org/show_bug.cgi?id=208690>, and this patch
- partially reverts this behavior.
-
- API test: WebKit.IsRemoteUIAppForAccessibility
-
- * testing/Internals.cpp:
- (WebCore::Internals::isRemoteUIAppForAccessibility):
- * testing/Internals.h:
- * testing/Internals.idl:
- * testing/Internals.mm:
- (WebCore::Internals::isRemoteUIAppForAccessibility):
-
- Source/WebCore/PAL:
-
- Declare method to check if the process is a remote UI app for accessibility.
-
- * pal/spi/cocoa/NSAccessibilitySPI.h:
-
- Source/WebKit:
-
- On macOS, stop using the function _AXSApplicationAccessibilityEnabled and listening to the notification
- kAXSApplicationAccessibilityEnabledNotification, since they do not have the same behavior as on iOS.
-
- * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
- (WebKit::WebProcessPool::platformInitializeWebProcess):
- (WebKit::WebProcessPool::registerNotificationObservers):
- (WebKit::WebProcessPool::unregisterNotificationObservers):
- * UIProcess/Cocoa/WebProcessProxyCocoa.mm:
- (WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded):
- * WebProcess/cocoa/WebProcessCocoa.mm:
- (WebKit::WebProcess::platformInitializeProcess):
- (WebKit::WebProcess::unblockAccessibilityServer):
-
- Tools:
-
- * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
-
-
- git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 2020-03-12 Per Arne Vollan <[email protected]>
-
- [macOS] _AXSApplicationAccessibilityEnabled should not be called
- https://bugs.webkit.org/show_bug.cgi?id=208953
-
- Reviewed by Brent Fulgham.
-
- On macOS, stop using the function _AXSApplicationAccessibilityEnabled and listening to the notification
- kAXSApplicationAccessibilityEnabledNotification, since they do not have the same behavior as on iOS.
-
- * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
- (WebKit::WebProcessPool::platformInitializeWebProcess):
- (WebKit::WebProcessPool::registerNotificationObservers):
- (WebKit::WebProcessPool::unregisterNotificationObservers):
- * UIProcess/Cocoa/WebProcessProxyCocoa.mm:
- (WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded):
- * WebProcess/cocoa/WebProcessCocoa.mm:
- (WebKit::WebProcess::platformInitializeProcess):
- (WebKit::WebProcess::unblockAccessibilityServer):
-
-2020-03-17 Alan Coon <[email protected]>
-
Cherry-pick r258557. rdar://problem/60517387
[Cocoa] Disable CF prefs direct mode
Modified: branches/safari-610.1.7-branch/Source/WebKit/WebProcess/WebPage/WebCookieCache.cpp (259225 => 259226)
--- branches/safari-610.1.7-branch/Source/WebKit/WebProcess/WebPage/WebCookieCache.cpp 2020-03-30 20:56:46 UTC (rev 259225)
+++ branches/safari-610.1.7-branch/Source/WebKit/WebProcess/WebPage/WebCookieCache.cpp 2020-03-30 20:56:49 UTC (rev 259226)
@@ -102,14 +102,13 @@
void WebCookieCache::clearForHost(const String& host)
{
- auto it = m_hostsWithInMemoryStorage.find(host);
- if (it == m_hostsWithInMemoryStorage.end())
+ String removedHost = m_hostsWithInMemoryStorage.take(host);
+ if (removedHost.isNull())
return;
- m_hostsWithInMemoryStorage.remove(it);
- inMemoryStorageSession().deleteCookiesForHostnames(Vector<String> { host });
+ inMemoryStorageSession().deleteCookiesForHostnames(Vector<String> { removedHost });
#if HAVE(COOKIE_CHANGE_LISTENER_API)
- WebProcess::singleton().ensureNetworkProcessConnection().connection().send(Messages::NetworkConnectionToWebProcess::UnsubscribeFromCookieChangeNotifications(HashSet<String> { host }), 0);
+ WebProcess::singleton().ensureNetworkProcessConnection().connection().send(Messages::NetworkConnectionToWebProcess::UnsubscribeFromCookieChangeNotifications(HashSet<String> { removedHost }), 0);
#endif
}
@@ -118,10 +117,8 @@
// We may want to raise this limit if we start using the cache for third-party iframes.
static const unsigned maxCachedHosts = 5;
- while (m_hostsWithInMemoryStorage.size() >= maxCachedHosts) {
- String hostToRemove = *m_hostsWithInMemoryStorage.random();
- clearForHost(hostToRemove);
- }
+ while (m_hostsWithInMemoryStorage.size() >= maxCachedHosts)
+ clearForHost(*m_hostsWithInMemoryStorage.random());
}
#if !PLATFORM(COCOA)
