Title: [259224] branches/safari-610.1.7-branch/Source/WebKit
Revision
259224
Author
[email protected]
Date
2020-03-30 13:56:44 -0700 (Mon, 30 Mar 2020)

Log Message

Cherry-pick r258456. rdar://problem/59931477

    Clean up sandbox violations found during testing
    https://bugs.webkit.org/show_bug.cgi?id=209096
    <rdar://problem/59931477>

    Reviewed by Geoffrey Garen.

    Remove telemetry from some items, and allow access to some IOKit properties
    needed for media playback on macOS and iOS.

    * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
    * WebProcess/com.apple.WebProcess.sb.in:

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-610.1.7-branch/Source/WebKit/ChangeLog (259223 => 259224)


--- branches/safari-610.1.7-branch/Source/WebKit/ChangeLog	2020-03-30 20:56:41 UTC (rev 259223)
+++ branches/safari-610.1.7-branch/Source/WebKit/ChangeLog	2020-03-30 20:56:44 UTC (rev 259224)
@@ -1,39 +1,5 @@
-b"2020-03-24  Alan Coon  <[email protected]>\n\n        Cherry-pick r258476. rdar://problem/60839077\n\n    Add missing checks needed for AppBound Quirk\n    https://bugs.webkit.org/show_bug.cgi?id=209117\n    <rdar://problem/60460097>\n    \n    Reviewed by John Wilander.\n    \n    The checks for the 'NeedsInAppBrowserPrivacyQuirks' flag added in r258101 was incomplete.\n    Source/WebCore:\n    \n    Two additional call sites need to check the state of the flag.\n    \n    * bindings/js/ScriptController.cpp:\n    (WebCore::ScriptController::executeScriptInWorld): Add missing check for the quirk.\n    * loader/FrameLoaderClient.h: Add new API for the 'NeedsInAppBrowserPrivacyQuirks'\n    debug flag.\n    * page/Frame.cpp:\n    (WebCore::Frame::injectUserScriptImmediately): Ditto.\n    \n    Source/WebKit:\n    \n    These changes let the WebFrameLoaderClient report the quirk state to WebCore code.\n    \n    * WebProcess/WebCoreSupport/WebFrameLoaderC
 lient.cpp:\n    (WebKit::WebFrameLoaderClient::needsInAppBrowserPrivacyQuirks): Added.\n    * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:\n    * WebProcess/WebPage/WebPage.h:\n    (WebKit::WebPage::needsInAppBrowserPrivacyQuirks const): Added.\n    \n    \n    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258476 268f45cc-cd09-0410-ab3c-d52691b4dbfc\n\n    2020-03-14  Brent Fulgham  <[email protected]>\n\n            Add missing checks needed for AppBound Quirk\n            https://bugs.webkit.org/show_bug.cgi?id=209117\n            <rdar://problem/60460097>\n\n            Reviewed by John Wilander.\n\n            The checks for the 'NeedsInAppBrowserPrivacyQuirks' flag added in r258101 was incomplete.\n            These changes let the WebFrameLoaderClient report the quirk state to WebCore code.\n\n            * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:\n            (WebKit::WebFrameLoaderClient::needsInAppBrowserPrivacyQuirks): Added.\n    
         * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:\n            * WebProcess/WebPage/WebPage.h:\n            (WebKit::WebPage::needsInAppBrowserPrivacyQuirks const): Added.\n\n"2020-03-17  Alan Coon  <[email protected]>
+b'2020-03-30  Alan Coon  <[email protected]>\n\n        Cherry-pick r258456. rdar://problem/59931477\n\n    Clean up sandbox violations found during testing\n    https://bugs.webkit.org/show_bug.cgi?id=209096\n    <rdar://problem/59931477>\n    \n    Reviewed by Geoffrey Garen.\n    \n    Remove telemetry from some items, and allow access to some IOKit properties\n    needed for media playback on macOS and iOS.\n    \n    * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:\n    * WebProcess/com.apple.WebProcess.sb.in:\n    \n    \n    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258456 268f45cc-cd09-0410-ab3c-d52691b4dbfc\n\n    2020-03-13  Brent Fulgham  <[email protected]>\n\n            Clean up sandbox violations found during testing\n            https://bugs.webkit.org/show_bug.cgi?id=209096\n            <rdar://problem/59931477>\n\n            Reviewed by Geoffrey Garen.\n\n            Remove telemetry from some it
 ems, and allow access to some IOKit properties\n            needed for media playback on macOS and iOS.\n\n            * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:\n            * WebProcess/com.apple.WebProcess.sb.in:\n\n    b"2020-03-24  Alan Coon  <[email protected]>\\n\\n        Cherry-pick r258476. rdar://problem/60839077\\n\\n    Add missing checks needed for AppBound Quirk\\n    https://bugs.webkit.org/show_bug.cgi?id=209117\\n    <rdar://problem/60460097>\\n    \\n    Reviewed by John Wilander.\\n    \\n    The checks for the \'NeedsInAppBrowserPrivacyQuirks\' flag added in r258101 was incomplete.\\n    Source/WebCore:\\n    \\n    Two additional call sites need to check the state of the flag.\\n    \\n    * bindings/js/ScriptController.cpp:\\n    (WebCore::ScriptController::executeScriptInWorld): Add missing check for the quirk.\\n    * loader/FrameLoaderClient.h: Add new API for the \'NeedsInAppBrowserPrivacyQuirks\'\\n    debug flag.\\n
     * page/Frame.cpp:\\n    (WebCore::Frame::injectUserScriptImmediately): Ditto.\\n    \\n    Source/WebKit:\\n    \\n    These changes let the WebFrameLoaderClient report the quirk state to WebCore code.\\n    \\n    * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:\\n    (WebKit::WebFrameLoaderClient::needsInAppBrowserPrivacyQuirks): Added.\\n    * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:\\n    * WebProcess/WebPage/WebPage.h:\\n    (WebKit::WebPage::needsInAppBrowserPrivacyQuirks const): Added.\\n    \\n    \\n    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258476 268f45cc-cd09-0410-ab3c-d52691b4dbfc\\n\\n    2020-03-14  Brent Fulgham  <[email protected]>\\n\\n            Add missing checks needed for AppBound Quirk\\n            https://bugs.webkit.org/show_bug.cgi?id=209117\\n            <rdar://problem/60460097>\\n\\n            Reviewed by John Wilander.\\n\\n            The checks for the \'NeedsInAppBrowserPrivacyQuirks\' flag added 
 in r258101 was incomplete.\\n            These changes let the WebFrameLoaderClient report the quirk state to WebCore code.\\n\\n            * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:\\n            (WebKit::WebFrameLoaderClient::needsInAppBrowserPrivacyQuirks): Added.\\n            * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:\\n            * WebProcess/WebPage/WebPage.h:\\n            (WebKit::WebPage::needsInAppBrowserPrivacyQuirks const): Added.\\n\\n"2020-03-17  Alan Coon  <[email protected]>\n\n            Cherry-pick r258515. rdar://problem/60551856\n\n        [Cocoa] Crash under -[WKPreferenceObserver init]\n        https://bugs.webkit.org/show_bug.cgi?id=209145\n\n        Reviewed by Darin Adler.\n\n        Handle the case when calling [NSUserDefaults initWithSuiteName:] did not succeed.\n\n        No new tests, since I have not been able to reproduce.\n\n        * UIProcess/Cocoa/PreferenceObserver.mm:\n        (-[WKPreferenceObserver init]):\n\
 n\n\n        git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258515 268f45cc-cd09-0410-ab3c-d52691b4dbfc\n\n        2020-03-16  Per Arne Vollan  <[email protected]>\n\n                [Cocoa] Crash under -[WKPreferenceObserver init]\n                https://bugs.webkit.org/show_bug.cgi?id=209145\n\n                Reviewed by Darin Adler.\n\n                Handle the case when calling [NSUserDefaults initWithSuiteName:] did not succeed.\n\n                No new tests, since I have not been able to reproduce.\n\n                * UIProcess/Cocoa/PreferenceObserver.mm:\n                (-[WKPreferenceObserver init]):\n\n'2020-03-17  Alan Coon  <[email protected]>
 
-        Cherry-pick r258515. rdar://problem/60551856
-
-    [Cocoa] Crash under -[WKPreferenceObserver init]
-    https://bugs.webkit.org/show_bug.cgi?id=209145
-    
-    Reviewed by Darin Adler.
-    
-    Handle the case when calling [NSUserDefaults initWithSuiteName:] did not succeed.
-    
-    No new tests, since I have not been able to reproduce.
-    
-    * UIProcess/Cocoa/PreferenceObserver.mm:
-    (-[WKPreferenceObserver init]):
-    
-    
-    
-    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
-    2020-03-16  Per Arne Vollan  <[email protected]>
-
-            [Cocoa] Crash under -[WKPreferenceObserver init]
-            https://bugs.webkit.org/show_bug.cgi?id=209145
-
-            Reviewed by Darin Adler.
-
-            Handle the case when calling [NSUserDefaults initWithSuiteName:] did not succeed.
-
-            No new tests, since I have not been able to reproduce.
-
-            * UIProcess/Cocoa/PreferenceObserver.mm:
-            (-[WKPreferenceObserver init]):
-
-2020-03-17  Alan Coon  <[email protected]>
-
         Cherry-pick r258518. rdar://problem/60517387
 
     [macOS] Accessibility sandbox regressions

Modified: branches/safari-610.1.7-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (259223 => 259224)


--- branches/safari-610.1.7-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-03-30 20:56:41 UTC (rev 259223)
+++ branches/safari-610.1.7-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-03-30 20:56:44 UTC (rev 259224)
@@ -742,6 +742,7 @@
         "kern.osvariant_status"
         "kern.secure_kernel" ;; Needed by XPC bundle resolution
         "kern.version"
+        "sysctl.name2oid"
         "vm.footprint_suspend")
     (sysctl-name-regex #"^net.routetable") ;; <rdar://problem/57665153>
 )
@@ -778,6 +779,7 @@
     (iokit-property "dfr")
     (iokit-property "display-corner-radius") ;; <rdar://problem/50602737>
     (iokit-property "emu")
+    (iokit-property "external")
     (iokit-property "graphics-featureset-class") ;; <rdar://problem/49497720>
     (iokit-property "graphics-featureset-fallbacks") ;; <rdar://problem/51322072>
     (iokit-property "hdcp-hoover-protocol")

Modified: branches/safari-610.1.7-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (259223 => 259224)


--- branches/safari-610.1.7-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2020-03-30 20:56:41 UTC (rev 259223)
+++ branches/safari-610.1.7-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2020-03-30 20:56:44 UTC (rev 259224)
@@ -604,7 +604,6 @@
     (with report) (with telemetry)
 #endif
     (iokit-user-client-class "AppleMultitouchDeviceUserClient")
-    (iokit-user-client-class "AppleUpstreamUserClient")
     (iokit-user-client-class "IOHIDParamUserClient")
     (iokit-user-client-class "IOAudioControlUserClient")
     (iokit-user-client-class "IOAudioEngineUserClient")
@@ -612,6 +611,7 @@
     (iokit-user-client-class "AudioAUUC"))
 
 (allow iokit-open
+    (iokit-user-client-class "AppleUpstreamUserClient")
     (iokit-user-client-class "RootDomainUserClient") ;; Needed by WebCore::PerformanceMonitor
 )
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to