Title: [259293] trunk/Source/WebKit
- Revision
- 259293
- Author
- [email protected]
- Date
- 2020-03-31 09:09:09 -0700 (Tue, 31 Mar 2020)
Log Message
REGRESSION: (r259236) [ iOS and Catalina wk2 Debug ] ASSERTION FAILED: m_debugLoggingEnabled in WebKit::ResourceLoadStatisticsStore::debugBroadcastConsoleMessage
https://bugs.webkit.org/show_bug.cgi?id=209810
<rdar://problem/61106971>
Unreviewed, covered by existing tests.
* NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:
(WebKit::ResourceLoadStatisticsStore::debugBroadcastConsoleMessage):
Remove the assertion since `debugBroadcastConsoleMessage` is also called when turning off
debug logging mode via `setResourceLoadStatisticsDebugMode`. Fundamentally, it's just a
wrapper function for `broadcastConsoleMessage` anyways, so it doesn't need to be gated.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (259292 => 259293)
--- trunk/Source/WebKit/ChangeLog 2020-03-31 15:40:01 UTC (rev 259292)
+++ trunk/Source/WebKit/ChangeLog 2020-03-31 16:09:09 UTC (rev 259293)
@@ -1,3 +1,17 @@
+2020-03-31 Devin Rousso <[email protected]>
+
+ REGRESSION: (r259236) [ iOS and Catalina wk2 Debug ] ASSERTION FAILED: m_debugLoggingEnabled in WebKit::ResourceLoadStatisticsStore::debugBroadcastConsoleMessage
+ https://bugs.webkit.org/show_bug.cgi?id=209810
+ <rdar://problem/61106971>
+
+ Unreviewed, covered by existing tests.
+
+ * NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:
+ (WebKit::ResourceLoadStatisticsStore::debugBroadcastConsoleMessage):
+ Remove the assertion since `debugBroadcastConsoleMessage` is also called when turning off
+ debug logging mode via `setResourceLoadStatisticsDebugMode`. Fundamentally, it's just a
+ wrapper function for `broadcastConsoleMessage` anyways, so it doesn't need to be gated.
+
2020-03-31 Pablo Saavedra <[email protected]>
Several refactorings done in the MemoryPressureMonitor.cpp
Modified: trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp (259292 => 259293)
--- trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp 2020-03-31 15:40:01 UTC (rev 259292)
+++ trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp 2020-03-31 16:09:09 UTC (rev 259293)
@@ -588,8 +588,6 @@
void ResourceLoadStatisticsStore::debugBroadcastConsoleMessage(MessageSource source, MessageLevel level, const String& message)
{
- ASSERT(m_debugLoggingEnabled);
-
if (!RunLoop::isMain()) {
RunLoop::main().dispatch([&, weakThis = makeWeakPtr(*this), source = crossThreadCopy(source), level = crossThreadCopy(level), message = crossThreadCopy(message)]() {
if (!weakThis)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
