Title: [259479] trunk/Source/_javascript_Core
- Revision
- 259479
- Author
- [email protected]
- Date
- 2020-04-03 11:30:31 -0700 (Fri, 03 Apr 2020)
Log Message
Web Inspector: increase the auto-inspect debugger timeout delay to account for slower networks/devices
https://bugs.webkit.org/show_bug.cgi?id=209940
<rdar://problem/61120919>
Reviewed by Joseph Pecoraro.
* inspector/remote/cocoa/RemoteInspectorCocoa.mm:
(Inspector::RemoteInspector::updateAutomaticInspectionCandidate):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (259478 => 259479)
--- trunk/Source/_javascript_Core/ChangeLog 2020-04-03 18:29:05 UTC (rev 259478)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-04-03 18:30:31 UTC (rev 259479)
@@ -1,3 +1,14 @@
+2020-04-03 Devin Rousso <[email protected]>
+
+ Web Inspector: increase the auto-inspect debugger timeout delay to account for slower networks/devices
+ https://bugs.webkit.org/show_bug.cgi?id=209940
+ <rdar://problem/61120919>
+
+ Reviewed by Joseph Pecoraro.
+
+ * inspector/remote/cocoa/RemoteInspectorCocoa.mm:
+ (Inspector::RemoteInspector::updateAutomaticInspectionCandidate):
+
2020-04-03 Yusuke Suzuki <[email protected]>
[JSC] TypedArray#subarray should throw OOM error gracefully
Modified: trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorCocoa.mm (259478 => 259479)
--- trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorCocoa.mm 2020-04-03 18:29:05 UTC (rev 259478)
+++ trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorCocoa.mm 2020-04-03 18:30:31 UTC (rev 259479)
@@ -142,7 +142,7 @@
// To make this work we will need to change m_automaticInspectionCandidateTargetIdentifier to be a per-thread value.
// Multiple attempts on the same thread should not be possible because our nested run loop is in a special RWI mode.
if (m_automaticInspectionPaused) {
- LOG_ERROR("Skipping Automatic Inspection Candidate with pageId(%u) because we are already paused waiting for pageId(%u)", targetIdentifier, m_automaticInspectionCandidateTargetIdentifier);
+ WTFLogAlways("Skipping Automatic Inspection Candidate with pageId(%u) because we are already paused waiting for pageId(%u)", targetIdentifier, m_automaticInspectionCandidateTargetIdentifier);
pushListingsSoon();
return;
}
@@ -157,15 +157,11 @@
}
// In case debuggers fail to respond, or we cannot connect to webinspectord, automatically continue after a short period of time.
-#if PLATFORM(WATCHOS)
- int64_t debuggerTimeoutDelay = 5;
-#else
- int64_t debuggerTimeoutDelay = 1;
-#endif
+ int64_t debuggerTimeoutDelay = 10;
dispatch_after(dispatch_time(DISPATCH_TIME_NOW, debuggerTimeoutDelay * NSEC_PER_SEC), dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
LockHolder lock(m_mutex);
if (m_automaticInspectionCandidateTargetIdentifier == targetIdentifier) {
- LOG_ERROR("Skipping Automatic Inspection Candidate with pageId(%u) because we failed to receive a response in time.", m_automaticInspectionCandidateTargetIdentifier);
+ WTFLogAlways("Skipping Automatic Inspection Candidate with pageId(%u) because we failed to receive a response in time.", m_automaticInspectionCandidateTargetIdentifier);
m_automaticInspectionPaused = false;
}
});
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
